| Message ID | cover.1605688147.git.agx@sigxcpu.org |
|---|---|
| Headers | show |
| Series | drm/panel: mantix and st7703 fixes and additions | expand |
On Wed, Nov 18, 2020 at 9:29 AM Guido Günther <agx@sigxcpu.org> wrote: > This adds new panel type to the mantix driver as found on the Librem 5 and > fixes a glitch in the init sequence (affecting both panels). The fix is at the > start of the series to make backporting simpler. > It also adds a patch to make st7703 use dev_err_probe(). > > changes from v1 > - as per review comments by Linus Walleij > - fix alphabetical ordering in Documentation/devicetree/bindings/vendor-prefixes.yaml > https://lore.kernel.org/dri-devel/CACRpkdao_TMcpRsdK=7K5fNKJse0Bqwk58iWu0xsXdDNdcffVA@mail.gmail.com/ > - add reviewed by to all except 5/6, thanks The whole v2 looks fine to me, I'd give the devicetree maintainers some slack to review the DT patches then I can apply the whole series unless you have commit access yourself, just tell me. For all v2 patches: Reviewed-by: Linus Walleij <linus.walleij@linaro.org> If you have time, please review my s6e63m0 series. https://lore.kernel.org/dri-devel/20201117175621.870085-1-linus.walleij@linaro.org/ https://lore.kernel.org/dri-devel/20201117175621.870085-2-linus.walleij@linaro.org/ https://lore.kernel.org/dri-devel/20201117175621.870085-3-linus.walleij@linaro.org/ Yours, Linus Walleij
Hi Linus, On Thu, Nov 19, 2020 at 09:35:17AM +0100, Linus Walleij wrote: > On Wed, Nov 18, 2020 at 9:29 AM Guido Günther <agx@sigxcpu.org> wrote: > > > This adds new panel type to the mantix driver as found on the Librem 5 and > > fixes a glitch in the init sequence (affecting both panels). The fix is at the > > start of the series to make backporting simpler. > > It also adds a patch to make st7703 use dev_err_probe(). > > > > changes from v1 > > - as per review comments by Linus Walleij > > - fix alphabetical ordering in Documentation/devicetree/bindings/vendor-prefixes.yaml > > https://lore.kernel.org/dri-devel/CACRpkdao_TMcpRsdK=7K5fNKJse0Bqwk58iWu0xsXdDNdcffVA@mail.gmail.com/ > > - add reviewed by to all except 5/6, thanks > > The whole v2 looks fine to me, I'd give the devicetree > maintainers some slack to review the DT patches then I can > apply the whole series unless you have commit access yourself, > just tell me. I have commit access, so i can push in a couple of days. Thanks! > > For all v2 patches: > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > If you have time, please review my s6e63m0 series. > https://lore.kernel.org/dri-devel/20201117175621.870085-1-linus.walleij@linaro.org/ > https://lore.kernel.org/dri-devel/20201117175621.870085-2-linus.walleij@linaro.org/ > https://lore.kernel.org/dri-devel/20201117175621.870085-3-linus.walleij@linaro.org/ Done. The panel stuff is always scary with all those magic values. -- Guido > > Yours, > Linus Walleij >
Hi Guido, On Wed, Nov 18, 2020 at 09:29:47AM +0100, Guido Günther wrote: > This adds new panel type to the mantix driver as found on the Librem 5 and > fixes a glitch in the init sequence (affecting both panels). The fix is at the > start of the series to make backporting simpler. > It also adds a patch to make st7703 use dev_err_probe(). > > changes from v1 > - as per review comments by Linus Walleij > - fix alphabetical ordering in Documentation/devicetree/bindings/vendor-prefixes.yaml > https://lore.kernel.org/dri-devel/CACRpkdao_TMcpRsdK=7K5fNKJse0Bqwk58iWu0xsXdDNdcffVA@mail.gmail.com/ > - add reviewed by to all except 5/6, thanks > > Guido Günther (6): > drm/panel: st7703: Use dev_err_probe > drm/panel: mantix: Tweak init sequence > drm/panel: mantix: Allow to specify default mode for different panels > drm/panel: mantix: Support panel from Shenzhen Yashi Changhua > Intelligent Technology Co > dt-bindings: vendor-prefixes: Add ys vendor prefix The above are all: Reviewed-by: Sam Ravnborg <sam@ravnborg.org> > dt-binding: display: mantix: Add compatible for panel from YS Please fix the subjects to read "dt-bindings" - just to be consistent. With that: Reviewed-by: Sam Ravnborg <sam@ravnborg.org> Sam
On Wed, Nov 18, 2020 at 09:29:48AM +0100, Guido Günther wrote: > Less code and easier probe deferral debugging. > > Signed-off-by: Guido Günther <agx@sigxcpu.org> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Nice. I hope someone comes around and update all panel drivers to use dev_err_probe. It is simpler and better than the current code. And it will fix a lot of drivers that are noisy during deferral. Sam
Hi, On Mon, Nov 23, 2020 at 10:48:26PM +0100, Sam Ravnborg wrote: > Hi Guido, > > On Wed, Nov 18, 2020 at 09:29:47AM +0100, Guido Günther wrote: > > This adds new panel type to the mantix driver as found on the Librem 5 and > > fixes a glitch in the init sequence (affecting both panels). The fix is at the > > start of the series to make backporting simpler. > > It also adds a patch to make st7703 use dev_err_probe(). > > > > changes from v1 > > - as per review comments by Linus Walleij > > - fix alphabetical ordering in Documentation/devicetree/bindings/vendor-prefixes.yaml > > https://lore.kernel.org/dri-devel/CACRpkdao_TMcpRsdK=7K5fNKJse0Bqwk58iWu0xsXdDNdcffVA@mail.gmail.com/ > > - add reviewed by to all except 5/6, thanks > > > > Guido Günther (6): > > drm/panel: st7703: Use dev_err_probe > > drm/panel: mantix: Tweak init sequence > > drm/panel: mantix: Allow to specify default mode for different panels > > drm/panel: mantix: Support panel from Shenzhen Yashi Changhua > > Intelligent Technology Co > > dt-bindings: vendor-prefixes: Add ys vendor prefix > The above are all: > Reviewed-by: Sam Ravnborg <sam@ravnborg.org> > > > dt-binding: display: mantix: Add compatible for panel from YS > Please fix the subjects to read "dt-bindings" - just to be consistent. > With that: > Reviewed-by: Sam Ravnborg <sam@ravnborg.org> Fixed locally, thanks! -- Guido > > > Sam >
Hi Linus, On Thu, Nov 19, 2020 at 09:35:17AM +0100, Linus Walleij wrote: > On Wed, Nov 18, 2020 at 9:29 AM Guido Günther <agx@sigxcpu.org> wrote: > > > This adds new panel type to the mantix driver as found on the Librem 5 and > > fixes a glitch in the init sequence (affecting both panels). The fix is at the > > start of the series to make backporting simpler. > > It also adds a patch to make st7703 use dev_err_probe(). > > > > changes from v1 > > - as per review comments by Linus Walleij > > - fix alphabetical ordering in Documentation/devicetree/bindings/vendor-prefixes.yaml > > https://lore.kernel.org/dri-devel/CACRpkdao_TMcpRsdK=7K5fNKJse0Bqwk58iWu0xsXdDNdcffVA@mail.gmail.com/ > > - add reviewed by to all except 5/6, thanks > > The whole v2 looks fine to me, I'd give the devicetree > maintainers some slack to review the DT patches then I can > apply the whole series unless you have commit access yourself, > just tell me. Thanks. Is 2 weeks enough slack? Checking what's the rule of thumb here. Cheers, -- Guido > > For all v2 patches: > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > If you have time, please review my s6e63m0 series. > https://lore.kernel.org/dri-devel/20201117175621.870085-1-linus.walleij@linaro.org/ > https://lore.kernel.org/dri-devel/20201117175621.870085-2-linus.walleij@linaro.org/ > https://lore.kernel.org/dri-devel/20201117175621.870085-3-linus.walleij@linaro.org/ > > Yours, > Linus Walleij >
This adds new panel type to the mantix driver as found on the Librem 5 and fixes a glitch in the init sequence (affecting both panels). The fix is at the start of the series to make backporting simpler. It also adds a patch to make st7703 use dev_err_probe(). changes from v1 - as per review comments by Linus Walleij - fix alphabetical ordering in Documentation/devicetree/bindings/vendor-prefixes.yaml https://lore.kernel.org/dri-devel/CACRpkdao_TMcpRsdK=7K5fNKJse0Bqwk58iWu0xsXdDNdcffVA@mail.gmail.com/ - add reviewed by to all except 5/6, thanks Guido Günther (6): drm/panel: st7703: Use dev_err_probe drm/panel: mantix: Tweak init sequence drm/panel: mantix: Allow to specify default mode for different panels drm/panel: mantix: Support panel from Shenzhen Yashi Changhua Intelligent Technology Co dt-bindings: vendor-prefixes: Add ys vendor prefix dt-binding: display: mantix: Add compatible for panel from YS .../display/panel/mantix,mlaf057we51-x.yaml | 1 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + .../gpu/drm/panel/panel-mantix-mlaf057we51.c | 39 +++++++++++++++---- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 24 ++++-------- 4 files changed, 43 insertions(+), 23 deletions(-)