| Message ID | 1605296218-2510-4-git-send-email-skomatineni@nvidia.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add AHCI support for Tegra186 | expand |
On Fri, 13 Nov 2020 11:36:55 -0800, Sowjanya Komatineni wrote: > This patch converts text based dt-binding document to YAML based > dt-binding document. > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> > --- > .../devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 137 +++++++++++++++++++++ > .../bindings/ata/nvidia,tegra124-ahci.txt | 44 ------- > 2 files changed, 137 insertions(+), 44 deletions(-) > create mode 100644 Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml > delete mode 100644 Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Error: Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.example.dts:27.31-32 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:342: Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.example.dt.yaml] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1364: dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1400065 The base for the patch is generally the last rc1. Any dependencies should be noted. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 11/16/20 7:00 AM, Rob Herring wrote: > On Fri, 13 Nov 2020 11:36:55 -0800, Sowjanya Komatineni wrote: >> This patch converts text based dt-binding document to YAML based >> dt-binding document. >> >> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> >> --- >> .../devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 137 +++++++++++++++++++++ >> .../bindings/ata/nvidia,tegra124-ahci.txt | 44 ------- >> 2 files changed, 137 insertions(+), 44 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml >> delete mode 100644 Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt >> > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Error: Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.example.dts:27.31-32 syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:342: Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.example.dt.yaml] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [Makefile:1364: dt_binding_check] Error 2 > > > See https://patchwork.ozlabs.org/patch/1400065 > > The base for the patch is generally the last rc1. Any dependencies > should be noted. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. Hi Rob, make dt_binding_check shows other yaml warmings and didn't go thru tegra-ahci.yaml even with specifying DT_SHHEMA_FILES But, When I do dtbs_check, I see Documentation/devicetree/bindings/processed-schema.json generated and also it passes for tegra-ahci.yaml In v1 feedback discussion, you mentioned it should be good if dtbs_check passes. Regards, Sowjanya >
On Tue, Nov 17, 2020 at 10:15 AM Sowjanya Komatineni <skomatineni@nvidia.com> wrote: > > > On 11/16/20 7:00 AM, Rob Herring wrote: > > On Fri, 13 Nov 2020 11:36:55 -0800, Sowjanya Komatineni wrote: > >> This patch converts text based dt-binding document to YAML based > >> dt-binding document. > >> > >> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> > >> --- > >> .../devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 137 +++++++++++++++++++++ > >> .../bindings/ata/nvidia,tegra124-ahci.txt | 44 ------- > >> 2 files changed, 137 insertions(+), 44 deletions(-) > >> create mode 100644 Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml > >> delete mode 100644 Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt > >> > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > Error: Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.example.dts:27.31-32 syntax error > > FATAL ERROR: Unable to parse input tree > > make[1]: *** [scripts/Makefile.lib:342: Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.example.dt.yaml] Error 1 > > make[1]: *** Waiting for unfinished jobs.... > > make: *** [Makefile:1364: dt_binding_check] Error 2 > > > > > > See https://patchwork.ozlabs.org/patch/1400065 > > > > The base for the patch is generally the last rc1. Any dependencies > > should be noted. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > date: > > > > pip3 install dtschema --upgrade > > > > Please check and re-submit. > > Hi Rob, > > make dt_binding_check shows other yaml warmings and didn't go thru > tegra-ahci.yaml even with specifying DT_SHHEMA_FILES rc1 and rc3 were broken, so you need to use rc2. > But, When I do dtbs_check, I see > Documentation/devicetree/bindings/processed-schema.json generated and > also it passes for tegra-ahci.yaml > > > In v1 feedback discussion, you mentioned it should be good if dtbs_check > passes. dt_binding_check must pass without introducing errors/warnings. That's not yet a requirement for dtbs_check, but it is a good idea to run that and make sure any warnings are things that should be fixed in dts files rather than the binding schema. Rob
On Fri, Nov 13, 2020 at 1:36 PM Sowjanya Komatineni <skomatineni@nvidia.com> wrote: > > This patch converts text based dt-binding document to YAML based > dt-binding document. > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> > --- > .../devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 137 +++++++++++++++++++++ > .../bindings/ata/nvidia,tegra124-ahci.txt | 44 ------- > 2 files changed, 137 insertions(+), 44 deletions(-) > create mode 100644 Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml > delete mode 100644 Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt > > diff --git a/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml b/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml > new file mode 100644 > index 0000000..dbbe460 > --- /dev/null > +++ b/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml > @@ -0,0 +1,137 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/ata/nvidia,tegra-ahci.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tegra AHCI SATA Controller > + > +maintainers: > + - Thierry Reding <thierry.reding@gmail.com> > + - Jonathan Hunter <jonathanh@nvidia.com> > + > +properties: > + compatible: > + enum: > + - nvidia,tegra124-ahci > + - nvidia,tegra132-ahci > + - nvidia,tegra210-ahci > + > + reg: > + minItems: 2 > + maxItems: 3 > + items: > + - description: AHCI registers > + - description: SATA configuration and IPFS registers > + - description: SATA AUX registers > + > + interrupts: > + maxItems: 1 > + > + clock-names: > + items: > + - const: sata > + - const: sata-oob > + > + clocks: > + maxItems: 2 > + > + reset-names: > + items: > + - const: sata > + - const: sata-cold > + - const: sata-oob > + > + resets: > + maxItems: 3 > + > + phy-names: > + items: > + - const: sata-0 > + > + phys: > + maxItems: 1 > + > + hvdd-supply: > + description: SATA HVDD regulator supply. > + > + vddio-supply: > + description: SATA VDDIO regulator supply. > + > + avdd-supply: > + description: SATA AVDD regulator supply. > + > + target-5v-supply: > + description: SATA 5V power regulator supply. > + > + target-12v-supply: > + description: SATA 12V power regulator supply. > + > +required: > + - compatible > + - reg > + - interrupts > + - clock-names > + - clocks > + - reset-names > + - resets > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - nvidia,tegra124-ahci > + - nvidia,tegra132-ahci > + then: > + properties: > + reg: > + maxItems: 2 > + reset-names: > + minItems: 3 > + resets: > + minItems: 3 > + required: > + - phys > + - phy-names > + - hvdd-supply > + - vddio-supply > + - avdd-supply > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - nvidia,tegra210-ahci > + then: > + properties: > + reg: > + minItems: 3 > + reset-names: > + minItems: 3 > + resets: > + minItems: 3 > + > +additionalProperties: true > + > +examples: > + - | > + #include <dt-bindings/clock/tegra210-car.h> > + #include <dt-bindings/reset/tegra210-car.h> > + > + sata@70020000 { > + compatible = "nvidia,tegra210-ahci"; > + reg = <0x0 0x70027000 0x0 0x00002000>, /* AHCI */ > + <0x0 0x70020000 0x0 0x00007000>, /* SATA */ > + <0x0 0x70001100 0x0 0x00010000>; /* SATA AUX */ The default sizes are 1 cell for address and size, so this will give you warnings. You either need to adjust the entries here or add a parent node setting the sizes to 2 cells. > + interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>; The error is because you need the include files for these defines. > + clocks = <&tegra_car TEGRA210_CLK_SATA>, > + <&tegra_car TEGRA210_CLK_SATA_OOB>; > + clock-names = "sata", "sata-oob"; > + resets = <&tegra_car 124>, > + <&tegra_car 129>, > + <&tegra_car 123>; > + reset-names = "sata", "sata-cold", "sata-oob"; > + };
On 11/20/20 12:17 PM, Rob Herring wrote: > On Fri, Nov 13, 2020 at 1:36 PM Sowjanya Komatineni > <skomatineni@nvidia.com> wrote: >> This patch converts text based dt-binding document to YAML based >> dt-binding document. >> >> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> >> --- >> .../devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 137 +++++++++++++++++++++ >> .../bindings/ata/nvidia,tegra124-ahci.txt | 44 ------- >> 2 files changed, 137 insertions(+), 44 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml >> delete mode 100644 Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt >> >> diff --git a/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml b/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml >> new file mode 100644 >> index 0000000..dbbe460 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml >> @@ -0,0 +1,137 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/ata/nvidia,tegra-ahci.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Tegra AHCI SATA Controller >> + >> +maintainers: >> + - Thierry Reding <thierry.reding@gmail.com> >> + - Jonathan Hunter <jonathanh@nvidia.com> >> + >> +properties: >> + compatible: >> + enum: >> + - nvidia,tegra124-ahci >> + - nvidia,tegra132-ahci >> + - nvidia,tegra210-ahci >> + >> + reg: >> + minItems: 2 >> + maxItems: 3 >> + items: >> + - description: AHCI registers >> + - description: SATA configuration and IPFS registers >> + - description: SATA AUX registers >> + >> + interrupts: >> + maxItems: 1 >> + >> + clock-names: >> + items: >> + - const: sata >> + - const: sata-oob >> + >> + clocks: >> + maxItems: 2 >> + >> + reset-names: >> + items: >> + - const: sata >> + - const: sata-cold >> + - const: sata-oob >> + >> + resets: >> + maxItems: 3 >> + >> + phy-names: >> + items: >> + - const: sata-0 >> + >> + phys: >> + maxItems: 1 >> + >> + hvdd-supply: >> + description: SATA HVDD regulator supply. >> + >> + vddio-supply: >> + description: SATA VDDIO regulator supply. >> + >> + avdd-supply: >> + description: SATA AVDD regulator supply. >> + >> + target-5v-supply: >> + description: SATA 5V power regulator supply. >> + >> + target-12v-supply: >> + description: SATA 12V power regulator supply. >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - clock-names >> + - clocks >> + - reset-names >> + - resets >> + >> +allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - nvidia,tegra124-ahci >> + - nvidia,tegra132-ahci >> + then: >> + properties: >> + reg: >> + maxItems: 2 >> + reset-names: >> + minItems: 3 >> + resets: >> + minItems: 3 >> + required: >> + - phys >> + - phy-names >> + - hvdd-supply >> + - vddio-supply >> + - avdd-supply >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - nvidia,tegra210-ahci >> + then: >> + properties: >> + reg: >> + minItems: 3 >> + reset-names: >> + minItems: 3 >> + resets: >> + minItems: 3 >> + >> +additionalProperties: true >> + >> +examples: >> + - | >> + #include <dt-bindings/clock/tegra210-car.h> >> + #include <dt-bindings/reset/tegra210-car.h> >> + >> + sata@70020000 { >> + compatible = "nvidia,tegra210-ahci"; >> + reg = <0x0 0x70027000 0x0 0x00002000>, /* AHCI */ >> + <0x0 0x70020000 0x0 0x00007000>, /* SATA */ >> + <0x0 0x70001100 0x0 0x00010000>; /* SATA AUX */ > The default sizes are 1 cell for address and size, so this will give > you warnings. You either need to adjust the entries here or add a > parent node setting the sizes to 2 cells. Thanks Rob. tegra210.dtsi already has address and size set to 2 cells in parent node of sata. Do you mean to add parent node and address and size cells set to 2 in this yaml example as well? > >> + interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>; > The error is because you need the include files for these defines. Will add header file for interrupts in yaml example. > >> + clocks = <&tegra_car TEGRA210_CLK_SATA>, >> + <&tegra_car TEGRA210_CLK_SATA_OOB>; >> + clock-names = "sata", "sata-oob"; >> + resets = <&tegra_car 124>, >> + <&tegra_car 129>, >> + <&tegra_car 123>; >> + reset-names = "sata", "sata-cold", "sata-oob"; >> + };
On 11/23/20 11:01 AM, Sowjanya Komatineni wrote: > > On 11/20/20 12:17 PM, Rob Herring wrote: >> On Fri, Nov 13, 2020 at 1:36 PM Sowjanya Komatineni >> <skomatineni@nvidia.com> wrote: >>> This patch converts text based dt-binding document to YAML based >>> dt-binding document. >>> >>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> >>> --- >>> .../devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 137 >>> +++++++++++++++++++++ >>> .../bindings/ata/nvidia,tegra124-ahci.txt | 44 ------- >>> 2 files changed, 137 insertions(+), 44 deletions(-) >>> create mode 100644 >>> Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml >>> delete mode 100644 >>> Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt >>> >>> diff --git >>> a/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml >>> b/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml >>> new file mode 100644 >>> index 0000000..dbbe460 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml >>> @@ -0,0 +1,137 @@ >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/ata/nvidia,tegra-ahci.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Tegra AHCI SATA Controller >>> + >>> +maintainers: >>> + - Thierry Reding <thierry.reding@gmail.com> >>> + - Jonathan Hunter <jonathanh@nvidia.com> >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - nvidia,tegra124-ahci >>> + - nvidia,tegra132-ahci >>> + - nvidia,tegra210-ahci >>> + >>> + reg: >>> + minItems: 2 >>> + maxItems: 3 >>> + items: >>> + - description: AHCI registers >>> + - description: SATA configuration and IPFS registers >>> + - description: SATA AUX registers >>> + >>> + interrupts: >>> + maxItems: 1 >>> + >>> + clock-names: >>> + items: >>> + - const: sata >>> + - const: sata-oob >>> + >>> + clocks: >>> + maxItems: 2 >>> + >>> + reset-names: >>> + items: >>> + - const: sata >>> + - const: sata-cold >>> + - const: sata-oob >>> + >>> + resets: >>> + maxItems: 3 >>> + >>> + phy-names: >>> + items: >>> + - const: sata-0 >>> + >>> + phys: >>> + maxItems: 1 >>> + >>> + hvdd-supply: >>> + description: SATA HVDD regulator supply. >>> + >>> + vddio-supply: >>> + description: SATA VDDIO regulator supply. >>> + >>> + avdd-supply: >>> + description: SATA AVDD regulator supply. >>> + >>> + target-5v-supply: >>> + description: SATA 5V power regulator supply. >>> + >>> + target-12v-supply: >>> + description: SATA 12V power regulator supply. >>> + >>> +required: >>> + - compatible >>> + - reg >>> + - interrupts >>> + - clock-names >>> + - clocks >>> + - reset-names >>> + - resets >>> + >>> +allOf: >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - nvidia,tegra124-ahci >>> + - nvidia,tegra132-ahci >>> + then: >>> + properties: >>> + reg: >>> + maxItems: 2 >>> + reset-names: >>> + minItems: 3 >>> + resets: >>> + minItems: 3 >>> + required: >>> + - phys >>> + - phy-names >>> + - hvdd-supply >>> + - vddio-supply >>> + - avdd-supply >>> + >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - nvidia,tegra210-ahci >>> + then: >>> + properties: >>> + reg: >>> + minItems: 3 >>> + reset-names: >>> + minItems: 3 >>> + resets: >>> + minItems: 3 >>> + >>> +additionalProperties: true >>> + >>> +examples: >>> + - | >>> + #include <dt-bindings/clock/tegra210-car.h> >>> + #include <dt-bindings/reset/tegra210-car.h> >>> + >>> + sata@70020000 { >>> + compatible = "nvidia,tegra210-ahci"; >>> + reg = <0x0 0x70027000 0x0 0x00002000>, /* AHCI */ >>> + <0x0 0x70020000 0x0 0x00007000>, /* SATA */ >>> + <0x0 0x70001100 0x0 0x00010000>; /* SATA AUX */ >> The default sizes are 1 cell for address and size, so this will give >> you warnings. You either need to adjust the entries here or add a >> parent node setting the sizes to 2 cells. > > Thanks Rob. > > tegra210.dtsi already has address and size set to 2 cells in parent > node of sata. > > Do you mean to add parent node and address and size cells set to 2 in > this yaml example as well? >> >>> + interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>; >> The error is because you need the include files for these defines. > Will add header file for interrupts in yaml example. >> >>> + clocks = <&tegra_car TEGRA210_CLK_SATA>, >>> + <&tegra_car TEGRA210_CLK_SATA_OOB>; >>> + clock-names = "sata", "sata-oob"; >>> + resets = <&tegra_car 124>, >>> + <&tegra_car 129>, >>> + <&tegra_car 123>; >>> + reset-names = "sata", "sata-cold", "sata-oob"; >>> + }; updated reg value with single address and single size along with interrupt header file. dt_binding_check pass without errors. Will send v3.
diff --git a/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml b/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml new file mode 100644 index 0000000..dbbe460 --- /dev/null +++ b/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml @@ -0,0 +1,137 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/ata/nvidia,tegra-ahci.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Tegra AHCI SATA Controller + +maintainers: + - Thierry Reding <thierry.reding@gmail.com> + - Jonathan Hunter <jonathanh@nvidia.com> + +properties: + compatible: + enum: + - nvidia,tegra124-ahci + - nvidia,tegra132-ahci + - nvidia,tegra210-ahci + + reg: + minItems: 2 + maxItems: 3 + items: + - description: AHCI registers + - description: SATA configuration and IPFS registers + - description: SATA AUX registers + + interrupts: + maxItems: 1 + + clock-names: + items: + - const: sata + - const: sata-oob + + clocks: + maxItems: 2 + + reset-names: + items: + - const: sata + - const: sata-cold + - const: sata-oob + + resets: + maxItems: 3 + + phy-names: + items: + - const: sata-0 + + phys: + maxItems: 1 + + hvdd-supply: + description: SATA HVDD regulator supply. + + vddio-supply: + description: SATA VDDIO regulator supply. + + avdd-supply: + description: SATA AVDD regulator supply. + + target-5v-supply: + description: SATA 5V power regulator supply. + + target-12v-supply: + description: SATA 12V power regulator supply. + +required: + - compatible + - reg + - interrupts + - clock-names + - clocks + - reset-names + - resets + +allOf: + - if: + properties: + compatible: + contains: + enum: + - nvidia,tegra124-ahci + - nvidia,tegra132-ahci + then: + properties: + reg: + maxItems: 2 + reset-names: + minItems: 3 + resets: + minItems: 3 + required: + - phys + - phy-names + - hvdd-supply + - vddio-supply + - avdd-supply + + - if: + properties: + compatible: + contains: + enum: + - nvidia,tegra210-ahci + then: + properties: + reg: + minItems: 3 + reset-names: + minItems: 3 + resets: + minItems: 3 + +additionalProperties: true + +examples: + - | + #include <dt-bindings/clock/tegra210-car.h> + #include <dt-bindings/reset/tegra210-car.h> + + sata@70020000 { + compatible = "nvidia,tegra210-ahci"; + reg = <0x0 0x70027000 0x0 0x00002000>, /* AHCI */ + <0x0 0x70020000 0x0 0x00007000>, /* SATA */ + <0x0 0x70001100 0x0 0x00010000>; /* SATA AUX */ + interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&tegra_car TEGRA210_CLK_SATA>, + <&tegra_car TEGRA210_CLK_SATA_OOB>; + clock-names = "sata", "sata-oob"; + resets = <&tegra_car 124>, + <&tegra_car 129>, + <&tegra_car 123>; + reset-names = "sata", "sata-cold", "sata-oob"; + }; diff --git a/Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt b/Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt deleted file mode 100644 index 12ab2f7..0000000 --- a/Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt +++ /dev/null @@ -1,44 +0,0 @@ -Tegra SoC SATA AHCI controller - -Required properties : -- compatible : Must be one of: - - Tegra124 : "nvidia,tegra124-ahci" - - Tegra132 : "nvidia,tegra132-ahci", "nvidia,tegra124-ahci" - - Tegra210 : "nvidia,tegra210-ahci" -- reg : Should contain 2 entries: - - AHCI register set (SATA BAR5) - - SATA register set -- interrupts : Defines the interrupt used by SATA -- clocks : Must contain an entry for each entry in clock-names. - See ../clocks/clock-bindings.txt for details. -- clock-names : Must include the following entries: - - sata - - sata-oob -- resets : Must contain an entry for each entry in reset-names. - See ../reset/reset.txt for details. -- reset-names : Must include the following entries: - - sata - - sata-oob - - sata-cold -- phys : Must contain an entry for each entry in phy-names. - See ../phy/phy-bindings.txt for details. -- phy-names : Must include the following entries: - - For Tegra124 and Tegra132: - - sata-phy : XUSB PADCTL SATA PHY -- For Tegra124 and Tegra132: - - hvdd-supply : Defines the SATA HVDD regulator - - vddio-supply : Defines the SATA VDDIO regulator - - avdd-supply : Defines the SATA AVDD regulator - - target-5v-supply : Defines the SATA 5V power regulator - - target-12v-supply : Defines the SATA 12V power regulator - -Optional properties: -- reg : - - AUX register set -- clock-names : - - cml1 : - cml1 clock should be defined here if the PHY driver - doesn't manage them. If it does, they should not be. -- phy-names : - - For T210: - - sata-phy
This patch converts text based dt-binding document to YAML based dt-binding document. Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> --- .../devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 137 +++++++++++++++++++++ .../bindings/ata/nvidia,tegra124-ahci.txt | 44 ------- 2 files changed, 137 insertions(+), 44 deletions(-) create mode 100644 Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml delete mode 100644 Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt