| Message ID | 20201119125304.1279-2-aisheng.dong@nxp.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [1/3] dt-bindings: mmc: imx: fix the wrongly dropped imx8qm compatible string | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success |
On Thu, Nov 19, 2020 at 08:53:03PM +0800, Dong Aisheng wrote: > Add imx8qm boards compatible string > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: devicetree@vger.kernel.org > Cc: Shawn Guo <shawnguo@kernel.org> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > --- > Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index f793f90fe2e6..d69ac5c0554e 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -726,6 +726,12 @@ properties: > - const: zii,imx8mq-ultra > - const: fsl,imx8mq > > + - description: i.MX8QM based Boards > + items: > + - enum: > + - fsl,imx8qm-mek # i.MX8QM MEK Board No, please include the boards DTS in this patchset. Best regards, Krzysztof
> From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Thursday, November 19, 2020 9:22 PM > > On Thu, Nov 19, 2020 at 08:53:03PM +0800, Dong Aisheng wrote: > > Add imx8qm boards compatible string > > > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: devicetree@vger.kernel.org > > Cc: Shawn Guo <shawnguo@kernel.org> > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > > --- > > Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml > b/Documentation/devicetree/bindings/arm/fsl.yaml > > index f793f90fe2e6..d69ac5c0554e 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -726,6 +726,12 @@ properties: > > - const: zii,imx8mq-ultra > > - const: fsl,imx8mq > > > > + - description: i.MX8QM based Boards > > + items: > > + - enum: > > + - fsl,imx8qm-mek # i.MX8QM MEK Board > > No, please include the boards DTS in this patchset. Good suggestion. Should I resend as DT patchset using it was also under review? Regards Aisheng > > Best regards, > Krzysztof
On Thu, Nov 19, 2020 at 03:25:38PM +0000, Aisheng Dong wrote: > > From: Krzysztof Kozlowski <krzk@kernel.org> > > Sent: Thursday, November 19, 2020 9:22 PM > > > > On Thu, Nov 19, 2020 at 08:53:03PM +0800, Dong Aisheng wrote: > > > Add imx8qm boards compatible string > > > > > > Cc: Rob Herring <robh+dt@kernel.org> > > > Cc: devicetree@vger.kernel.org > > > Cc: Shawn Guo <shawnguo@kernel.org> > > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > > > --- > > > Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml > > b/Documentation/devicetree/bindings/arm/fsl.yaml > > > index f793f90fe2e6..d69ac5c0554e 100644 > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > > @@ -726,6 +726,12 @@ properties: > > > - const: zii,imx8mq-ultra > > > - const: fsl,imx8mq > > > > > > + - description: i.MX8QM based Boards > > > + items: > > > + - enum: > > > + - fsl,imx8qm-mek # i.MX8QM MEK Board > > > > No, please include the boards DTS in this patchset. > > Good suggestion. Should I resend as DT patchset using it was also under review? Patchsets bringing new boards should be organized like this one: https://lore.kernel.org/lkml/20201107144811.1977108-1-aford173@gmail.com/ First the vendor prefix binding (skipped above), then the board binding and finally DTS patches. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index f793f90fe2e6..d69ac5c0554e 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -726,6 +726,12 @@ properties: - const: zii,imx8mq-ultra - const: fsl,imx8mq + - description: i.MX8QM based Boards + items: + - enum: + - fsl,imx8qm-mek # i.MX8QM MEK Board + - const: fsl,imx8qm + - description: i.MX8QXP based Boards items: - enum:
Add imx8qm boards compatible string Cc: Rob Herring <robh+dt@kernel.org> Cc: devicetree@vger.kernel.org Cc: Shawn Guo <shawnguo@kernel.org> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> --- Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++ 1 file changed, 6 insertions(+)