| Message ID | 20201113044731.570886-1-kai.heng.feng@canonical.com |
|---|---|
| Headers | show |
| Series | Fix noise lines on i915 + Xorg | expand |
On 13.11.20 05:47, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1896091 > > [Impact] > Noise-like lines of graphics corruption when moving windows in Xorg > sessions. > > [Fix] > Revert "UBUNTU: SAUCE: drm/i915: Synchronize active and retire > callbacks". > > [Test] > Daniel van Vugt confirmed reverting the commit fixes the issue. > I can also reproduce the issue on one of my system, I can confirm it > fixes the issue too. > > [Where problems could occur] > Race condition the commit solves may appear again. > However it was to solve the issue on 5.4, and the race could already be > solved on 5.8. Is there no way to double check that before we re-open a problem here? -Stefan > > Kai-Heng Feng (1): > Revert "UBUNTU: SAUCE: drm/i915: Synchronize active and retire > callbacks" > > drivers/gpu/drm/i915/i915_active.c | 52 ++++-------------------- > drivers/gpu/drm/i915/i915_active.h | 10 +++-- > drivers/gpu/drm/i915/i915_active_types.h | 2 - > 3 files changed, 14 insertions(+), 50 deletions(-) >
> On Nov 13, 2020, at 16:05, Stefan Bader <stefan.bader@canonical.com> wrote: > > On 13.11.20 05:47, Kai-Heng Feng wrote: >> BugLink: https://bugs.launchpad.net/bugs/1896091 >> >> [Impact] >> Noise-like lines of graphics corruption when moving windows in Xorg >> sessions. >> >> [Fix] >> Revert "UBUNTU: SAUCE: drm/i915: Synchronize active and retire >> callbacks". >> >> [Test] >> Daniel van Vugt confirmed reverting the commit fixes the issue. >> I can also reproduce the issue on one of my system, I can confirm it >> fixes the issue too. >> >> [Where problems could occur] >> Race condition the commit solves may appear again. >> However it was to solve the issue on 5.4, and the race could already be >> solved on 5.8. > > Is there no way to double check that before we re-open a problem here? Actually this commit was also reverted in Focal, replaced by upstream fix "drm/i915/gt: Make intel_ring_unpin() safe for concurrent pint", which is already part of Groovy. Kai-Heng > > -Stefan > >> >> Kai-Heng Feng (1): >> Revert "UBUNTU: SAUCE: drm/i915: Synchronize active and retire >> callbacks" >> >> drivers/gpu/drm/i915/i915_active.c | 52 ++++-------------------- >> drivers/gpu/drm/i915/i915_active.h | 10 +++-- >> drivers/gpu/drm/i915/i915_active_types.h | 2 - >> 3 files changed, 14 insertions(+), 50 deletions(-)
On Fri, Nov 13, 2020 at 12:47:30PM +0800, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1896091 > > [Impact] > Noise-like lines of graphics corruption when moving windows in Xorg > sessions. > > [Fix] > Revert "UBUNTU: SAUCE: drm/i915: Synchronize active and retire > callbacks". > > [Test] > Daniel van Vugt confirmed reverting the commit fixes the issue. > I can also reproduce the issue on one of my system, I can confirm it > fixes the issue too. > > [Where problems could occur] > Race condition the commit solves may appear again. > However it was to solve the issue on 5.4, and the race could already be > solved on 5.8. > > Kai-Heng Feng (1): > Revert "UBUNTU: SAUCE: drm/i915: Synchronize active and retire > callbacks" > > drivers/gpu/drm/i915/i915_active.c | 52 ++++-------------------- > drivers/gpu/drm/i915/i915_active.h | 10 +++-- > drivers/gpu/drm/i915/i915_active_types.h | 2 - > 3 files changed, 14 insertions(+), 50 deletions(-) > > -- > 2.28.0 Applied to Groovy:linux. William Breathitt Gray
BugLink: https://bugs.launchpad.net/bugs/1896091 [Impact] Noise-like lines of graphics corruption when moving windows in Xorg sessions. [Fix] Revert "UBUNTU: SAUCE: drm/i915: Synchronize active and retire callbacks". [Test] Daniel van Vugt confirmed reverting the commit fixes the issue. I can also reproduce the issue on one of my system, I can confirm it fixes the issue too. [Where problems could occur] Race condition the commit solves may appear again. However it was to solve the issue on 5.4, and the race could already be solved on 5.8. Kai-Heng Feng (1): Revert "UBUNTU: SAUCE: drm/i915: Synchronize active and retire callbacks" drivers/gpu/drm/i915/i915_active.c | 52 ++++-------------------- drivers/gpu/drm/i915/i915_active.h | 10 +++-- drivers/gpu/drm/i915/i915_active_types.h | 2 - 3 files changed, 14 insertions(+), 50 deletions(-)