| Message ID | 20201111232330.30843-1-rentao.bupt@gmail.com |
|---|---|
| Headers | show |
| Series | ARM: dts: aspeed: Add Facebook Galaxy100 BMC | expand |
On Wed, 11 Nov 2020 at 23:23, <rentao.bupt@gmail.com> wrote: > > From: Tao Ren <rentao.bupt@gmail.com> > > The patch series adds the initial version of device tree for Facebook > Galaxy100 (AST2400) BMC. > > Patch #1 adds common dtsi to minimize duplicated device entries across > Facebook Network AST2400 BMC device trees. > > Patch #2 simplfies Wedge40 device tree by using the common dtsi. > > Patch #3 simplfies Wedge100 device tree by using the common dtsi. > > Patch #4 adds the initial version of device tree for Facebook Galaxy100 > BMC. Nice. They look good to me. Reviewed-by: Joel Stanley <joel@jms.id.au> Is there another person familiar with the design you would like to review before I merge? > > Tao Ren (4): > ARM: dts: aspeed: Common dtsi for Facebook AST2400 Network BMCs > ARM: dts: aspeed: wedge40: Use common dtsi > ARM: dts: aspeed: wedge100: Use common dtsi > ARM: dts: aspeed: Add Facebook Galaxy100 (AST2400) BMC > > arch/arm/boot/dts/Makefile | 1 + > .../dts/aspeed-bmc-facebook-galaxy100.dts | 57 +++++++++ > .../boot/dts/aspeed-bmc-facebook-wedge100.dts | 120 +++--------------- > .../boot/dts/aspeed-bmc-facebook-wedge40.dts | 112 +--------------- > .../dts/ast2400-facebook-netbmc-common.dtsi | 117 +++++++++++++++++ > 5 files changed, 191 insertions(+), 216 deletions(-) > create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-galaxy100.dts > create mode 100644 arch/arm/boot/dts/ast2400-facebook-netbmc-common.dtsi > > -- > 2.17.1 >
On Wed, Nov 11, 2020 at 11:34:10PM +0000, Joel Stanley wrote: > On Wed, 11 Nov 2020 at 23:23, <rentao.bupt@gmail.com> wrote: > > > > From: Tao Ren <rentao.bupt@gmail.com> > > > > The patch series adds the initial version of device tree for Facebook > > Galaxy100 (AST2400) BMC. > > > > Patch #1 adds common dtsi to minimize duplicated device entries across > > Facebook Network AST2400 BMC device trees. > > > > Patch #2 simplfies Wedge40 device tree by using the common dtsi. > > > > Patch #3 simplfies Wedge100 device tree by using the common dtsi. > > > > Patch #4 adds the initial version of device tree for Facebook Galaxy100 > > BMC. > > Nice. They look good to me. > > Reviewed-by: Joel Stanley <joel@jms.id.au> Thanks a lot for the quick review, Joel. > Is there another person familiar with the design you would like to > review before I merge? Patrick Williams sometimes helps reviewing my patches although he doesn't work on Network BMCs. Let me see if he has bandwidth this time :) Cheers, Tao
On Wed, Nov 11, 2020 at 11:34:10PM +0000, Joel Stanley wrote: > On Wed, 11 Nov 2020 at 23:23, <rentao.bupt@gmail.com> wrote: > > > > From: Tao Ren <rentao.bupt@gmail.com> > > > > The patch series adds the initial version of device tree for Facebook > > Galaxy100 (AST2400) BMC. > > > > Patch #1 adds common dtsi to minimize duplicated device entries across > > Facebook Network AST2400 BMC device trees. > > > > Patch #2 simplfies Wedge40 device tree by using the common dtsi. > > > > Patch #3 simplfies Wedge100 device tree by using the common dtsi. > > > > Patch #4 adds the initial version of device tree for Facebook Galaxy100 > > BMC. > > Nice. They look good to me. > > Reviewed-by: Joel Stanley <joel@jms.id.au> > > Is there another person familiar with the design you would like to > review before I merge? Also, Reviewed-by: Patrick Williams <patrick@stwcx.xyz>
On Wed, Nov 11, 2020 at 09:18:28PM -0600, Patrick Williams wrote: > On Wed, Nov 11, 2020 at 11:34:10PM +0000, Joel Stanley wrote: > > On Wed, 11 Nov 2020 at 23:23, <rentao.bupt@gmail.com> wrote: > > > > > > From: Tao Ren <rentao.bupt@gmail.com> > > > > > > The patch series adds the initial version of device tree for Facebook > > > Galaxy100 (AST2400) BMC. > > > > > > Patch #1 adds common dtsi to minimize duplicated device entries across > > > Facebook Network AST2400 BMC device trees. > > > > > > Patch #2 simplfies Wedge40 device tree by using the common dtsi. > > > > > > Patch #3 simplfies Wedge100 device tree by using the common dtsi. > > > > > > Patch #4 adds the initial version of device tree for Facebook Galaxy100 > > > BMC. > > > > Nice. They look good to me. > > > > Reviewed-by: Joel Stanley <joel@jms.id.au> > > > > Is there another person familiar with the design you would like to > > review before I merge? > > Also, > > Reviewed-by: Patrick Williams <patrick@stwcx.xyz> > > -- > Patrick Williams Thank you Patrick! Cheers, Tao
On Thu, 12 Nov 2020 at 03:18, Patrick Williams <patrick@stwcx.xyz> wrote: > > On Wed, Nov 11, 2020 at 11:34:10PM +0000, Joel Stanley wrote: > > On Wed, 11 Nov 2020 at 23:23, <rentao.bupt@gmail.com> wrote: > > > > > > From: Tao Ren <rentao.bupt@gmail.com> > > > > > > The patch series adds the initial version of device tree for Facebook > > > Galaxy100 (AST2400) BMC. > > > > > > Patch #1 adds common dtsi to minimize duplicated device entries across > > > Facebook Network AST2400 BMC device trees. > > > > > > Patch #2 simplfies Wedge40 device tree by using the common dtsi. > > > > > > Patch #3 simplfies Wedge100 device tree by using the common dtsi. > > > > > > Patch #4 adds the initial version of device tree for Facebook Galaxy100 > > > BMC. > > > > Nice. They look good to me. > > > > Reviewed-by: Joel Stanley <joel@jms.id.au> > > > > Is there another person familiar with the design you would like to > > review before I merge? > > Also, > > Reviewed-by: Patrick Williams <patrick@stwcx.xyz> Thanks. I have merged them into the aspeed tree for 5.11. Cheers, Joel
On Thu, Nov 12, 2020 at 05:49:30AM +0000, Joel Stanley wrote: > On Thu, 12 Nov 2020 at 03:18, Patrick Williams <patrick@stwcx.xyz> wrote: > > > > On Wed, Nov 11, 2020 at 11:34:10PM +0000, Joel Stanley wrote: > > > On Wed, 11 Nov 2020 at 23:23, <rentao.bupt@gmail.com> wrote: > > > > > > > > From: Tao Ren <rentao.bupt@gmail.com> > > > > > > > > The patch series adds the initial version of device tree for Facebook > > > > Galaxy100 (AST2400) BMC. > > > > > > > > Patch #1 adds common dtsi to minimize duplicated device entries across > > > > Facebook Network AST2400 BMC device trees. > > > > > > > > Patch #2 simplfies Wedge40 device tree by using the common dtsi. > > > > > > > > Patch #3 simplfies Wedge100 device tree by using the common dtsi. > > > > > > > > Patch #4 adds the initial version of device tree for Facebook Galaxy100 > > > > BMC. > > > > > > Nice. They look good to me. > > > > > > Reviewed-by: Joel Stanley <joel@jms.id.au> > > > > > > Is there another person familiar with the design you would like to > > > review before I merge? > > > > Also, > > > > Reviewed-by: Patrick Williams <patrick@stwcx.xyz> > > Thanks. I have merged them into the aspeed tree for 5.11. > > Cheers, > > Joel Thank you Joel. BTW, I sent out another 2 patches for AST2500 dts earlier this week; not sure if they were successfully delivered; if not, I will resend them earlier next week. Cheers, Tao
From: Tao Ren <rentao.bupt@gmail.com> The patch series adds the initial version of device tree for Facebook Galaxy100 (AST2400) BMC. Patch #1 adds common dtsi to minimize duplicated device entries across Facebook Network AST2400 BMC device trees. Patch #2 simplfies Wedge40 device tree by using the common dtsi. Patch #3 simplfies Wedge100 device tree by using the common dtsi. Patch #4 adds the initial version of device tree for Facebook Galaxy100 BMC. Tao Ren (4): ARM: dts: aspeed: Common dtsi for Facebook AST2400 Network BMCs ARM: dts: aspeed: wedge40: Use common dtsi ARM: dts: aspeed: wedge100: Use common dtsi ARM: dts: aspeed: Add Facebook Galaxy100 (AST2400) BMC arch/arm/boot/dts/Makefile | 1 + .../dts/aspeed-bmc-facebook-galaxy100.dts | 57 +++++++++ .../boot/dts/aspeed-bmc-facebook-wedge100.dts | 120 +++--------------- .../boot/dts/aspeed-bmc-facebook-wedge40.dts | 112 +--------------- .../dts/ast2400-facebook-netbmc-common.dtsi | 117 +++++++++++++++++ 5 files changed, 191 insertions(+), 216 deletions(-) create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-galaxy100.dts create mode 100644 arch/arm/boot/dts/ast2400-facebook-netbmc-common.dtsi