diff mbox series

[net] net: phy: mscc: remove non-MACSec compatible phy

Message ID 20201112090429.906000-1-steen.hegelund@microchip.com
State Superseded
Headers show
Series [net] net: phy: mscc: remove non-MACSec compatible phy | expand

Commit Message

Steen Hegelund Nov. 12, 2020, 9:04 a.m. UTC 
Selecting VSC8575 as a MACSec PHY was not correct

The relevant datasheet can be found here:
  - VSC8575: https://www.microchip.com/wwwproducts/en/VSC8575

Fixes: 0a504e9e97886 ("net: phy: mscc: macsec initialization")
Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>
---
 drivers/net/phy/mscc/mscc_macsec.c | 1 -
 1 file changed, 1 deletion(-)

--
2.29.2

Comments

Jakub Kicinski Nov. 12, 2020, 10:28 p.m. UTC | #1 
On Thu, 12 Nov 2020 10:04:29 +0100 Steen Hegelund wrote:
> Selecting VSC8575 as a MACSec PHY was not correct
> 
> The relevant datasheet can be found here:
>   - VSC8575: https://www.microchip.com/wwwproducts/en/VSC8575
> 
> Fixes: 0a504e9e97886 ("net: phy: mscc: macsec initialization")
> Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>

Fixes tag: Fixes: 0a504e9e97886 ("net: phy: mscc: macsec initialization")
Has these problem(s):
	- Subject does not match target commit subject
	  Just use
		git log -1 --format='Fixes: %h ("%s")'
Steen Hegelund Nov. 13, 2020, 8:42 a.m. UTC | #2 
On 12.11.2020 14:28, Jakub Kicinski wrote:
>EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
>On Thu, 12 Nov 2020 10:04:29 +0100 Steen Hegelund wrote:
>> Selecting VSC8575 as a MACSec PHY was not correct
>>
>> The relevant datasheet can be found here:
>>   - VSC8575: https://www.microchip.com/wwwproducts/en/VSC8575
>>
>> Fixes: 0a504e9e97886 ("net: phy: mscc: macsec initialization")
>> Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>
>
>Fixes tag: Fixes: 0a504e9e97886 ("net: phy: mscc: macsec initialization")
>Has these problem(s):
>        - Subject does not match target commit subject
>          Just use
>                git log -1 --format='Fixes: %h ("%s")'
Hi Jacub,

Right, that sha was for a tree object, not a commit. I should have
checked that.
Thanks for the log command example.  That is really useful.

BR
Steen

---------------------------------------
Steen Hegelund
steen.hegelund@microchip.com
diff mbox series

Patch

diff --git a/drivers/net/phy/mscc/mscc_macsec.c b/drivers/net/phy/mscc/mscc_macsec.c
index 1d4c012194e9..72292bf6c51c 100644
--- a/drivers/net/phy/mscc/mscc_macsec.c
+++ b/drivers/net/phy/mscc/mscc_macsec.c
@@ -981,7 +981,6 @@  int vsc8584_macsec_init(struct phy_device *phydev)

 	switch (phydev->phy_id & phydev->drv->phy_id_mask) {
 	case PHY_ID_VSC856X:
-	case PHY_ID_VSC8575:
 	case PHY_ID_VSC8582:
 	case PHY_ID_VSC8584:
 		INIT_LIST_HEAD(&vsc8531->macsec_flows);