Message ID | 1605071026-25906-1-git-send-email-kaixuxia@tencent.com |
---|---|
State | Superseded |
Headers | show |
Series | [v3] bpf: Fix unsigned 'datasec_id' compared with zero in check_pseudo_btf_id | expand |
On Tue, Nov 10, 2020 at 9:03 PM <xiakaixu1987@gmail.com> wrote: > > From: Kaixu Xia <kaixuxia@tencent.com> > > The unsigned variable datasec_id is assigned a return value from the call > to check_pseudo_btf_id(), which may return negative error code. > > Fixes coccicheck warning: > > ./kernel/bpf/verifier.c:9616:5-15: WARNING: Unsigned expression compared with zero: datasec_id > 0 > > Reported-by: Tosk Robot <tencent_os_robot@tencent.com> > Signed-off-by: Kaixu Xia <kaixuxia@tencent.com> > --- Looks good. Acked-by: Andrii Nakryiko <andrii@kernel.org> [...]
Andrii Nakryiko wrote: > On Tue, Nov 10, 2020 at 9:03 PM <xiakaixu1987@gmail.com> wrote: > > > > From: Kaixu Xia <kaixuxia@tencent.com> > > > > The unsigned variable datasec_id is assigned a return value from the call > > to check_pseudo_btf_id(), which may return negative error code. > > > > Fixes coccicheck warning: > > > > ./kernel/bpf/verifier.c:9616:5-15: WARNING: Unsigned expression compared with zero: datasec_id > 0 > > > > Reported-by: Tosk Robot <tencent_os_robot@tencent.com> > > Signed-off-by: Kaixu Xia <kaixuxia@tencent.com> > > --- > > Looks good. > > Acked-by: Andrii Nakryiko <andrii@kernel.org> > > [...] Acked-by: John Fastabend <john.fastabend@gmail.com>
On 11/11/20 6:03 AM, xiakaixu1987@gmail.com wrote: > From: Kaixu Xia <kaixuxia@tencent.com> > > The unsigned variable datasec_id is assigned a return value from the call > to check_pseudo_btf_id(), which may return negative error code. > > Fixes coccicheck warning: > > ./kernel/bpf/verifier.c:9616:5-15: WARNING: Unsigned expression compared with zero: datasec_id > 0 > > Reported-by: Tosk Robot <tencent_os_robot@tencent.com> > Signed-off-by: Kaixu Xia <kaixuxia@tencent.com> Looks good, applied & also added Fixes tags, thanks!
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index 6200519582a6..6204ec705d80 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -9572,12 +9572,13 @@ static int check_pseudo_btf_id(struct bpf_verifier_env *env, struct bpf_insn *insn, struct bpf_insn_aux_data *aux) { - u32 datasec_id, type, id = insn->imm; const struct btf_var_secinfo *vsi; const struct btf_type *datasec; const struct btf_type *t; const char *sym_name; bool percpu = false; + u32 type, id = insn->imm; + s32 datasec_id; u64 addr; int i;