Message ID | 1604644960-48378-3-git-send-email-dong.menglong@zte.com.cn |
---|---|
State | Changes Requested |
Delegated to: | David Miller |
Headers | show |
Series | net: udp: remove redundant initialization in udp_gro_complete | expand |
Context | Check | Description |
---|---|---|
jkicinski/cover_letter | success | Link |
jkicinski/fixes_present | success | Link |
jkicinski/patch_count | success | Link |
jkicinski/tree_selection | success | Guessed tree name to be net-next |
jkicinski/subject_prefix | warning | Target tree name not specified in the subject |
jkicinski/source_inline | success | Was 0 now: 0 |
jkicinski/verify_signedoff | success | Link |
jkicinski/module_param | success | Was 0 now: 0 |
jkicinski/build_32bit | success | Errors and warnings before: 8 this patch: 8 |
jkicinski/kdoc | success | Errors and warnings before: 0 this patch: 0 |
jkicinski/verify_fixes | success | Link |
jkicinski/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
jkicinski/build_allmodconfig_warn | success | Errors and warnings before: 8 this patch: 8 |
jkicinski/header_inline | success | Link |
jkicinski/stable | success | Stable not CCed |
On Fri, 6 Nov 2020 01:42:39 -0500 menglong8.dong@gmail.com wrote: > { > __be16 newlen = htons(skb->len - nhoff); > struct udphdr *uh = (struct udphdr *)(skb->data + nhoff); > - int err = -ENOSYS; > + int err; > struct sock *sk; You can also move the err declaration below struct sock *sk; to get this closer to revert xmas tree order. In other patches it'd increase change / potential conflict radius but here the correct position is close enough so we can move.
diff --git a/net/ipv4/udp_offload.c b/net/ipv4/udp_offload.c index b8b1fde..65860f8 100644 --- a/net/ipv4/udp_offload.c +++ b/net/ipv4/udp_offload.c @@ -554,7 +554,7 @@ int udp_gro_complete(struct sk_buff *skb, int nhoff, { __be16 newlen = htons(skb->len - nhoff); struct udphdr *uh = (struct udphdr *)(skb->data + nhoff); - int err = -ENOSYS; + int err; struct sock *sk; uh->len = newlen;