| Message ID | 20201103084742.56740-1-acelan.kao@canonical.com |
|---|---|
| Headers | show |
| Series | Support Advantech UNO-420 platform | expand |
On Tue, Nov 03, 2020 at 04:47:36PM +0800, AceLan Kao wrote: > BugLink: https://bugs.launchpad.net/bugs/1902672 > > [Impact] > There are some drivers are required to enable Advantech UNO-420 platform. > > [Fix] > Advantech is submitting their drivers to upstream for review, and > considering that the patches are new drivers, it should be safe pull them > back to ubuntu kernel. > https://lkml.org/lkml/2020/10/29/342 > > [Test] > Verified on Advantech UNO-420 platform. > > [Regression Potential] > Low, those commits create 3 new drivers, and doesn't modify any existing > driver code. Should introduce no regression. Generally things going into stable kernels should also be going into the development series kernel as well, otherwise users will see regressions on upgrades. Is there a reason for this to be only relevant to focal? Thanks, Seth
Those drivers are for dedicated hardware(project), there is no normal user who will use those drivers. And for current status, those drivers are submitting to upstream and we hope they eventually could make their way into the mainline kernel. So, I think we don't have to carry those drivers currently. Will check their status and backport them if needed when they are accepted by upstream. Seth Forshee <seth.forshee@canonical.com> 於 2020年11月3日 週二 下午11:48寫道： > > On Tue, Nov 03, 2020 at 04:47:36PM +0800, AceLan Kao wrote: > > BugLink: https://bugs.launchpad.net/bugs/1902672 > > > > [Impact] > > There are some drivers are required to enable Advantech UNO-420 platform. > > > > [Fix] > > Advantech is submitting their drivers to upstream for review, and > > considering that the patches are new drivers, it should be safe pull them > > back to ubuntu kernel. > > https://lkml.org/lkml/2020/10/29/342 > > > > [Test] > > Verified on Advantech UNO-420 platform. > > > > [Regression Potential] > > Low, those commits create 3 new drivers, and doesn't modify any existing > > driver code. Should introduce no regression. > > Generally things going into stable kernels should also be going into the > development series kernel as well, otherwise users will see regressions > on upgrades. Is there a reason for this to be only relevant to focal? > > Thanks, > Seth
On 03.11.20 09:47, AceLan Kao wrote: > BugLink: https://bugs.launchpad.net/bugs/1902672 > > [Impact] > There are some drivers are required to enable Advantech UNO-420 platform. > > [Fix] > Advantech is submitting their drivers to upstream for review, and > considering that the patches are new drivers, it should be safe pull them > back to ubuntu kernel. > https://lkml.org/lkml/2020/10/29/342 Hi AceLan, Upstream raised some serious issues with the licensing of this code: https://lkml.org/lkml/2020/11/2/260 For the same reason we can't include this driver on Ubuntu kernels without at least a proper compatible license. Kleber > > [Test] > Verified on Advantech UNO-420 platform. > > [Regression Potential] > Low, those commits create 3 new drivers, and doesn't modify any existing > driver code. Should introduce no regression. > > Shihlun Lin (6): > UBUNTU: SAUCE: MAINTAINERS: Add Advantech embedded controller entry > UBUNTU: SAUCE: mfd: ahc1ec0: Add Advantech EC include file used by > dt-bindings > UBUNTU: SAUCE: dt-bindings: mfd: ahc1ec0.yaml: Add Advantech Embedded > Controll - AHC1EC0 > UBUNTU: SAUCE: mfd: ahc1ec0: Add support for Advantech embedded > controller > UBUNTU: SAUCE: mfd: ahc1ec0-hwmon: Add sub-device hwmon for Advantech > embedded controller > UBUNTU: SAUCE: mfd: ahc1ec0-wdt: Add sub-device watchdog for Advantech > embedded controller > > .../devicetree/bindings/mfd/ahc1ec0.yaml | 76 + > MAINTAINERS | 11 + > drivers/mfd/Kconfig | 21 + > drivers/mfd/Makefile | 3 + > drivers/mfd/ahc1ec0-hwmon.c | 1514 +++++++++++++++++ > drivers/mfd/ahc1ec0-wdt.c | 502 ++++++ > drivers/mfd/ahc1ec0.c | 1419 +++++++++++++++ > include/dt-bindings/mfd/ahc1ec0.h | 29 + > include/linux/mfd/ahc1ec0.h | 338 ++++ > 9 files changed, 3913 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/ahc1ec0.yaml > create mode 100644 drivers/mfd/ahc1ec0-hwmon.c > create mode 100644 drivers/mfd/ahc1ec0-wdt.c > create mode 100644 drivers/mfd/ahc1ec0.c > create mode 100644 include/dt-bindings/mfd/ahc1ec0.h > create mode 100644 include/linux/mfd/ahc1ec0.h >
BugLink: https://bugs.launchpad.net/bugs/1902672 [Impact] There are some drivers are required to enable Advantech UNO-420 platform. [Fix] Advantech is submitting their drivers to upstream for review, and considering that the patches are new drivers, it should be safe pull them back to ubuntu kernel. https://lkml.org/lkml/2020/10/29/342 [Test] Verified on Advantech UNO-420 platform. [Regression Potential] Low, those commits create 3 new drivers, and doesn't modify any existing driver code. Should introduce no regression. Shihlun Lin (6): UBUNTU: SAUCE: MAINTAINERS: Add Advantech embedded controller entry UBUNTU: SAUCE: mfd: ahc1ec0: Add Advantech EC include file used by dt-bindings UBUNTU: SAUCE: dt-bindings: mfd: ahc1ec0.yaml: Add Advantech Embedded Controll - AHC1EC0 UBUNTU: SAUCE: mfd: ahc1ec0: Add support for Advantech embedded controller UBUNTU: SAUCE: mfd: ahc1ec0-hwmon: Add sub-device hwmon for Advantech embedded controller UBUNTU: SAUCE: mfd: ahc1ec0-wdt: Add sub-device watchdog for Advantech embedded controller .../devicetree/bindings/mfd/ahc1ec0.yaml | 76 + MAINTAINERS | 11 + drivers/mfd/Kconfig | 21 + drivers/mfd/Makefile | 3 + drivers/mfd/ahc1ec0-hwmon.c | 1514 +++++++++++++++++ drivers/mfd/ahc1ec0-wdt.c | 502 ++++++ drivers/mfd/ahc1ec0.c | 1419 +++++++++++++++ include/dt-bindings/mfd/ahc1ec0.h | 29 + include/linux/mfd/ahc1ec0.h | 338 ++++ 9 files changed, 3913 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/ahc1ec0.yaml create mode 100644 drivers/mfd/ahc1ec0-hwmon.c create mode 100644 drivers/mfd/ahc1ec0-wdt.c create mode 100644 drivers/mfd/ahc1ec0.c create mode 100644 include/dt-bindings/mfd/ahc1ec0.h create mode 100644 include/linux/mfd/ahc1ec0.h