| Message ID | 20201009060302.6220-1-mike.looijmans@topic.nl |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v3] dt-bindings: gpio: pca953x: Add support for the NXP PCAL9554B/C | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Fri, 09 Oct 2020 08:03:02 +0200, Mike Looijmans wrote: > The NXP PCAL9554B is a variant of the PCA953x GPIO expander, > with 8 GPIOs, latched interrupts and some advanced configuration > options. The "C" version only differs in I2C address. > > This adds the entry to the devicetree bindings. > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> > --- > v2: Split devicetree and code into separate patches > v3: Devicetree bindings in yaml format > > Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 1 + > 1 file changed, 1 insertion(+) > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed.
On Fri, Oct 9, 2020 at 8:03 AM Mike Looijmans <mike.looijmans@topic.nl> wrote: > > The NXP PCAL9554B is a variant of the PCA953x GPIO expander, > with 8 GPIOs, latched interrupts and some advanced configuration > options. The "C" version only differs in I2C address. > > This adds the entry to the devicetree bindings. > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> > --- > v2: Split devicetree and code into separate patches > v3: Devicetree bindings in yaml format > > Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml > index 183ec23eda39..f5ee23c2df60 100644 > --- a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml > +++ b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml > @@ -48,6 +48,7 @@ properties: > - nxp,pcal6416 > - nxp,pcal6524 > - nxp,pcal9535 > + - nxp,pcal9554b > - nxp,pcal9555a > - onnn,cat9554 > - onnn,pca9654 > -- > 2.17.1 > Hi Mike, please resend this rebased on top of v5.10-rc1 with tags collected if you still want it merged. Bartosz
Hi Mike! thanks for your patch. On Fri, Oct 9, 2020 at 8:03 AM Mike Looijmans <mike.looijmans@topic.nl> wrote: > - nxp,pcal9535 > + - nxp,pcal9554b > - nxp,pcal9555a This triggers my OCD. Putting B before A? Please make it alphabetic. No big deal, but... Yours, Linus Walleij
Met vriendelijke groet / kind regards, Mike Looijmans System Expert TOPIC Embedded Products B.V. Materiaalweg 4, 5681 RJ Best The Netherlands T: +31 (0) 499 33 69 69 E: mike.looijmans@topicproducts.com W: www.topicproducts.com Please consider the environment before printing this e-mail On 05-11-2020 11:25, Linus Walleij wrote: > Hi Mike! > > thanks for your patch. > > On Fri, Oct 9, 2020 at 8:03 AM Mike Looijmans <mike.looijmans@topic.nl> wrote: > >> - nxp,pcal9535 >> + - nxp,pcal9554b >> - nxp,pcal9555a > > This triggers my OCD. Putting B before A? Please make it alphabetic. Nothing wrong with a bit of OCD, it's probably in our job description :) But there's a "4" before the "5" too. > > No big deal, but... > > Yours, > Linus Walleij >
On Thu, Nov 5, 2020 at 11:30 AM Mike Looijmans <mike.looijmans@topic.nl> wrote: > On 05-11-2020 11:25, Linus Walleij wrote: > > On Fri, Oct 9, 2020 at 8:03 AM Mike Looijmans <mike.looijmans@topic.nl> wrote: > > > >> - nxp,pcal9535 > >> + - nxp,pcal9554b > >> - nxp,pcal9555a > > > > This triggers my OCD. Putting B before A? Please make it alphabetic. > > Nothing wrong with a bit of OCD, it's probably in our job description :) > > But there's a "4" before the "5" too. My perception isn't as good as my OCD apparently :D This is already merged anyways, no big deal. Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml index 183ec23eda39..f5ee23c2df60 100644 --- a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml +++ b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml @@ -48,6 +48,7 @@ properties: - nxp,pcal6416 - nxp,pcal6524 - nxp,pcal9535 + - nxp,pcal9554b - nxp,pcal9555a - onnn,cat9554 - onnn,pca9654
The NXP PCAL9554B is a variant of the PCA953x GPIO expander, with 8 GPIOs, latched interrupts and some advanced configuration options. The "C" version only differs in I2C address. This adds the entry to the devicetree bindings. Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> --- v2: Split devicetree and code into separate patches v3: Devicetree bindings in yaml format Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 1 + 1 file changed, 1 insertion(+)