mbox series

[SRU,F,0/1] Fix broken igc device after reboot

Message ID 20201105064056.4908-1-kai.heng.feng@canonical.com
Headers show
Series Fix broken igc device after reboot | expand

Message

Kai-Heng Feng Nov. 5, 2020, 6:40 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1902578

[Impact]
igc device doesn't work after reboot.

[Fix]
Wait for PHY reset complete.

[Test]
With the commit, user confirmed the issue is solved.

[Regression Potential]
This commit doesn't break the control flow, so the only regression is
possible increaed probe time.

Sasha Neftin (1):
  igc: Add PHY power management control

 drivers/net/ethernet/intel/igc/igc_defines.h |  1 +
 drivers/net/ethernet/intel/igc/igc_phy.c     | 16 +++++++++++++++-
 drivers/net/ethernet/intel/igc/igc_regs.h    |  1 +
 3 files changed, 17 insertions(+), 1 deletion(-)

Comments

Andrea Righi Nov. 5, 2020, 7:22 a.m. UTC | #1 
On Thu, Nov 05, 2020 at 02:40:55PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1902578
> 
> [Impact]
> igc device doesn't work after reboot.
> 
> [Fix]
> Wait for PHY reset complete.
> 
> [Test]
> With the commit, user confirmed the issue is solved.
> 
> [Regression Potential]
> This commit doesn't break the control flow, so the only regression is
> possible increaed probe time.

Clean upstream cherry pick, tested with positive result, looks good to
me, thanks!

Acked-by: Andrea Righi <andrea.righi@canonical.com>
William Breathitt Gray Nov. 5, 2020, 1:14 p.m. UTC | #2 
On Thu, Nov 05, 2020 at 02:40:55PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1902578
> 
> [Impact]
> igc device doesn't work after reboot.
> 
> [Fix]
> Wait for PHY reset complete.
> 
> [Test]
> With the commit, user confirmed the issue is solved.
> 
> [Regression Potential]
> This commit doesn't break the control flow, so the only regression is
> possible increaed probe time.
> 
> Sasha Neftin (1):
>   igc: Add PHY power management control
> 
>  drivers/net/ethernet/intel/igc/igc_defines.h |  1 +
>  drivers/net/ethernet/intel/igc/igc_phy.c     | 16 +++++++++++++++-
>  drivers/net/ethernet/intel/igc/igc_regs.h    |  1 +
>  3 files changed, 17 insertions(+), 1 deletion(-)
> 
> -- 
> 2.17.1

Acked-by: William Breathitt Gray <william.gray@canonical.com>