| Message ID | ee2ecb0560b9e7a2a567b69b5de40f39344c8ffe.1604298276.git.pavana.sharma@digi.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | Add support for mv88e6393x family of Marvell | expand |
| Context | Check | Description |
|---|---|---|
| jkicinski/cover_letter | success | Link |
| jkicinski/fixes_present | success | Link |
| jkicinski/patch_count | success | Link |
| jkicinski/tree_selection | success | Guessed tree name to be net-next |
| jkicinski/subject_prefix | success | Link |
| jkicinski/source_inline | success | Was 0 now: 0 |
| jkicinski/verify_signedoff | success | Link |
| jkicinski/module_param | success | Was 0 now: 0 |
| jkicinski/build_32bit | success | Errors and warnings before: 667 this patch: 667 |
| jkicinski/kdoc | success | Errors and warnings before: 1 this patch: 1 |
| jkicinski/verify_fixes | success | Link |
| jkicinski/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 16 lines checked |
| jkicinski/build_allmodconfig_warn | success | Errors and warnings before: 582 this patch: 582 |
| jkicinski/header_inline | success | Link |
| jkicinski/stable | success | Stable not CCed |
On Mon, Nov 02, 2020 at 04:42:06PM +1000, Pavana Sharma wrote: > Add 5GBASE-R phy interface mode > > Signed-off-by: Pavana Sharma <pavana.sharma@digi.com> How many times have i asked for you to add kerneldoc for this new value? How many times have you not done so? NACK. If you don't understand a comment, please ask. Andrew
> How many times have i asked for you to add kerneldoc for this new > value? How many times have you not done so? I have added kerneldoc comment for the new value added. > NACK. > If you don't understand a comment, please ask. Ok, explain what do you expect by that comment.
On 11/2/2020 5:34 PM, Pavana Sharma wrote: >> How many times have i asked for you to add kerneldoc for this new >> value? How many times have you not done so? > > I have added kerneldoc comment for the new value added. > >> NACK. > >> If you don't understand a comment, please ask. > > Ok, explain what do you expect by that comment. What Andrew wants you to do is add a comment like this: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/include/linux/phy.h#n88
On Mon, Nov 02, 2020 at 06:12:32PM -0800, Florian Fainelli wrote: > > > On 11/2/2020 5:34 PM, Pavana Sharma wrote: > >> How many times have i asked for you to add kerneldoc for this new > >> value? How many times have you not done so? > > > > I have added kerneldoc comment for the new value added. > > > >> NACK. > > > >> If you don't understand a comment, please ask. > > > > Ok, explain what do you expect by that comment. > > What Andrew wants you to do is add a comment like this: > > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/include/linux/phy.h#n88 Hi Pavana This should also help: https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html And please compile the kernel with the W=1 flag. Make sure changes you make don't add new warnings. You will see a warning from this new enum valu you are adding because it is not correctly documented. Andrew
diff --git a/include/linux/phy.h b/include/linux/phy.h index 3a09d2bf69ea..977b94a44e15 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -105,6 +105,8 @@ typedef enum { PHY_INTERFACE_MODE_TRGMII, PHY_INTERFACE_MODE_1000BASEX, PHY_INTERFACE_MODE_2500BASEX, + /* 5GBASE-R mode */ + PHY_INTERFACE_MODE_5GBASER, PHY_INTERFACE_MODE_RXAUI, PHY_INTERFACE_MODE_XAUI, /* 10GBASE-R, XFI, SFI - single lane 10G Serdes */ @@ -183,6 +185,8 @@ static inline const char *phy_modes(phy_interface_t interface) return "1000base-x"; case PHY_INTERFACE_MODE_2500BASEX: return "2500base-x"; + case PHY_INTERFACE_MODE_5GBASER: + return "5gbase-r"; case PHY_INTERFACE_MODE_RXAUI: return "rxaui"; case PHY_INTERFACE_MODE_XAUI:
Add 5GBASE-R phy interface mode Signed-off-by: Pavana Sharma <pavana.sharma@digi.com> --- include/linux/phy.h | 4 ++++ 1 file changed, 4 insertions(+)