| Message ID | 1590737775-4798-8-git-send-email-masonccyang@mxic.com.tw |
|---|---|
| State | Changes Requested |
| Delegated to: | Ambarus Tudor |
| Headers | show |
| Series | mtd: spi-nor: add xSPI Octal DTR support | expand |
On 29/05/20 03:36PM, Mason Yang wrote: > Macronix mx25uw51245g is a SPI NOR that supports 1-1-1/8-8-8 mode. > > Correct the dummy cycles to device for various frequencies > after xSPI profile 1.0 table parsed. > > Enable mx25uw51245g to Octal DTR mode by executing the command sequences > to change to octal DTR mode. > > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw> > --- > drivers/mtd/spi-nor/macronix.c | 55 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c > index 96735d8..6c9a24c 100644 > --- a/drivers/mtd/spi-nor/macronix.c > +++ b/drivers/mtd/spi-nor/macronix.c > @@ -8,6 +8,57 @@ > > #include "core.h" > > +#define MXIC_CR2_DUMMY_SET_ADDR 0x300 > + > +/* Fixup the dummy cycles to device and setup octa_dtr_enable() */ > +static void mx25uw51245g_post_sfdp_fixups(struct spi_nor *nor) > +{ > + struct spi_nor_flash_parameter *params = nor->params; > + int ret; > + u8 rdc, wdc; > + > + ret = spi_nor_read_cr2(nor, MXIC_CR2_DUMMY_SET_ADDR, &rdc); > + if (ret) > + return; > + > + /* Refer to dummy cycle and frequency table(MHz) */ > + switch (params->dummy_cycles) { > + case 10: /* 10 dummy cycles for 104 MHz */ > + wdc = 5; > + break; > + case 12: /* 12 dummy cycles for 133 MHz */ > + wdc = 4; > + break; > + case 16: /* 16 dummy cycles for 166 MHz */ > + wdc = 2; > + break; > + case 18: /* 18 dummy cycles for 173 MHz */ > + wdc = 1; > + break; > + case 20: /* 20 dummy cycles for 200 MHz */ > + default: > + wdc = 0; > + } I don't get the point of this. You already know the fastest the mx25uw51245g flash can run at. Why not just use the maximum dummy cycles? SPI NOR doesn't know the speed the controller is running at so the best it can do is use the maximum dummy cycles possible so it never falls short. Sure, it will be _slightly_ less performance, but we will be sure to read the correct data, which is much much more important. Is it possible to have two chips which have _exactly_ the same ID but one supports say 200MHz frequency but the other doesn't? Without that, we can just enable the maximum and move on. > + > + if (rdc != wdc) > + spi_nor_write_cr2(nor, MXIC_CR2_DUMMY_SET_ADDR, &wdc); > + > + if (params->cmd_seq[0].len) { > + params->octal_dtr_enable = spi_nor_cmd_seq_octal_dtr; > + params->hwcaps.mask |= SNOR_HWCAPS_READ_8_8_8_DTR; > + params->hwcaps.mask |= SNOR_HWCAPS_PP_8_8_8_DTR; Same comment as above. We are in the mx25uw51245g fixup hook. We already know if the flash supports 8D mode or not from the datasheet. What is the need to discover it from SFDP? > + > + } else { > + params->octal_dtr_enable = NULL; > + params->hwcaps.mask &= ~SNOR_HWCAPS_READ_8_8_8_DTR; > + params->hwcaps.mask &= ~SNOR_HWCAPS_PP_8_8_8_DTR; > + } > +} > + > +static struct spi_nor_fixups mx25uw51245g_fixups = { > + .post_sfdp = mx25uw51245g_post_sfdp_fixups, > +}; > + > static int > mx25l25635_post_bfpt_fixups(struct spi_nor *nor, > const struct sfdp_parameter_header *bfpt_header, > @@ -84,6 +135,10 @@ > SPI_NOR_QUAD_READ) }, > { "mx66l1g55g", INFO(0xc2261b, 0, 64 * 1024, 2048, > SPI_NOR_QUAD_READ) }, > + { "mx25uw51245g", INFO(0xc2813a, 0, 64 * 1024, 1024, > + SECT_4K | SPI_NOR_4B_OPCODES | > + SPI_NOR_OCTAL_DTR_READ) > + .fixups = &mx25uw51245g_fixups }, > }; > > static void macronix_default_init(struct spi_nor *nor)
Hi Pratyush, > Subject > > Re: [PATCH v4 7/7] mtd: spi-nor: macronix: Add Octal 8D-8D-8D supports for > Macronix mx25uw51245g > > On 29/05/20 03:36PM, Mason Yang wrote: > > Macronix mx25uw51245g is a SPI NOR that supports 1-1-1/8-8-8 mode. > > > > Correct the dummy cycles to device for various frequencies > > after xSPI profile 1.0 table parsed. > > > > Enable mx25uw51245g to Octal DTR mode by executing the command sequences > > to change to octal DTR mode. > > > > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw> > > --- > > drivers/mtd/spi-nor/macronix.c | 55 ++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 55 insertions(+) > > > > diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c > > index 96735d8..6c9a24c 100644 > > --- a/drivers/mtd/spi-nor/macronix.c > > +++ b/drivers/mtd/spi-nor/macronix.c > > @@ -8,6 +8,57 @@ > > > > #include "core.h" > > > > +#define MXIC_CR2_DUMMY_SET_ADDR 0x300 > > + > > +/* Fixup the dummy cycles to device and setup octa_dtr_enable() */ > > +static void mx25uw51245g_post_sfdp_fixups(struct spi_nor *nor) > > +{ > > + struct spi_nor_flash_parameter *params = nor->params; > > + int ret; > > + u8 rdc, wdc; > > + > > + ret = spi_nor_read_cr2(nor, MXIC_CR2_DUMMY_SET_ADDR, &rdc); > > + if (ret) > > + return; > > + > > + /* Refer to dummy cycle and frequency table(MHz) */ > > + switch (params->dummy_cycles) { > > + case 10: /* 10 dummy cycles for 104 MHz */ > > + wdc = 5; > > + break; > > + case 12: /* 12 dummy cycles for 133 MHz */ > > + wdc = 4; > > + break; > > + case 16: /* 16 dummy cycles for 166 MHz */ > > + wdc = 2; > > + break; > > + case 18: /* 18 dummy cycles for 173 MHz */ > > + wdc = 1; > > + break; > > + case 20: /* 20 dummy cycles for 200 MHz */ > > + default: > > + wdc = 0; > > + } > > I don't get the point of this. You already know the fastest the > mx25uw51245g flash can run at. Why not just use the maximum dummy > cycles? SPI NOR doesn't know the speed the controller is running at so > the best it can do is use the maximum dummy cycles possible so it never > falls short. Sure, it will be _slightly_ less performance, but we will > be sure to read the correct data, which is much much more important. In general, 200MHz needs 20 dummy cycles but some powerful device may only needs 18 dummy cycles or less. Set a proper dummy cycles for a better performance. > > Is it possible to have two chips which have _exactly_ the same ID but > one supports say 200MHz frequency but the other doesn't? Without that, > we can just enable the maximum and move on. > thanks for your time & comments. Mason CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. =====================================================================
On 02/06/20 02:44PM, masonccyang@mxic.com.tw wrote: > > Hi Pratyush, > > > > Subject > > > > Re: [PATCH v4 7/7] mtd: spi-nor: macronix: Add Octal 8D-8D-8D supports > for > > Macronix mx25uw51245g > > > > On 29/05/20 03:36PM, Mason Yang wrote: > > > Macronix mx25uw51245g is a SPI NOR that supports 1-1-1/8-8-8 mode. > > > > > > Correct the dummy cycles to device for various frequencies > > > after xSPI profile 1.0 table parsed. > > > > > > Enable mx25uw51245g to Octal DTR mode by executing the command > sequences > > > to change to octal DTR mode. > > > > > > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw> > > > --- > > > drivers/mtd/spi-nor/macronix.c | 55 > ++++++++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 55 insertions(+) > > > > > > diff --git a/drivers/mtd/spi-nor/macronix.c > b/drivers/mtd/spi-nor/macronix.c > > > index 96735d8..6c9a24c 100644 > > > --- a/drivers/mtd/spi-nor/macronix.c > > > +++ b/drivers/mtd/spi-nor/macronix.c > > > @@ -8,6 +8,57 @@ > > > > > > #include "core.h" > > > > > > +#define MXIC_CR2_DUMMY_SET_ADDR 0x300 > > > + > > > +/* Fixup the dummy cycles to device and setup octa_dtr_enable() */ > > > +static void mx25uw51245g_post_sfdp_fixups(struct spi_nor *nor) > > > +{ > > > + struct spi_nor_flash_parameter *params = nor->params; > > > + int ret; > > > + u8 rdc, wdc; > > > + > > > + ret = spi_nor_read_cr2(nor, MXIC_CR2_DUMMY_SET_ADDR, &rdc); > > > + if (ret) > > > + return; > > > + > > > + /* Refer to dummy cycle and frequency table(MHz) */ > > > + switch (params->dummy_cycles) { > > > + case 10: /* 10 dummy cycles for 104 MHz */ > > > + wdc = 5; > > > + break; > > > + case 12: /* 12 dummy cycles for 133 MHz */ > > > + wdc = 4; > > > + break; > > > + case 16: /* 16 dummy cycles for 166 MHz */ > > > + wdc = 2; > > > + break; > > > + case 18: /* 18 dummy cycles for 173 MHz */ > > > + wdc = 1; > > > + break; > > > + case 20: /* 20 dummy cycles for 200 MHz */ > > > + default: > > > + wdc = 0; > > > + } > > > > I don't get the point of this. You already know the fastest the > > mx25uw51245g flash can run at. Why not just use the maximum dummy > > cycles? SPI NOR doesn't know the speed the controller is running at so > > the best it can do is use the maximum dummy cycles possible so it never > > falls short. Sure, it will be _slightly_ less performance, but we will > > be sure to read the correct data, which is much much more important. > > In general, 200MHz needs 20 dummy cycles but some powerful device may only > > needs 18 dummy cycles or less. Yes, but do different mx25uw51245g chips have different dummy cycle requirements? Shouldn't all the chips with the same ID have same performance? This is a fixup hook for mx25uw51245g, so you should already know how many cycles are needed for this specific device. Is there any need for generic code here? > Set a proper dummy cycles for a better performance. > > > > > Is it possible to have two chips which have _exactly_ the same ID but > > one supports say 200MHz frequency but the other doesn't? Without that, > > we can just enable the maximum and move on. > > >
> > > > > > > > +#define MXIC_CR2_DUMMY_SET_ADDR 0x300 > > > > + > > > > +/* Fixup the dummy cycles to device and setup octa_dtr_enable() */ > > > > +static void mx25uw51245g_post_sfdp_fixups(struct spi_nor *nor) > > > > +{ > > > > + struct spi_nor_flash_parameter *params = nor->params; > > > > + int ret; > > > > + u8 rdc, wdc; > > > > + > > > > + ret = spi_nor_read_cr2(nor, MXIC_CR2_DUMMY_SET_ADDR, &rdc); > > > > + if (ret) > > > > + return; > > > > + > > > > + /* Refer to dummy cycle and frequency table(MHz) */ > > > > + switch (params->dummy_cycles) { > > > > + case 10: /* 10 dummy cycles for 104 MHz */ > > > > + wdc = 5; > > > > + break; > > > > + case 12: /* 12 dummy cycles for 133 MHz */ > > > > + wdc = 4; > > > > + break; > > > > + case 16: /* 16 dummy cycles for 166 MHz */ > > > > + wdc = 2; > > > > + break; > > > > + case 18: /* 18 dummy cycles for 173 MHz */ > > > > + wdc = 1; > > > > + break; > > > > + case 20: /* 20 dummy cycles for 200 MHz */ > > > > + default: > > > > + wdc = 0; > > > > + } > > > > > > I don't get the point of this. You already know the fastest the > > > mx25uw51245g flash can run at. Why not just use the maximum dummy > > > cycles? SPI NOR doesn't know the speed the controller is running at so > > > the best it can do is use the maximum dummy cycles possible so it never > > > falls short. Sure, it will be _slightly_ less performance, but we will > > > be sure to read the correct data, which is much much more important. > > > > In general, 200MHz needs 20 dummy cycles but some powerful device may only > > > > needs 18 dummy cycles or less. > > Yes, but do different mx25uw51245g chips have different dummy cycle > requirements? Shouldn't all the chips with the same ID have same > performance? > Same chip ID but different grade, i.e., commercial or industrial grade. thanks & best regards, Mason CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. =====================================================================
On 05/06/20 10:53AM, masonccyang@mxic.com.tw wrote: > > > > > > > > > > > +#define MXIC_CR2_DUMMY_SET_ADDR 0x300 > > > > > + > > > > > +/* Fixup the dummy cycles to device and setup octa_dtr_enable() > */ > > > > > +static void mx25uw51245g_post_sfdp_fixups(struct spi_nor *nor) > > > > > +{ > > > > > + struct spi_nor_flash_parameter *params = nor->params; > > > > > + int ret; > > > > > + u8 rdc, wdc; > > > > > + > > > > > + ret = spi_nor_read_cr2(nor, MXIC_CR2_DUMMY_SET_ADDR, &rdc); > > > > > + if (ret) > > > > > + return; > > > > > + > > > > > + /* Refer to dummy cycle and frequency table(MHz) */ > > > > > + switch (params->dummy_cycles) { > > > > > + case 10: /* 10 dummy cycles for 104 MHz */ > > > > > + wdc = 5; > > > > > + break; > > > > > + case 12: /* 12 dummy cycles for 133 MHz */ > > > > > + wdc = 4; > > > > > + break; > > > > > + case 16: /* 16 dummy cycles for 166 MHz */ > > > > > + wdc = 2; > > > > > + break; > > > > > + case 18: /* 18 dummy cycles for 173 MHz */ > > > > > + wdc = 1; > > > > > + break; > > > > > + case 20: /* 20 dummy cycles for 200 MHz */ > > > > > + default: > > > > > + wdc = 0; > > > > > + } > > > > > > > > I don't get the point of this. You already know the fastest the > > > > mx25uw51245g flash can run at. Why not just use the maximum dummy > > > > cycles? SPI NOR doesn't know the speed the controller is running at > so > > > > the best it can do is use the maximum dummy cycles possible so it > never > > > > falls short. Sure, it will be _slightly_ less performance, but we > will > > > > be sure to read the correct data, which is much much more important. > > > > > > In general, 200MHz needs 20 dummy cycles but some powerful device may > only > > > > > > needs 18 dummy cycles or less. > > > > Yes, but do different mx25uw51245g chips have different dummy cycle > > requirements? Shouldn't all the chips with the same ID have same > > performance? > > > > Same chip ID but different grade, > i.e., commercial or industrial grade. Ok. In that case it makes sense.
+ YC Lin in loop, -- > > Subject > > [PATCH v4 7/7] mtd: spi-nor: macronix: Add Octal 8D-8D-8D supports for > Macronix mx25uw51245g > > Macronix mx25uw51245g is a SPI NOR that supports 1-1-1/8-8-8 mode. > > Correct the dummy cycles to device for various frequencies > after xSPI profile 1.0 table parsed. > > Enable mx25uw51245g to Octal DTR mode by executing the command sequences > to change to octal DTR mode. > > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw> > --- CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. =====================================================================
Hi, Mason, YC Lin, On 5/29/20 10:36 AM, Mason Yang wrote: > Macronix mx25uw51245g is a SPI NOR that supports 1-1-1/8-8-8 mode. > > Correct the dummy cycles to device for various frequencies > after xSPI profile 1.0 table parsed. > > Enable mx25uw51245g to Octal DTR mode by executing the command sequences > to change to octal DTR mode. > > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw> > --- > drivers/mtd/spi-nor/macronix.c | 55 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c > index 96735d8..6c9a24c 100644 > --- a/drivers/mtd/spi-nor/macronix.c > +++ b/drivers/mtd/spi-nor/macronix.c > @@ -8,6 +8,57 @@ > > #include "core.h" > > +#define MXIC_CR2_DUMMY_SET_ADDR 0x300 > + > +/* Fixup the dummy cycles to device and setup octa_dtr_enable() */ > +static void mx25uw51245g_post_sfdp_fixups(struct spi_nor *nor) > +{ > + struct spi_nor_flash_parameter *params = nor->params; > + int ret; > + u8 rdc, wdc; > + > + ret = spi_nor_read_cr2(nor, MXIC_CR2_DUMMY_SET_ADDR, &rdc); nor->bouncebuf is DMA-able, use it instead of rdc > + if (ret) > + return; > + > + /* Refer to dummy cycle and frequency table(MHz) */ > + switch (params->dummy_cycles) { > + case 10: /* 10 dummy cycles for 104 MHz */ > + wdc = 5; > + break; > + case 12: /* 12 dummy cycles for 133 MHz */ > + wdc = 4; > + break; > + case 16: /* 16 dummy cycles for 166 MHz */ > + wdc = 2; > + break; > + case 18: /* 18 dummy cycles for 173 MHz */ > + wdc = 1; > + break; > + case 20: /* 20 dummy cycles for 200 MHz */ > + default: > + wdc = 0; > + } > + > + if (rdc != wdc) > + spi_nor_write_cr2(nor, MXIC_CR2_DUMMY_SET_ADDR, &wdc); > + > + if (params->cmd_seq[0].len) { > + params->octal_dtr_enable = spi_nor_cmd_seq_octal_dtr; > + params->hwcaps.mask |= SNOR_HWCAPS_READ_8_8_8_DTR; > + params->hwcaps.mask |= SNOR_HWCAPS_PP_8_8_8_DTR; > + > + } else { > + params->octal_dtr_enable = NULL; > + params->hwcaps.mask &= ~SNOR_HWCAPS_READ_8_8_8_DTR; > + params->hwcaps.mask &= ~SNOR_HWCAPS_PP_8_8_8_DTR; > + } > +} > + > +static struct spi_nor_fixups mx25uw51245g_fixups = { > + .post_sfdp = mx25uw51245g_post_sfdp_fixups, > +}; > + > static int > mx25l25635_post_bfpt_fixups(struct spi_nor *nor, > const struct sfdp_parameter_header *bfpt_header, > @@ -84,6 +135,10 @@ > SPI_NOR_QUAD_READ) }, > { "mx66l1g55g", INFO(0xc2261b, 0, 64 * 1024, 2048, > SPI_NOR_QUAD_READ) }, > + { "mx25uw51245g", INFO(0xc2813a, 0, 64 * 1024, 1024, > + SECT_4K | SPI_NOR_4B_OPCODES | > + SPI_NOR_OCTAL_DTR_READ) octal dtr page program is supported? > + .fixups = &mx25uw51245g_fixups }, > }; > > static void macronix_default_init(struct spi_nor *nor) > Cheers, ta
diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c index 96735d8..6c9a24c 100644 --- a/drivers/mtd/spi-nor/macronix.c +++ b/drivers/mtd/spi-nor/macronix.c @@ -8,6 +8,57 @@ #include "core.h" +#define MXIC_CR2_DUMMY_SET_ADDR 0x300 + +/* Fixup the dummy cycles to device and setup octa_dtr_enable() */ +static void mx25uw51245g_post_sfdp_fixups(struct spi_nor *nor) +{ + struct spi_nor_flash_parameter *params = nor->params; + int ret; + u8 rdc, wdc; + + ret = spi_nor_read_cr2(nor, MXIC_CR2_DUMMY_SET_ADDR, &rdc); + if (ret) + return; + + /* Refer to dummy cycle and frequency table(MHz) */ + switch (params->dummy_cycles) { + case 10: /* 10 dummy cycles for 104 MHz */ + wdc = 5; + break; + case 12: /* 12 dummy cycles for 133 MHz */ + wdc = 4; + break; + case 16: /* 16 dummy cycles for 166 MHz */ + wdc = 2; + break; + case 18: /* 18 dummy cycles for 173 MHz */ + wdc = 1; + break; + case 20: /* 20 dummy cycles for 200 MHz */ + default: + wdc = 0; + } + + if (rdc != wdc) + spi_nor_write_cr2(nor, MXIC_CR2_DUMMY_SET_ADDR, &wdc); + + if (params->cmd_seq[0].len) { + params->octal_dtr_enable = spi_nor_cmd_seq_octal_dtr; + params->hwcaps.mask |= SNOR_HWCAPS_READ_8_8_8_DTR; + params->hwcaps.mask |= SNOR_HWCAPS_PP_8_8_8_DTR; + + } else { + params->octal_dtr_enable = NULL; + params->hwcaps.mask &= ~SNOR_HWCAPS_READ_8_8_8_DTR; + params->hwcaps.mask &= ~SNOR_HWCAPS_PP_8_8_8_DTR; + } +} + +static struct spi_nor_fixups mx25uw51245g_fixups = { + .post_sfdp = mx25uw51245g_post_sfdp_fixups, +}; + static int mx25l25635_post_bfpt_fixups(struct spi_nor *nor, const struct sfdp_parameter_header *bfpt_header, @@ -84,6 +135,10 @@ SPI_NOR_QUAD_READ) }, { "mx66l1g55g", INFO(0xc2261b, 0, 64 * 1024, 2048, SPI_NOR_QUAD_READ) }, + { "mx25uw51245g", INFO(0xc2813a, 0, 64 * 1024, 1024, + SECT_4K | SPI_NOR_4B_OPCODES | + SPI_NOR_OCTAL_DTR_READ) + .fixups = &mx25uw51245g_fixups }, }; static void macronix_default_init(struct spi_nor *nor)
Macronix mx25uw51245g is a SPI NOR that supports 1-1-1/8-8-8 mode. Correct the dummy cycles to device for various frequencies after xSPI profile 1.0 table parsed. Enable mx25uw51245g to Octal DTR mode by executing the command sequences to change to octal DTR mode. Signed-off-by: Mason Yang <masonccyang@mxic.com.tw> --- drivers/mtd/spi-nor/macronix.c | 55 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+)