Message ID | 20201026104221.26570-1-msuchanek@suse.de |
---|---|
State | Accepted |
Delegated to: | David Miller |
Headers | show |
Series | ibmveth: Fix use of ibmveth in a bridge. | expand |
Context | Check | Description |
---|---|---|
jkicinski/cover_letter | success | Link |
jkicinski/fixes_present | success | Link |
jkicinski/patch_count | success | Link |
jkicinski/tree_selection | success | Guessed tree name to be net-next |
jkicinski/subject_prefix | warning | Target tree name not specified in the subject |
jkicinski/source_inline | success | Was 0 now: 0 |
jkicinski/verify_signedoff | fail | Link |
jkicinski/module_param | success | Was 0 now: 0 |
jkicinski/build_32bit | fail | Errors and warnings before: 4 this patch: 4 |
jkicinski/kdoc | success | Errors and warnings before: 0 this patch: 0 |
jkicinski/verify_fixes | success | Link |
jkicinski/checkpatch | fail | Link |
jkicinski/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
jkicinski/header_inline | success | Link |
jkicinski/stable | success | Stable not CCed |
On Mon, 26 Oct 2020 11:42:21 +0100 Michal Suchanek wrote: > From: Thomas Bogendoerfer <tbogendoerfer@suse.de> > > The check for src mac address in ibmveth_is_packet_unsupported is wrong. > Commit 6f2275433a2f wanted to shut down messages for loopback packets, > but now suppresses bridged frames, which are accepted by the hypervisor > otherwise bridging won't work at all. > > Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sending to the hypervisor") > Signed-off-by: Michal Suchanek <msuchanek@suse.de> Since the From: line says Thomas we need a signoff from him.
On Mon, 26 Oct 2020 11:52:37 -0700 Jakub Kicinski <kuba@kernel.org> wrote: > On Mon, 26 Oct 2020 11:42:21 +0100 Michal Suchanek wrote: > > From: Thomas Bogendoerfer <tbogendoerfer@suse.de> > > > > The check for src mac address in ibmveth_is_packet_unsupported is wrong. > > Commit 6f2275433a2f wanted to shut down messages for loopback packets, > > but now suppresses bridged frames, which are accepted by the hypervisor > > otherwise bridging won't work at all. > > > > Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sending to the hypervisor") > > Signed-off-by: Michal Suchanek <msuchanek@suse.de> > > Since the From: line says Thomas we need a signoff from him. you can add Signed-off-by: tbogendoerfer@suse.de Thomas.
On Mon, 26 Oct 2020 20:04:07 +0100 Thomas Bogendoerfer wrote: > > On Mon, 26 Oct 2020 11:42:21 +0100 Michal Suchanek wrote: > > > From: Thomas Bogendoerfer <tbogendoerfer@suse.de> > > > > > > The check for src mac address in ibmveth_is_packet_unsupported is wrong. > > > Commit 6f2275433a2f wanted to shut down messages for loopback packets, > > > but now suppresses bridged frames, which are accepted by the hypervisor > > > otherwise bridging won't work at all. > > > > > > Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sending to the hypervisor") > > > Signed-off-by: Michal Suchanek <msuchanek@suse.de> > > > > Since the From: line says Thomas we need a signoff from him. > > you can add > > Signed-off-by: tbogendoerfer@suse.de Applied, thanks.
diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c index 7ef3369953b6..c3ec9ceed833 100644 --- a/drivers/net/ethernet/ibm/ibmveth.c +++ b/drivers/net/ethernet/ibm/ibmveth.c @@ -1031,12 +1031,6 @@ static int ibmveth_is_packet_unsupported(struct sk_buff *skb, ret = -EOPNOTSUPP; } - if (!ether_addr_equal(ether_header->h_source, netdev->dev_addr)) { - netdev_dbg(netdev, "source packet MAC address does not match veth device's, dropping packet.\n"); - netdev->stats.tx_dropped++; - ret = -EOPNOTSUPP; - } - return ret; }