Message ID | 1603521686-13036-1-git-send-email-jiaxin.yu@mediatek.com |
---|---|
Headers | show |
Series | ASoC: mt6359: skip first time data at the beginning of DMIC recording | expand |
On Sat, Oct 24, 2020 at 02:41:25PM +0800, Jiaxin Yu wrote: > We can choose to drop away any length of data from the beginning according > to project needs. Some projects don't want to throw away any data, because > they want to use recorded data to do echo cancellation, so they have to > make sure that they are aligned with the reference data as much as > possible. Or there are other algorithms in the upper layer to eliminate > this noise. Or some projects want to eliminate this noise form the kernel > layer. However, the minimum recommended value is 50ms to skip pop noise. This seems like something that would apply equally to all DMICs so should be done at a more general level rather than in this specific driver, for example it could be done in the DMIC driver.
On Mon, 2020-10-26 at 12:33 +0000, Mark Brown wrote: > On Sat, Oct 24, 2020 at 02:41:25PM +0800, Jiaxin Yu wrote: > > We can choose to drop away any length of data from the beginning according > > to project needs. Some projects don't want to throw away any data, because > > they want to use recorded data to do echo cancellation, so they have to > > make sure that they are aligned with the reference data as much as > > possible. Or there are other algorithms in the upper layer to eliminate > > this noise. Or some projects want to eliminate this noise form the kernel > > layer. However, the minimum recommended value is 50ms to skip pop noise. > > This seems like something that would apply equally to all DMICs so > should be done at a more general level rather than in this specific > driver, for example it could be done in the DMIC driver. Hi Brown, So you suggest that we use sound/soc/codecs/dmic.c to control the delay after recording? If so, should we add one more CODEC('dmic-codec' and 'dmic-hifi') to dmic's dai-link? It looks link dmic.c has helped us do something to control dmics.
On Tue, Oct 27, 2020 at 06:28:58PM +0800, Jiaxin Yu wrote: > On Mon, 2020-10-26 at 12:33 +0000, Mark Brown wrote: > > This seems like something that would apply equally to all DMICs so > > should be done at a more general level rather than in this specific > > driver, for example it could be done in the DMIC driver. > So you suggest that we use sound/soc/codecs/dmic.c to control the delay > after recording? > If so, should we add one more CODEC('dmic-codec' and 'dmic-hifi') to > dmic's dai-link? It looks link dmic.c has helped us do something to > control dmics. Yes, exactly.