| Message ID | 20201015163818.1503152-1-fparent@baylibre.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | mmc: mtk-sd: change some dev_err into dev_dbg | expand |
> Subject: [PATCH] mmc: mtk-sd: change some dev_err into dev_dbg > > dev_err has been used for debugging and a few dev_err message are printed > for normal code execution. Make them dev_dbg instead. > > Signed-off-by: Fabien Parent <fparent@baylibre.com> > --- > drivers/mmc/mtk-sd.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/mtk-sd.c b/drivers/mmc/mtk-sd.c index > bd1fb09d1c9b..40b0deb6b756 100644 > --- a/drivers/mmc/mtk-sd.c > +++ b/drivers/mmc/mtk-sd.c > @@ -1169,7 +1169,7 @@ skip_fall: > internal_delay |= (1 << i); > } > > - dev_err(dev, "Final internal delay: 0x%x\n", internal_delay); > + dev_dbg(dev, "Final internal delay: 0x%x\n", internal_delay); > > internal_delay_phase = get_best_delay(host, internal_delay); > clrsetbits_le32(tune_reg, MSDC_PAD_TUNE_CMDRRDLY_M, @@ > -1177,7 +1177,7 @@ skip_fall: > MSDC_PAD_TUNE_CMDRRDLY_S); > > skip_internal: > - dev_err(dev, "Final cmd pad delay: %x\n", final_delay); > + dev_dbg(dev, "Final cmd pad delay: %x\n", final_delay); > return final_delay == 0xff ? -EIO : 0; } > > @@ -1263,7 +1263,7 @@ skip_fall: > host->hs200_write_int_delay << > MSDC_PAD_TUNE_DATWRDLY_S); > > - dev_err(dev, "Final data pad delay: %x\n", final_delay); > + dev_dbg(dev, "Final data pad delay: %x\n", final_delay); > > return final_delay == 0xff ? -EIO : 0; } > -- Reviewed-by: Peng Fan <peng.fan@nxp.com>
On Thu, Oct 15, 2020 at 06:38:18PM +0200, Fabien Parent wrote: > dev_err has been used for debugging and a few dev_err message are > printed for normal code execution. Make them dev_dbg instead. > > Signed-off-by: Fabien Parent <fparent@baylibre.com> > Reviewed-by: Peng Fan <peng.fan@nxp.com> Applied to u-boot/master, thanks!
diff --git a/drivers/mmc/mtk-sd.c b/drivers/mmc/mtk-sd.c index bd1fb09d1c9b..40b0deb6b756 100644 --- a/drivers/mmc/mtk-sd.c +++ b/drivers/mmc/mtk-sd.c @@ -1169,7 +1169,7 @@ skip_fall: internal_delay |= (1 << i); } - dev_err(dev, "Final internal delay: 0x%x\n", internal_delay); + dev_dbg(dev, "Final internal delay: 0x%x\n", internal_delay); internal_delay_phase = get_best_delay(host, internal_delay); clrsetbits_le32(tune_reg, MSDC_PAD_TUNE_CMDRRDLY_M, @@ -1177,7 +1177,7 @@ skip_fall: MSDC_PAD_TUNE_CMDRRDLY_S); skip_internal: - dev_err(dev, "Final cmd pad delay: %x\n", final_delay); + dev_dbg(dev, "Final cmd pad delay: %x\n", final_delay); return final_delay == 0xff ? -EIO : 0; } @@ -1263,7 +1263,7 @@ skip_fall: host->hs200_write_int_delay << MSDC_PAD_TUNE_DATWRDLY_S); - dev_err(dev, "Final data pad delay: %x\n", final_delay); + dev_dbg(dev, "Final data pad delay: %x\n", final_delay); return final_delay == 0xff ? -EIO : 0; }
dev_err has been used for debugging and a few dev_err message are printed for normal code execution. Make them dev_dbg instead. Signed-off-by: Fabien Parent <fparent@baylibre.com> --- drivers/mmc/mtk-sd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)