diff mbox series

configs: mt8512: enable device mode of mtu3 explicitly

Message ID 1602678229-19372-1-git-send-email-chunfeng.yun@mediatek.com
State Superseded
Delegated to: Marek Vasut
Headers show
Series configs: mt8512: enable device mode of mtu3 explicitly | expand

Commit Message

Chunfeng Yun (云春峰) Oct. 14, 2020, 12:23 p.m. UTC
Set CONFIG_USB_MTU3_GADGET=y to enable it explicitly,
try to avoid build error:
"undefined reference to `dm_usb_gadget_handle_interrupts'"

fixes: 311412ead0 ("configs: mt8512: enable fastboot and USB host related configs")

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
 configs/mt8512_bm1_emmc_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Bin Meng Oct. 14, 2020, 12:33 p.m. UTC | #1
On Wed, Oct 14, 2020 at 8:24 PM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:
>
> Set CONFIG_USB_MTU3_GADGET=y to enable it explicitly,
> try to avoid build error:
> "undefined reference to `dm_usb_gadget_handle_interrupts'"
>
> fixes: 311412ead0 ("configs: mt8512: enable fastboot and USB host related configs")

This should be "Fixes:" followed by 12 digit commit id

I can't find 311412ead0 in my tree

>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
>  configs/mt8512_bm1_emmc_defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/configs/mt8512_bm1_emmc_defconfig b/configs/mt8512_bm1_emmc_defconfig
> index aaf59f52a8..c25a42cd3d 100644
> --- a/configs/mt8512_bm1_emmc_defconfig
> +++ b/configs/mt8512_bm1_emmc_defconfig
> @@ -53,6 +53,7 @@ CONFIG_DM_USB=y
>  CONFIG_DM_USB_GADGET=y
>  CONFIG_USB_XHCI_HCD=y
>  CONFIG_USB_MTU3=y
> +CONFIG_USB_MTU3_GADGET=y
>  # CONFIG_USB_MTU3_HOST is not set
>  CONFIG_USB_STORAGE=y
>  CONFIG_USB_GADGET=y

Regards,
Bin
Chunfeng Yun (云春峰) Oct. 14, 2020, 12:51 p.m. UTC | #2
On Wed, 2020-10-14 at 20:33 +0800, Bin Meng wrote:
> On Wed, Oct 14, 2020 at 8:24 PM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:
> >
> > Set CONFIG_USB_MTU3_GADGET=y to enable it explicitly,
> > try to avoid build error:
> > "undefined reference to `dm_usb_gadget_handle_interrupts'"
> >
> > fixes: 311412ead0 ("configs: mt8512: enable fastboot and USB host related configs")
> 
> This should be "Fixes:" followed by 12 digit commit id
Ok
> 
> I can't find 311412ead0 in my tree
Sorry, I used my local change id, will use one got from u-boot-usb/next
branch
> 
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> >  configs/mt8512_bm1_emmc_defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/configs/mt8512_bm1_emmc_defconfig b/configs/mt8512_bm1_emmc_defconfig
> > index aaf59f52a8..c25a42cd3d 100644
> > --- a/configs/mt8512_bm1_emmc_defconfig
> > +++ b/configs/mt8512_bm1_emmc_defconfig
> > @@ -53,6 +53,7 @@ CONFIG_DM_USB=y
> >  CONFIG_DM_USB_GADGET=y
> >  CONFIG_USB_XHCI_HCD=y
> >  CONFIG_USB_MTU3=y
> > +CONFIG_USB_MTU3_GADGET=y
> >  # CONFIG_USB_MTU3_HOST is not set
> >  CONFIG_USB_STORAGE=y
> >  CONFIG_USB_GADGET=y
> 
> Regards,
> Bin
diff mbox series

Patch

diff --git a/configs/mt8512_bm1_emmc_defconfig b/configs/mt8512_bm1_emmc_defconfig
index aaf59f52a8..c25a42cd3d 100644
--- a/configs/mt8512_bm1_emmc_defconfig
+++ b/configs/mt8512_bm1_emmc_defconfig
@@ -53,6 +53,7 @@  CONFIG_DM_USB=y
 CONFIG_DM_USB_GADGET=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_MTU3=y
+CONFIG_USB_MTU3_GADGET=y
 # CONFIG_USB_MTU3_HOST is not set
 CONFIG_USB_STORAGE=y
 CONFIG_USB_GADGET=y