Message ID | 1600420213-25974-5-git-send-email-chunfeng.yun@mediatek.com |
---|---|
State | Superseded |
Delegated to: | Marek Vasut |
Headers | show |
Series | Add support MediaTek USB3 DRD driver | expand |
On Fri, Sep 18, 2020 at 5:12 PM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote: > > There is only declaration of usb_speed_string(), but no definition, > so add it to avoid build error when call it. > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > v7: no changes > > v6: modify commit message suggested by Roger > > v5: no changes > > v4: new patch > --- > drivers/usb/common/common.c | 7 +++++++ > include/linux/usb/ch9.h | 4 ---- > 2 files changed, 7 insertions(+), 4 deletions(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
diff --git a/drivers/usb/common/common.c b/drivers/usb/common/common.c index 76f5a9c..5e5c3c3 100644 --- a/drivers/usb/common/common.c +++ b/drivers/usb/common/common.c @@ -49,6 +49,13 @@ static const char *const speed_names[] = { [USB_SPEED_SUPER_PLUS] = "super-speed-plus", }; +const char *usb_speed_string(enum usb_device_speed speed) +{ + if (speed < 0 || speed >= ARRAY_SIZE(speed_names)) + speed = USB_SPEED_UNKNOWN; + return speed_names[speed]; +} + enum usb_device_speed usb_get_maximum_speed(ofnode node) { const char *max_speed; diff --git a/include/linux/usb/ch9.h b/include/linux/usb/ch9.h index 7d225ee..a8fa5d7 100644 --- a/include/linux/usb/ch9.h +++ b/include/linux/usb/ch9.h @@ -959,8 +959,6 @@ enum usb_device_speed { USB_SPEED_SUPER_PLUS, /* usb 3.1 */ }; -#ifdef __KERNEL__ - /** * usb_speed_string() - Returns human readable-name of the speed. * @speed: The speed to return human-readable name for. If it's not @@ -969,8 +967,6 @@ enum usb_device_speed { */ extern const char *usb_speed_string(enum usb_device_speed speed); -#endif - enum usb_device_state { /* NOTATTACHED isn't in the USB spec, and this state acts * the same as ATTACHED ... but it's clearer this way.
There is only declaration of usb_speed_string(), but no definition, so add it to avoid build error when call it. Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- v7: no changes v6: modify commit message suggested by Roger v5: no changes v4: new patch --- drivers/usb/common/common.c | 7 +++++++ include/linux/usb/ch9.h | 4 ---- 2 files changed, 7 insertions(+), 4 deletions(-)