| Message ID | 20201007203936.23953-2-ioana.ciornei@nxp.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | arm64: dts: layerscape: update MAC nodes with PHY information | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success |
On Wed, 07 Oct 2020 23:39:26 +0300, Ioana Ciornei wrote: > Add a documentation entry for the DTS bindings needed and supported by > the dpaa2-mac driver. > > Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com> > --- > Changes in v2: > - new patch > Changes in v3: > - renamed dpmac@x into ethernet@x > - renamed the new documentation file to use the same name as the > compatible > - marked additionalProperties as false > - added a reference to ethernet-controller.yaml > > .../bindings/net/fsl,qoriq-mc-dpmac.yaml | 60 +++++++++++++++++++ > 1 file changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml > Reviewed-by: Rob Herring <robh@kernel.org>
On Tue, Oct 13, 2020 at 08:31:32AM -0500, Rob Herring wrote: > On Wed, 07 Oct 2020 23:39:26 +0300, Ioana Ciornei wrote: > > Add a documentation entry for the DTS bindings needed and supported by > > the dpaa2-mac driver. > > > > Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com> > > --- > > Changes in v2: > > - new patch > > Changes in v3: > > - renamed dpmac@x into ethernet@x > > - renamed the new documentation file to use the same name as the > > compatible > > - marked additionalProperties as false > > - added a reference to ethernet-controller.yaml > > > > .../bindings/net/fsl,qoriq-mc-dpmac.yaml | 60 +++++++++++++++++++ > > 1 file changed, 60 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml > > > > Reviewed-by: Rob Herring <robh@kernel.org> Thanks for the review. Is this going in 5.10 by any chance or should I resend these after the merge window with the reviewed-by tags? Ioana
On Tue, Oct 13, 2020 at 9:19 AM Ioana Ciornei <ioana.ciornei@nxp.com> wrote: > > On Tue, Oct 13, 2020 at 08:31:32AM -0500, Rob Herring wrote: > > On Wed, 07 Oct 2020 23:39:26 +0300, Ioana Ciornei wrote: > > > Add a documentation entry for the DTS bindings needed and supported by > > > the dpaa2-mac driver. > > > > > > Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com> > > > --- > > > Changes in v2: > > > - new patch > > > Changes in v3: > > > - renamed dpmac@x into ethernet@x > > > - renamed the new documentation file to use the same name as the > > > compatible > > > - marked additionalProperties as false > > > - added a reference to ethernet-controller.yaml > > > > > > .../bindings/net/fsl,qoriq-mc-dpmac.yaml | 60 +++++++++++++++++++ > > > 1 file changed, 60 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml > > > > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > Thanks for the review. > > Is this going in 5.10 by any chance or should I resend these after > the merge window with the reviewed-by tags? I just noticed you didn't Cc netdev as I would expect this to go via the networking tree. So yes, resend after the merge window. Rob
On Tue, Oct 13, 2020 at 12:21:53PM -0500, Rob Herring wrote: > On Tue, Oct 13, 2020 at 9:19 AM Ioana Ciornei <ioana.ciornei@nxp.com> wrote: > > > > On Tue, Oct 13, 2020 at 08:31:32AM -0500, Rob Herring wrote: > > > On Wed, 07 Oct 2020 23:39:26 +0300, Ioana Ciornei wrote: > > > > Add a documentation entry for the DTS bindings needed and supported by > > > > the dpaa2-mac driver. > > > > > > > > Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com> > > > > --- > > > > Changes in v2: > > > > - new patch > > > > Changes in v3: > > > > - renamed dpmac@x into ethernet@x > > > > - renamed the new documentation file to use the same name as the > > > > compatible > > > > - marked additionalProperties as false > > > > - added a reference to ethernet-controller.yaml > > > > > > > > .../bindings/net/fsl,qoriq-mc-dpmac.yaml | 60 +++++++++++++++++++ > > > > 1 file changed, 60 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml > > > > > > > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > > > Thanks for the review. > > > > Is this going in 5.10 by any chance or should I resend these after > > the merge window with the reviewed-by tags? > > I just noticed you didn't Cc netdev as I would expect this to go via > the networking tree. So yes, resend after the merge window. > David said to an earlier version of this patch set that he would not want to pick this up through net-next since it's a sizable change and this should go through the devicetree trees. https://lore.kernel.org/netdev/20201002.161318.726844448692603677.davem@davemloft.net/ This is why I didn't cc again the netdev. Ioana
diff --git a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml new file mode 100644 index 000000000000..2159b7d1f537 --- /dev/null +++ b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml @@ -0,0 +1,60 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/fsl,qoriq-mc-dpmac.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: DPAA2 MAC bindings + +maintainers: + - Ioana Ciornei <ioana.ciornei@nxp.com> + +description: + This binding represents the DPAA2 MAC objects found on the fsl-mc bus and + located under the 'dpmacs' node for the fsl-mc bus DTS node. + +allOf: + - $ref: "ethernet-controller.yaml#" + +properties: + compatible: + const: fsl,qoriq-mc-dpmac + + reg: + maxItems: 1 + description: The DPMAC number + + phy-handle: true + + phy-connection-type: true + + phy-mode: true + + pcs-handle: + $ref: /schemas/types.yaml#definitions/phandle + description: + A reference to a node representing a PCS PHY device found on + the internal MDIO bus. + + managed: true + +required: + - reg + +additionalProperties: false + +examples: + - | + dpmacs { + #address-cells = <1>; + #size-cells = <0>; + + ethernet@4 { + compatible = "fsl,qoriq-mc-dpmac"; + reg = <0x4>; + phy-handle = <&mdio1_phy6>; + phy-connection-type = "qsgmii"; + managed = "in-band-status"; + pcs-handle = <&pcs3_1>; + }; + };
Add a documentation entry for the DTS bindings needed and supported by the dpaa2-mac driver. Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com> --- Changes in v2: - new patch Changes in v3: - renamed dpmac@x into ethernet@x - renamed the new documentation file to use the same name as the compatible - marked additionalProperties as false - added a reference to ethernet-controller.yaml .../bindings/net/fsl,qoriq-mc-dpmac.yaml | 60 +++++++++++++++++++ 1 file changed, 60 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml