| Message ID | 20201008003746.25659-5-nicoleotsuka@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | memory: tegra: Fix client list and add swgroups | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Wed, Oct 07, 2020 at 05:37:45PM -0700, Nicolin Chen wrote: > According to Tegra X1 TRM, there are missing swgroups in the > tegra210_swgroups list. So this patch adds them in bindings. > > Note that the TEGRA_SWGROUP_GPU (in list) should be actually > TEGRA_SWGROUP_GPUB (in TRM), yet TEGRA_SWGROUP_GPU (in TRM) > is not being used -- only TEGRA_SWGROUP_GPUB (in TRM) is. So > this patch does not add TEGRA_SWGROUP_GPU (in TRM) and keeps > TEGRA_SWGROUP_GPU (in list) as it is. > > Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com> > --- > include/dt-bindings/memory/tegra210-mc.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/dt-bindings/memory/tegra210-mc.h b/include/dt-bindings/memory/tegra210-mc.h > index c226cba9e077..f9fcb18a6d9b 100644 > --- a/include/dt-bindings/memory/tegra210-mc.h > +++ b/include/dt-bindings/memory/tegra210-mc.h > @@ -33,6 +33,16 @@ > #define TEGRA_SWGROUP_AXIAP 28 > #define TEGRA_SWGROUP_ETR 29 > #define TEGRA_SWGROUP_TSECB 30 > +#define TEGRA_SWGROUP_NV 31 > +#define TEGRA_SWGROUP_NV2 32 > +#define TEGRA_SWGROUP_PPCS1 33 > +#define TEGRA_SWGROUP_DC1 34 > +#define TEGRA_SWGROUP_PPCS2 35 > +#define TEGRA_SWGROUP_HC1 36 > +#define TEGRA_SWGROUP_SE1 37 > +#define TEGRA_SWGROUP_TSEC1 38 > +#define TEGRA_SWGROUP_TSECB1 39 > +#define TEGRA_SWGROUP_NVDEC1 40 I'm not sure this is right. The existing list is based on "Table 4: Client to Software Name Mapping" from page 28 of the Tegra X1 TRM, and none of these new swgroups seem to be present in that table. Where exactly did you get those from? Thierry
On Fri, Oct 09, 2020 at 02:21:10PM +0200, Thierry Reding wrote: > On Wed, Oct 07, 2020 at 05:37:45PM -0700, Nicolin Chen wrote: > > According to Tegra X1 TRM, there are missing swgroups in the > > tegra210_swgroups list. So this patch adds them in bindings. > > > > Note that the TEGRA_SWGROUP_GPU (in list) should be actually > > TEGRA_SWGROUP_GPUB (in TRM), yet TEGRA_SWGROUP_GPU (in TRM) > > is not being used -- only TEGRA_SWGROUP_GPUB (in TRM) is. So > > this patch does not add TEGRA_SWGROUP_GPU (in TRM) and keeps > > TEGRA_SWGROUP_GPU (in list) as it is. > > > > Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com> > > --- > > include/dt-bindings/memory/tegra210-mc.h | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/include/dt-bindings/memory/tegra210-mc.h b/include/dt-bindings/memory/tegra210-mc.h > > index c226cba9e077..f9fcb18a6d9b 100644 > > --- a/include/dt-bindings/memory/tegra210-mc.h > > +++ b/include/dt-bindings/memory/tegra210-mc.h > > @@ -33,6 +33,16 @@ > > #define TEGRA_SWGROUP_AXIAP 28 > > #define TEGRA_SWGROUP_ETR 29 > > #define TEGRA_SWGROUP_TSECB 30 > > +#define TEGRA_SWGROUP_NV 31 > > +#define TEGRA_SWGROUP_NV2 32 > > +#define TEGRA_SWGROUP_PPCS1 33 > > +#define TEGRA_SWGROUP_DC1 34 > > +#define TEGRA_SWGROUP_PPCS2 35 > > +#define TEGRA_SWGROUP_HC1 36 > > +#define TEGRA_SWGROUP_SE1 37 > > +#define TEGRA_SWGROUP_TSEC1 38 > > +#define TEGRA_SWGROUP_TSECB1 39 > > +#define TEGRA_SWGROUP_NVDEC1 40 > > I'm not sure this is right. The existing list is based on "Table 4: > Client to Software Name Mapping" from page 28 of the Tegra X1 TRM, and > none of these new swgroups seem to be present in that table. I went through all the MC_SMMU_XX_ASID_0 registers. All of them have their own ASID registers that I added in PATCH-5.
On Fri, Oct 09, 2020 at 08:52:18AM -0700, Nicolin Chen wrote: > On Fri, Oct 09, 2020 at 02:21:10PM +0200, Thierry Reding wrote: > > On Wed, Oct 07, 2020 at 05:37:45PM -0700, Nicolin Chen wrote: > > > According to Tegra X1 TRM, there are missing swgroups in the > > > tegra210_swgroups list. So this patch adds them in bindings. > > > > > > Note that the TEGRA_SWGROUP_GPU (in list) should be actually > > > TEGRA_SWGROUP_GPUB (in TRM), yet TEGRA_SWGROUP_GPU (in TRM) > > > is not being used -- only TEGRA_SWGROUP_GPUB (in TRM) is. So > > > this patch does not add TEGRA_SWGROUP_GPU (in TRM) and keeps > > > TEGRA_SWGROUP_GPU (in list) as it is. > > > > > > Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com> > > > --- > > > include/dt-bindings/memory/tegra210-mc.h | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > > > > > diff --git a/include/dt-bindings/memory/tegra210-mc.h b/include/dt-bindings/memory/tegra210-mc.h > > > index c226cba9e077..f9fcb18a6d9b 100644 > > > --- a/include/dt-bindings/memory/tegra210-mc.h > > > +++ b/include/dt-bindings/memory/tegra210-mc.h > > > @@ -33,6 +33,16 @@ > > > #define TEGRA_SWGROUP_AXIAP 28 > > > #define TEGRA_SWGROUP_ETR 29 > > > #define TEGRA_SWGROUP_TSECB 30 > > > +#define TEGRA_SWGROUP_NV 31 > > > +#define TEGRA_SWGROUP_NV2 32 > > > +#define TEGRA_SWGROUP_PPCS1 33 > > > +#define TEGRA_SWGROUP_DC1 34 > > > +#define TEGRA_SWGROUP_PPCS2 35 > > > +#define TEGRA_SWGROUP_HC1 36 > > > +#define TEGRA_SWGROUP_SE1 37 > > > +#define TEGRA_SWGROUP_TSEC1 38 > > > +#define TEGRA_SWGROUP_TSECB1 39 > > > +#define TEGRA_SWGROUP_NVDEC1 40 > > > > I'm not sure this is right. The existing list is based on "Table 4: > > Client to Software Name Mapping" from page 28 of the Tegra X1 TRM, and > > none of these new swgroups seem to be present in that table. > > I went through all the MC_SMMU_XX_ASID_0 registers. All of > them have their own ASID registers that I added in PATCH-5. Thierry, Any follow ups on this topic? Does it require a fix or looks correct? Best regards, Krzysztof
On Mon, Oct 26, 2020 at 09:17:58PM +0100, Krzysztof Kozlowski wrote: > On Fri, Oct 09, 2020 at 08:52:18AM -0700, Nicolin Chen wrote: > > On Fri, Oct 09, 2020 at 02:21:10PM +0200, Thierry Reding wrote: > > > On Wed, Oct 07, 2020 at 05:37:45PM -0700, Nicolin Chen wrote: > > > > According to Tegra X1 TRM, there are missing swgroups in the > > > > tegra210_swgroups list. So this patch adds them in bindings. > > > > > > > > Note that the TEGRA_SWGROUP_GPU (in list) should be actually > > > > TEGRA_SWGROUP_GPUB (in TRM), yet TEGRA_SWGROUP_GPU (in TRM) > > > > is not being used -- only TEGRA_SWGROUP_GPUB (in TRM) is. So > > > > this patch does not add TEGRA_SWGROUP_GPU (in TRM) and keeps > > > > TEGRA_SWGROUP_GPU (in list) as it is. > > > > > > > > Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com> > > > > --- > > > > include/dt-bindings/memory/tegra210-mc.h | 10 ++++++++++ > > > > 1 file changed, 10 insertions(+) > > > > > > > > diff --git a/include/dt-bindings/memory/tegra210-mc.h b/include/dt-bindings/memory/tegra210-mc.h > > > > index c226cba9e077..f9fcb18a6d9b 100644 > > > > --- a/include/dt-bindings/memory/tegra210-mc.h > > > > +++ b/include/dt-bindings/memory/tegra210-mc.h > > > > @@ -33,6 +33,16 @@ > > > > #define TEGRA_SWGROUP_AXIAP 28 > > > > #define TEGRA_SWGROUP_ETR 29 > > > > #define TEGRA_SWGROUP_TSECB 30 > > > > +#define TEGRA_SWGROUP_NV 31 > > > > +#define TEGRA_SWGROUP_NV2 32 > > > > +#define TEGRA_SWGROUP_PPCS1 33 > > > > +#define TEGRA_SWGROUP_DC1 34 > > > > +#define TEGRA_SWGROUP_PPCS2 35 > > > > +#define TEGRA_SWGROUP_HC1 36 > > > > +#define TEGRA_SWGROUP_SE1 37 > > > > +#define TEGRA_SWGROUP_TSEC1 38 > > > > +#define TEGRA_SWGROUP_TSECB1 39 > > > > +#define TEGRA_SWGROUP_NVDEC1 40 > > > > > > I'm not sure this is right. The existing list is based on "Table 4: > > > Client to Software Name Mapping" from page 28 of the Tegra X1 TRM, and > > > none of these new swgroups seem to be present in that table. > > > > I went through all the MC_SMMU_XX_ASID_0 registers. All of > > them have their own ASID registers that I added in PATCH-5. > > Thierry, > > Any follow ups on this topic? Does it require a fix or looks correct? This does indeed look correct, based on what registers exist for these. It'd be good to know how Nicolin expects these to be used, since these are currently not listed in device tree. There's certainly some like TSEC or NVDEC that we don't support (yet) upstream, but things like DC1 and HC1 already have equivalents that we use, so I'm not sure how we'll integrate these new ones. I suppose it doesn't really matter if any of these end up being unused, so: Acked-by: Thierry Reding <treding@nvidia.com>
On Wed, Oct 07, 2020 at 05:37:45PM -0700, Nicolin Chen wrote: > According to Tegra X1 TRM, there are missing swgroups in the > tegra210_swgroups list. So this patch adds them in bindings. > > Note that the TEGRA_SWGROUP_GPU (in list) should be actually > TEGRA_SWGROUP_GPUB (in TRM), yet TEGRA_SWGROUP_GPU (in TRM) > is not being used -- only TEGRA_SWGROUP_GPUB (in TRM) is. So > this patch does not add TEGRA_SWGROUP_GPU (in TRM) and keeps > TEGRA_SWGROUP_GPU (in list) as it is. > > Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com> > --- > include/dt-bindings/memory/tegra210-mc.h | 10 ++++++++++ Thanks, applied. Best regards, Krzysztof
On Tue, Oct 27, 2020 at 01:55:06PM +0100, Thierry Reding wrote: > This does indeed look correct, based on what registers exist for these. > It'd be good to know how Nicolin expects these to be used, since these > are currently not listed in device tree. There's certainly some like Judging from our downstream code, I don't actually expect all of them will be used, except some being used yet not got upstream. > TSEC or NVDEC that we don't support (yet) upstream, but things like DC1 > and HC1 already have equivalents that we use, so I'm not sure how we'll > integrate these new ones. Downstream code groups those equivalents swgroups, so I think we can do similarly using tegra_smmu_group_soc like the existing one for display, if any of them gets upstream someday.
diff --git a/include/dt-bindings/memory/tegra210-mc.h b/include/dt-bindings/memory/tegra210-mc.h index c226cba9e077..f9fcb18a6d9b 100644 --- a/include/dt-bindings/memory/tegra210-mc.h +++ b/include/dt-bindings/memory/tegra210-mc.h @@ -33,6 +33,16 @@ #define TEGRA_SWGROUP_AXIAP 28 #define TEGRA_SWGROUP_ETR 29 #define TEGRA_SWGROUP_TSECB 30 +#define TEGRA_SWGROUP_NV 31 +#define TEGRA_SWGROUP_NV2 32 +#define TEGRA_SWGROUP_PPCS1 33 +#define TEGRA_SWGROUP_DC1 34 +#define TEGRA_SWGROUP_PPCS2 35 +#define TEGRA_SWGROUP_HC1 36 +#define TEGRA_SWGROUP_SE1 37 +#define TEGRA_SWGROUP_TSEC1 38 +#define TEGRA_SWGROUP_TSECB1 39 +#define TEGRA_SWGROUP_NVDEC1 40 #define TEGRA210_MC_RESET_AFI 0 #define TEGRA210_MC_RESET_AVPC 1
According to Tegra X1 TRM, there are missing swgroups in the tegra210_swgroups list. So this patch adds them in bindings. Note that the TEGRA_SWGROUP_GPU (in list) should be actually TEGRA_SWGROUP_GPUB (in TRM), yet TEGRA_SWGROUP_GPU (in TRM) is not being used -- only TEGRA_SWGROUP_GPUB (in TRM) is. So this patch does not add TEGRA_SWGROUP_GPU (in TRM) and keeps TEGRA_SWGROUP_GPU (in list) as it is. Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com> --- include/dt-bindings/memory/tegra210-mc.h | 10 ++++++++++ 1 file changed, 10 insertions(+)