diff mbox series

[2/2] test: unit tests for print_freq(), print_size()

Message ID 20201008202324.51012-3-xypron.glpk@gmx.de
State Changes Requested
Delegated to: Tom Rini
Headers show
Series lib: print_freq() should output kHz not KHz | expand

Commit Message

Heinrich Schuchardt Oct. 8, 2020, 8:23 p.m. UTC 
Provide unit tests for functions print_freq() and print_size().

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 test/lib/Makefile | 1 +
 1 file changed, 1 insertion(+)

--
2.28.0

Comments

Sean Anderson Oct. 9, 2020, 1:23 a.m. UTC | #1 
On 10/8/20 4:23 PM, Heinrich Schuchardt wrote:
> Provide unit tests for functions print_freq() and print_size().
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  test/lib/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/test/lib/Makefile b/test/lib/Makefile
> index 22236f8587..15cd512506 100644
> --- a/test/lib/Makefile
> +++ b/test/lib/Makefile
> @@ -7,6 +7,7 @@ obj-$(CONFIG_EFI_LOADER) += efi_device_path.o
>  obj-$(CONFIG_EFI_SECURE_BOOT) += efi_image_region.o
>  obj-y += hexdump.o
>  obj-y += lmb.o
> +obj-y += test_print.o

Should test/lib/test_print.c be included in this patch?

--Sean

>  obj-$(CONFIG_SSCANF) += sscanf.o
>  obj-y += string.o
>  obj-$(CONFIG_ERRNO_STR) += test_errno_str.o
> --
> 2.28.0
>
Tom Rini Oct. 22, 2020, 1:56 p.m. UTC | #2 
On Thu, Oct 08, 2020 at 10:23:24PM +0200, Heinrich Schuchardt wrote:
> Provide unit tests for functions print_freq() and print_size().

> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  test/lib/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> --
> 2.28.0
> 
> diff --git a/test/lib/Makefile b/test/lib/Makefile
> index 22236f8587..15cd512506 100644
> --- a/test/lib/Makefile
> +++ b/test/lib/Makefile
> @@ -7,6 +7,7 @@ obj-$(CONFIG_EFI_LOADER) += efi_device_path.o
>  obj-$(CONFIG_EFI_SECURE_BOOT) += efi_image_region.o
>  obj-y += hexdump.o
>  obj-y += lmb.o
> +obj-y += test_print.o
>  obj-$(CONFIG_SSCANF) += sscanf.o
>  obj-y += string.o
>  obj-$(CONFIG_ERRNO_STR) += test_errno_str.o

New test file missing.
diff mbox series

Patch

diff --git a/test/lib/Makefile b/test/lib/Makefile
index 22236f8587..15cd512506 100644
--- a/test/lib/Makefile
+++ b/test/lib/Makefile
@@ -7,6 +7,7 @@  obj-$(CONFIG_EFI_LOADER) += efi_device_path.o
 obj-$(CONFIG_EFI_SECURE_BOOT) += efi_image_region.o
 obj-y += hexdump.o
 obj-y += lmb.o
+obj-y += test_print.o
 obj-$(CONFIG_SSCANF) += sscanf.o
 obj-y += string.o
 obj-$(CONFIG_ERRNO_STR) += test_errno_str.o