mbox series

[net-next,v3,0/4] dpaa2-eth: add devlink parser error drop trap support

Message ID 20201001151148.18720-1-ioana.ciornei@nxp.com
Headers show
Series dpaa2-eth: add devlink parser error drop trap support | expand

Message

Ioana Ciornei Oct. 1, 2020, 3:11 p.m. UTC
This patch set adds support in the dpaa2-eth driver for a new group of
devlink drop traps - PARSER_ERROR_DROPS.

The first patch adds a new generic trap group and associated traps,
their definitions in devlink and their corresponding entries in the
Documentation.

Because there might be more devices (besides DPAA2) which do not support
changing the action independently on each trap, a nre devlink callback
is introduced - .trap_group_action_set(). If this callback is populated,
it will take precedence over .trap_action_set() when the user requests
changing the action on all the traps in a group.

The next patches add basic linkage with devlink for the dpaa2-eth driver
and support for the newly added PARSER_ERROR_DROPS. Nothing special
here, just setting up the Rx error queue, interpreting the parse result,
and then reporting any frame received on that queue to devlink.

Changes in v2:
 - fix build error in 3/4

Changes in v3:
 - removed a commented line in 4/4
 - added an extack in 4/4
 - fixed up a warning on 32bit in 4/4
 - reworded the trap_group_action_set() description in 2/4

Ioana Ciornei (4):
  devlink: add parser error drop packet traps
  devlink: add .trap_group_action_set() callback
  dpaa2-eth: add basic devlink support
  dpaa2-eth: add support for devlink parser error drop traps

 .../networking/devlink/devlink-trap.rst       |  70 ++++
 drivers/net/ethernet/freescale/dpaa2/Makefile |   2 +-
 .../freescale/dpaa2/dpaa2-eth-devlink.c       | 309 ++++++++++++++++++
 .../net/ethernet/freescale/dpaa2/dpaa2-eth.c  | 114 +++++++
 .../net/ethernet/freescale/dpaa2/dpaa2-eth.h  |  81 ++++-
 include/net/devlink.h                         |  62 ++++
 net/core/devlink.c                            |  35 ++
 7 files changed, 671 insertions(+), 2 deletions(-)
 create mode 100644 drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.c

Comments

David Miller Oct. 2, 2020, 11:32 p.m. UTC | #1
From: Ioana Ciornei <ioana.ciornei@nxp.com>
Date: Thu,  1 Oct 2020 18:11:44 +0300

> This patch set adds support in the dpaa2-eth driver for a new group of
> devlink drop traps - PARSER_ERROR_DROPS.
> 
> The first patch adds a new generic trap group and associated traps,
> their definitions in devlink and their corresponding entries in the
> Documentation.
> 
> Because there might be more devices (besides DPAA2) which do not support
> changing the action independently on each trap, a nre devlink callback
> is introduced - .trap_group_action_set(). If this callback is populated,
> it will take precedence over .trap_action_set() when the user requests
> changing the action on all the traps in a group.
> 
> The next patches add basic linkage with devlink for the dpaa2-eth driver
> and support for the newly added PARSER_ERROR_DROPS. Nothing special
> here, just setting up the Rx error queue, interpreting the parse result,
> and then reporting any frame received on that queue to devlink.
 ...

Series applied, thanks.