Message ID | 20200914090018.162698-1-xypron.glpk@gmx.de |
---|---|
State | Accepted |
Commit | ad8959138fbca64d7999c79a8a73dff77f2deb98 |
Delegated to: | Tom Rini |
Headers | show |
Series | [1/1] net: use log_err() for 'No ethernet found' message | expand |
On Mon, 14 Sep 2020 at 03:00, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > Write the 'No ethernet found' message via the log drivers. This allows > suppressing it during output via the syslog driver. > > This fixes the problem reported in: > > [PATCH 0/4] log: Fix the syslog spam when running tests > https://lists.denx.de/pipermail/u-boot/2020-September/426343.html > > Reported-by: Simon Glass <sjg@chromium.org> > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > net/eth-uclass.c | 6 +++--- > net/eth_legacy.c | 4 ++-- > 2 files changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On Mon, Sep 14, 2020 at 11:00:18AM +0200, Heinrich Schuchardt wrote: > Write the 'No ethernet found' message via the log drivers. This allows > suppressing it during output via the syslog driver. > > This fixes the problem reported in: > > [PATCH 0/4] log: Fix the syslog spam when running tests > https://lists.denx.de/pipermail/u-boot/2020-September/426343.html > > Reported-by: Simon Glass <sjg@chromium.org> > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot/next, thanks!
diff --git a/net/eth-uclass.c b/net/eth-uclass.c index 0d9b75a9a2..396418eb39 100644 --- a/net/eth-uclass.c +++ b/net/eth-uclass.c @@ -273,7 +273,7 @@ int eth_init(void) if (!current) { current = eth_get_dev(); if (!current) { - printf("No ethernet found.\n"); + log_err("No ethernet found.\n"); return -ENODEV; } } @@ -414,7 +414,7 @@ int eth_initialize(void) */ uclass_first_device_check(UCLASS_ETH, &dev); if (!dev) { - printf("No ethernet found.\n"); + log_err("No ethernet found.\n"); bootstage_error(BOOTSTAGE_ID_NET_ETH_START); } else { char *ethprime = env_get("ethprime"); @@ -449,7 +449,7 @@ int eth_initialize(void) } while (dev); if (!num_devices) - printf("No ethernet found.\n"); + log_err("No ethernet found.\n"); putc('\n'); } diff --git a/net/eth_legacy.c b/net/eth_legacy.c index 992d1880bf..6e0c058761 100644 --- a/net/eth_legacy.c +++ b/net/eth_legacy.c @@ -261,7 +261,7 @@ int eth_initialize(void) } if (!eth_devices) { - puts("No ethernet found.\n"); + log_err("No ethernet found.\n"); bootstage_error(BOOTSTAGE_ID_NET_ETH_START); } else { struct eth_device *dev = eth_devices; @@ -319,7 +319,7 @@ int eth_init(void) struct eth_device *old_current; if (!eth_current) { - puts("No ethernet found.\n"); + log_err("No ethernet found.\n"); return -ENODEV; }
Write the 'No ethernet found' message via the log drivers. This allows suppressing it during output via the syslog driver. This fixes the problem reported in: [PATCH 0/4] log: Fix the syslog spam when running tests https://lists.denx.de/pipermail/u-boot/2020-September/426343.html Reported-by: Simon Glass <sjg@chromium.org> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- net/eth-uclass.c | 6 +++--- net/eth_legacy.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) -- 2.28.0