mbox series

[net-next,0/2] tcp: exponential backoff in tcp_send_ack()

Message ID 20200930125457.1579469-1-eric.dumazet@gmail.com
Headers show
Series tcp: exponential backoff in tcp_send_ack() | expand

Message

Eric Dumazet Sept. 30, 2020, 12:54 p.m. UTC 
From: Eric Dumazet <edumazet@google.com>

We had outages caused by repeated skb allocation failures in tcp_send_ack()

It is time to add exponential backoff to reduce number of attempts.
Before doing so, first patch removes icsk_ack.blocked to make
room for a new field (icsk_ack.retry)

Eric Dumazet (2):
  inet: remove icsk_ack.blocked
  tcp: add exponential backoff in __tcp_send_ack()

 include/net/inet_connection_sock.h |  5 +++--
 net/dccp/timer.c                   |  1 -
 net/ipv4/inet_connection_sock.c    |  2 +-
 net/ipv4/tcp.c                     |  6 ++----
 net/ipv4/tcp_output.c              | 18 ++++++++++--------
 net/ipv4/tcp_timer.c               |  1 -
 6 files changed, 16 insertions(+), 17 deletions(-)

Comments

David Miller Sept. 30, 2020, 9:21 p.m. UTC | #1 
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 30 Sep 2020 05:54:55 -0700

> We had outages caused by repeated skb allocation failures in tcp_send_ack()
> 
> It is time to add exponential backoff to reduce number of attempts.
> Before doing so, first patch removes icsk_ack.blocked to make
> room for a new field (icsk_ack.retry)

Series applied, thanks Eric.