| Message ID | 20200927211042.41875-1-rikard.falkeborn@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | atm: atmtcp: Constify atmtcp_v_dev_ops | expand |
From: Rikard Falkeborn <rikard.falkeborn@gmail.com> Date: Sun, 27 Sep 2020 23:10:42 +0200 > The only usage of atmtcp_v_dev_ops is to pass its address to > atm_dev_register() which takes a pointer to const, and comparing its > address to another address, which does not modify it. Make it const to > allow the compiler to put it in read-only memory. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> Applied to net-next
diff --git a/drivers/atm/atmtcp.c b/drivers/atm/atmtcp.c index 7f814da3c2d0..96bea1ab1ecc 100644 --- a/drivers/atm/atmtcp.c +++ b/drivers/atm/atmtcp.c @@ -327,7 +327,7 @@ static int atmtcp_c_send(struct atm_vcc *vcc,struct sk_buff *skb) */ -static struct atmdev_ops atmtcp_v_dev_ops = { +static const struct atmdev_ops atmtcp_v_dev_ops = { .dev_close = atmtcp_v_dev_close, .open = atmtcp_v_open, .close = atmtcp_v_close,
The only usage of atmtcp_v_dev_ops is to pass its address to atm_dev_register() which takes a pointer to const, and comparing its address to another address, which does not modify it. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> --- drivers/atm/atmtcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)