| Message ID | 20200928144403.19484-1-dmurphy@ti.com |
|---|---|
| State | Not Applicable |
| Delegated to: | Michal Kubecek |
| Headers | show |
| Series | [ethtool,v3,1/3] Add missing 400000base modes for dump_link_caps | expand |
On Mon, Sep 28, 2020 at 09:44:01AM -0500, Dan Murphy wrote: > Commit 63130d0b00040 ("update link mode tables") missed adding in the > 400000base link_caps to the array. > > Signed-off-by: Dan Murphy <dmurphy@ti.com> > --- I'm sorry, I only found these patches shortly after I pushed similar update as I needed updated UAPI headers for new format descriptions. Michal > ethtool.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/ethtool.c b/ethtool.c > index 4f93c0f96985..974b14063de2 100644 > --- a/ethtool.c > +++ b/ethtool.c > @@ -659,6 +659,16 @@ static void dump_link_caps(const char *prefix, const char *an_prefix, > "200000baseDR4/Full" }, > { 0, ETHTOOL_LINK_MODE_200000baseCR4_Full_BIT, > "200000baseCR4/Full" }, > + { 0, ETHTOOL_LINK_MODE_400000baseKR4_Full_BIT, > + "400000baseKR4/Full" }, > + { 0, ETHTOOL_LINK_MODE_400000baseSR4_Full_BIT, > + "400000baseSR4/Full" }, > + { 0, ETHTOOL_LINK_MODE_400000baseLR4_ER4_FR4_Full_BIT, > + "400000baseLR4_ER4_FR4/Full" }, > + { 0, ETHTOOL_LINK_MODE_400000baseDR4_Full_BIT, > + "400000baseDR4/Full" }, > + { 0, ETHTOOL_LINK_MODE_400000baseCR4_Full_BIT, > + "400000baseCR4/Full" }, > }; > int indent; > int did1, new_line_pend; > -- > 2.28.0.585.ge1cfff676549 >
Michal On 9/28/20 11:37 AM, Michal Kubecek wrote: > On Mon, Sep 28, 2020 at 09:44:01AM -0500, Dan Murphy wrote: >> Commit 63130d0b00040 ("update link mode tables") missed adding in the >> 400000base link_caps to the array. >> >> Signed-off-by: Dan Murphy <dmurphy@ti.com> >> --- > I'm sorry, I only found these patches shortly after I pushed similar > update as I needed updated UAPI headers for new format descriptions. Is there an action I need to take here?
On Mon, Sep 28, 2020 at 11:43:59AM -0500, Dan Murphy wrote: > Michal > > On 9/28/20 11:37 AM, Michal Kubecek wrote: > > On Mon, Sep 28, 2020 at 09:44:01AM -0500, Dan Murphy wrote: > > > Commit 63130d0b00040 ("update link mode tables") missed adding in the > > > 400000base link_caps to the array. > > > > > > Signed-off-by: Dan Murphy <dmurphy@ti.com> > > > --- > > I'm sorry, I only found these patches shortly after I pushed similar > > update as I needed updated UAPI headers for new format descriptions. > > Is there an action I need to take here? I don't think so, I believe I have everything that was in your patches (with minor diffrences) but you may want to check. Michal
diff --git a/ethtool.c b/ethtool.c index 4f93c0f96985..974b14063de2 100644 --- a/ethtool.c +++ b/ethtool.c @@ -659,6 +659,16 @@ static void dump_link_caps(const char *prefix, const char *an_prefix, "200000baseDR4/Full" }, { 0, ETHTOOL_LINK_MODE_200000baseCR4_Full_BIT, "200000baseCR4/Full" }, + { 0, ETHTOOL_LINK_MODE_400000baseKR4_Full_BIT, + "400000baseKR4/Full" }, + { 0, ETHTOOL_LINK_MODE_400000baseSR4_Full_BIT, + "400000baseSR4/Full" }, + { 0, ETHTOOL_LINK_MODE_400000baseLR4_ER4_FR4_Full_BIT, + "400000baseLR4_ER4_FR4/Full" }, + { 0, ETHTOOL_LINK_MODE_400000baseDR4_Full_BIT, + "400000baseDR4/Full" }, + { 0, ETHTOOL_LINK_MODE_400000baseCR4_Full_BIT, + "400000baseCR4/Full" }, }; int indent; int did1, new_line_pend;
Commit 63130d0b00040 ("update link mode tables") missed adding in the 400000base link_caps to the array. Signed-off-by: Dan Murphy <dmurphy@ti.com> --- ethtool.c | 10 ++++++++++ 1 file changed, 10 insertions(+)