| Message ID | 20200825193536.7332-7-krzk@kernel.org |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | dt-bindings / arm64: Cleanup of i.MX 8 bindings | expand |
On Tue, Aug 25, 2020 at 09:35:23PM +0200, Krzysztof Kozlowski wrote: > DTSes with new i.MX 8M SoCs introduce their own compatibles so add them > to fix dtbs_check warnings like: > > arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000: > compatible:0: 'fsl,imx8mm-pwm' is not one of ['fsl,imx1-pwm', 'fsl,imx27-pwm'] > From schema: Documentation/devicetree/bindings/pwm/imx-pwm.yaml > > arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000: > compatible: ['fsl,imx8mm-pwm', 'fsl,imx27-pwm'] is too long > > arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000: > compatible: Additional items are not allowed ('fsl,imx27-pwm' was unexpected) > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) Applied, thanks. Thierry
On Wed, 23 Sep 2020 at 13:52, Thierry Reding <thierry.reding@gmail.com> wrote: > > On Tue, Aug 25, 2020 at 09:35:23PM +0200, Krzysztof Kozlowski wrote: > > DTSes with new i.MX 8M SoCs introduce their own compatibles so add them > > to fix dtbs_check warnings like: > > > > arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000: > > compatible:0: 'fsl,imx8mm-pwm' is not one of ['fsl,imx1-pwm', 'fsl,imx27-pwm'] > > From schema: Documentation/devicetree/bindings/pwm/imx-pwm.yaml > > > > arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000: > > compatible: ['fsl,imx8mm-pwm', 'fsl,imx27-pwm'] is too long > > > > arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000: > > compatible: Additional items are not allowed ('fsl,imx27-pwm' was unexpected) > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > Reviewed-by: Rob Herring <robh@kernel.org> > > --- > > Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 14 +++++++++++--- > > 1 file changed, 11 insertions(+), 3 deletions(-) > > Applied, thanks. Thanks Thierry, but this was already picked up by Rob into DT tree. Best regards, Krzysztof
On Wed, Sep 23, 2020 at 04:08:53PM +0200, Krzysztof Kozlowski wrote: > On Wed, 23 Sep 2020 at 13:52, Thierry Reding <thierry.reding@gmail.com> wrote: > > > > On Tue, Aug 25, 2020 at 09:35:23PM +0200, Krzysztof Kozlowski wrote: > > > DTSes with new i.MX 8M SoCs introduce their own compatibles so add them > > > to fix dtbs_check warnings like: > > > > > > arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000: > > > compatible:0: 'fsl,imx8mm-pwm' is not one of ['fsl,imx1-pwm', 'fsl,imx27-pwm'] > > > From schema: Documentation/devicetree/bindings/pwm/imx-pwm.yaml > > > > > > arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000: > > > compatible: ['fsl,imx8mm-pwm', 'fsl,imx27-pwm'] is too long > > > > > > arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000: > > > compatible: Additional items are not allowed ('fsl,imx27-pwm' was unexpected) > > > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > > Reviewed-by: Rob Herring <robh@kernel.org> > > > --- > > > Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 14 +++++++++++--- > > > 1 file changed, 11 insertions(+), 3 deletions(-) > > > > Applied, thanks. > > Thanks Thierry, but this was already picked up by Rob into DT tree. I hadn't seen any email and since Rob had given a reviewed-by I assumed this was supposed to be picked up into subsystem trees. I'll drop it again. Thierry
diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml index 01df06777cba..473863eb67e5 100644 --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml @@ -19,9 +19,17 @@ properties: - 3 compatible: - enum: - - fsl,imx1-pwm - - fsl,imx27-pwm + oneOf: + - enum: + - fsl,imx1-pwm + - fsl,imx27-pwm + - items: + - enum: + - fsl,imx8mm-pwm + - fsl,imx8mn-pwm + - fsl,imx8mp-pwm + - fsl,imx8mq-pwm + - const: fsl,imx27-pwm reg: maxItems: 1
DTSes with new i.MX 8M SoCs introduce their own compatibles so add them to fix dtbs_check warnings like: arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000: compatible:0: 'fsl,imx8mm-pwm' is not one of ['fsl,imx1-pwm', 'fsl,imx27-pwm'] From schema: Documentation/devicetree/bindings/pwm/imx-pwm.yaml arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000: compatible: ['fsl,imx8mm-pwm', 'fsl,imx27-pwm'] is too long arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000: compatible: Additional items are not allowed ('fsl,imx27-pwm' was unexpected) Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Rob Herring <robh@kernel.org> --- Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)