Message ID | 5af7c5af-c45d-2174-de89-8b89eddb4f4d@huawei.com |
---|---|
State | Awaiting Upstream |
Delegated to: | David Miller |
Headers | show |
Series | [-next,v2] net: ice: Fix pointer cast warnings | expand |
> From: Bixuan Cui <cuibixuan@huawei.com> > Sent: Friday, July 31, 2020 3:08 AM > To: davem@davemloft.net; kuba@kernel.org > Cc: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; intel-wired- > lan@lists.osuosl.org; netdev@vger.kernel.org; linux-next@vger.kernel.org > Subject: [PATCH -next v2] net: ice: Fix pointer cast warnings > > pointers should be casted to unsigned long to avoid > -Wpointer-to-int-cast warnings: > > drivers/net/ethernet/intel/ice/ice_flow.h:197:33: warning: > cast from pointer to integer of different size > drivers/net/ethernet/intel/ice/ice_flow.h:198:32: warning: > cast to pointer from integer of different size > > Signed-off-by: Bixuan Cui <cuibixuan@huawei.com> > --- > v2->v1: add fix: > ice_flow.h:198:32: warning: cast to pointer from integer of different size [- > Wint-to-pointer-cast] > #define ICE_FLOW_ENTRY_PTR(h) ((struct ice_flow_entry *)(h)) > > drivers/net/ethernet/intel/ice/ice_flow.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Tested-by: Aaron Brown <aaron.f.brown@intel.com>
ping~ On 2020/7/31 18:07, Bixuan Cui wrote: > pointers should be casted to unsigned long to avoid > -Wpointer-to-int-cast warnings: > > drivers/net/ethernet/intel/ice/ice_flow.h:197:33: warning: > cast from pointer to integer of different size > drivers/net/ethernet/intel/ice/ice_flow.h:198:32: warning: > cast to pointer from integer of different size > > Signed-off-by: Bixuan Cui <cuibixuan@huawei.com> > --- > v2->v1: add fix: > ice_flow.h:198:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > #define ICE_FLOW_ENTRY_PTR(h) ((struct ice_flow_entry *)(h)) > > drivers/net/ethernet/intel/ice/ice_flow.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ice/ice_flow.h b/drivers/net/ethernet/intel/ice/ice_flow.h > index 3913da2116d2..829f90b1e998 100644 > --- a/drivers/net/ethernet/intel/ice/ice_flow.h > +++ b/drivers/net/ethernet/intel/ice/ice_flow.h > @@ -194,8 +194,8 @@ struct ice_flow_entry { > u16 entry_sz; > }; > > -#define ICE_FLOW_ENTRY_HNDL(e) ((u64)e) > -#define ICE_FLOW_ENTRY_PTR(h) ((struct ice_flow_entry *)(h)) > +#define ICE_FLOW_ENTRY_HNDL(e) ((u64)(uintptr_t)e) > +#define ICE_FLOW_ENTRY_PTR(h) ((struct ice_flow_entry *)(uintptr_t)(h)) > > struct ice_flow_prof { > struct list_head l_entry; > -- > 2.17.1 > > > . >
diff --git a/drivers/net/ethernet/intel/ice/ice_flow.h b/drivers/net/ethernet/intel/ice/ice_flow.h index 3913da2116d2..829f90b1e998 100644 --- a/drivers/net/ethernet/intel/ice/ice_flow.h +++ b/drivers/net/ethernet/intel/ice/ice_flow.h @@ -194,8 +194,8 @@ struct ice_flow_entry { u16 entry_sz; }; -#define ICE_FLOW_ENTRY_HNDL(e) ((u64)e) -#define ICE_FLOW_ENTRY_PTR(h) ((struct ice_flow_entry *)(h)) +#define ICE_FLOW_ENTRY_HNDL(e) ((u64)(uintptr_t)e) +#define ICE_FLOW_ENTRY_PTR(h) ((struct ice_flow_entry *)(uintptr_t)(h)) struct ice_flow_prof { struct list_head l_entry;
pointers should be casted to unsigned long to avoid -Wpointer-to-int-cast warnings: drivers/net/ethernet/intel/ice/ice_flow.h:197:33: warning: cast from pointer to integer of different size drivers/net/ethernet/intel/ice/ice_flow.h:198:32: warning: cast to pointer from integer of different size Signed-off-by: Bixuan Cui <cuibixuan@huawei.com> --- v2->v1: add fix: ice_flow.h:198:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define ICE_FLOW_ENTRY_PTR(h) ((struct ice_flow_entry *)(h)) drivers/net/ethernet/intel/ice/ice_flow.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.1 .