diff mbox series

[net-next] net/packet: Fix a comment about network_header

Message ID 20200918135616.8677-1-xie.he.0141@gmail.com
State Accepted
Delegated to: David Miller
Headers show
Series [net-next] net/packet: Fix a comment about network_header | expand

Commit Message

Xie He Sept. 18, 2020, 1:56 p.m. UTC 
skb->nh.raw has been renamed as skb->network_header in 2007, in
commit b0e380b1d8a8 ("[SK_BUFF]: unions of just one member don't get
                      anything done, kill them")

So here we change it to the new name.

Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Signed-off-by: Xie He <xie.he.0141@gmail.com>
---
 net/packet/af_packet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller Sept. 19, 2020, 11:41 p.m. UTC | #1 
From: Xie He <xie.he.0141@gmail.com>
Date: Fri, 18 Sep 2020 06:56:16 -0700

> skb->nh.raw has been renamed as skb->network_header in 2007, in
> commit b0e380b1d8a8 ("[SK_BUFF]: unions of just one member don't get
>                       anything done, kill them")
> 
> So here we change it to the new name.
> 
> Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> Signed-off-by: Xie He <xie.he.0141@gmail.com>

Applied.
diff mbox series

Patch

diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index f59fa26d4826..cefbd50c1090 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -142,7 +142,7 @@  dev->header_ops == NULL (ll header is invisible to us)
    mac_header -> data
    data       -> data
 
-   We should set nh.raw on output to correct posistion,
+   We should set network_header on output to the correct position,
    packet classifier depends on it.
  */