diff mbox series

答复: [PATCH net-next] net: microchip: Remove set but not used variable

Message ID 874b27fec9d4494a89cbe76e4071b845@huawei.com
State Not Applicable
Delegated to: David Miller
Headers show
Series 答复: [PATCH net-next] net: microchip: Remove set but not used variable | expand

Commit Message

Zheng Yongjun Sept. 19, 2020, 3:02 a.m. UTC
This is the bad patch, please ignore it, thank you very much.

-----邮件原件-----
发件人: zhengyongjun 
发送时间: 2020年9月19日 10:38
收件人: bryan.whitehead@microchip.com; UNGLinuxDriver@microchip.com; davem@davemloft.net; kuba@kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
抄送: zhengyongjun <zhengyongjun3@huawei.com>
主题: [PATCH net-next] net: microchip: Remove set but not used variable

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/ethernet/microchip/lan743x_main.c: In function lan743x_pm_suspend:
drivers/net/ethernet/microchip/lan743x_main.c:3041:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]

`ret` is never used, so remove it.

Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
 drivers/net/ethernet/microchip/lan743x_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller Sept. 19, 2020, 9:12 p.m. UTC | #1
From: zhengyongjun <zhengyongjun3@huawei.com>
Date: Sat, 19 Sep 2020 03:02:39 +0000

> This is the bad patch, please ignore it, thank you very much.

Please do not quote your entire patch when you reply like this.

It makes the reply look like a brand new patch to our patchwork
tracking system, which makes more work for us.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c
index de93cc6ebc1a..56a1b5928f9a 100644
--- a/drivers/net/ethernet/microchip/lan743x_main.c
+++ b/drivers/net/ethernet/microchip/lan743x_main.c
@@ -3053,7 +3053,7 @@  static int lan743x_pm_suspend(struct device *dev)
 	/* Host sets PME_En, put D3hot */
 	ret = pci_prepare_to_sleep(pdev);
 
-	return 0;
+	return ret;
 }
 
 static int lan743x_pm_resume(struct device *dev)