mbox series

[0/1,G/master] md: improve IO accounting

Message ID 20200918083136.28343-1-paolo.pisati@canonical.com
Headers show
Series md: improve IO accounting | expand

Message

Paolo Pisati Sept. 18, 2020, 8:31 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1891151

[Impact]
Currently reported IO stats may be incorrect or missing.

The following patch correct statistics about in-flight IOs and IO processing time,
interpreted e.g. in iostat as await, svctm, aqu-sz and %util.

[Fix]
Upstream commit:
41d2d848 md: improve io stats accounting

The attached patch is a backport of the upstream commit, contextually modified to
make it apply cleanly.

[Regression potential]
Upstream code, and fixes IO stats that could be really useful.


Artur Paszkiewicz (1):
  md: improve io stats accounting

 drivers/md/md.c | 57 ++++++++++++++++++++++++++++++++++++++-----------
 drivers/md/md.h |  1 +
 2 files changed, 46 insertions(+), 12 deletions(-)

Comments

Andrea Righi Sept. 18, 2020, 8:38 a.m. UTC | #1 
On Fri, Sep 18, 2020 at 10:31:35AM +0200, Paolo Pisati wrote:
> BugLink: https://bugs.launchpad.net/bugs/1891151
> 
> [Impact]
> Currently reported IO stats may be incorrect or missing.
> 
> The following patch correct statistics about in-flight IOs and IO processing time,
> interpreted e.g. in iostat as await, svctm, aqu-sz and %util.
> 
> [Fix]
> Upstream commit:
> 41d2d848 md: improve io stats accounting
> 
> The attached patch is a backport of the upstream commit, contextually modified to
> make it apply cleanly.
> 
> [Regression potential]
> Upstream code, and fixes IO stats that could be really useful.

Looks good to me.

Acked-by: Andrea Righi <andrea.righi@canonical.com>

> 
> 
> Artur Paszkiewicz (1):
>   md: improve io stats accounting
> 
>  drivers/md/md.c | 57 ++++++++++++++++++++++++++++++++++++++-----------
>  drivers/md/md.h |  1 +
>  2 files changed, 46 insertions(+), 12 deletions(-)
> 
> -- 
> 2.25.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Paolo Pisati Sept. 22, 2020, 10:08 a.m. UTC | #2 
On Fri, Sep 18, 2020 at 10:31:35AM +0200, Paolo Pisati wrote:
> BugLink: https://bugs.launchpad.net/bugs/1891151