| Message ID | 20200916092333.77158-1-wangwensheng4@huawei.com |
|---|---|
| State | Under Review |
| Delegated to: | David Miller |
| Headers | show |
| Series | [-next] ide: Fix symbol undeclared warnings | expand |
Wang Wensheng <wangwensheng4@huawei.com> writes: > Build the object file with `C=2` and get the following warnings: > make allmodconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu- > make C=2 drivers/ide/pmac.o ARCH=powerpc64 > CROSS_COMPILE=powerpc64-linux-gnu- > > drivers/ide/pmac.c:228:23: warning: symbol 'mdma_timings_33' was not > declared. Should it be static? > drivers/ide/pmac.c:241:23: warning: symbol 'mdma_timings_33k' was not > declared. Should it be static? > drivers/ide/pmac.c:254:23: warning: symbol 'mdma_timings_66' was not > declared. Should it be static? > drivers/ide/pmac.c:272:3: warning: symbol 'kl66_udma_timings' was not > declared. Should it be static? > drivers/ide/pmac.c:1418:12: warning: symbol 'pmac_ide_probe' was not > declared. Should it be static? > > Signed-off-by: Wang Wensheng <wangwensheng4@huawei.com> > --- > drivers/ide/pmac.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) TIL davem maintains IDE? But I suspect he isn't that interested in this powerpc only driver, so I'll grab this. cheers > diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c > index ea0b064b5f56..6bb2fc6755c2 100644 > --- a/drivers/ide/pmac.c > +++ b/drivers/ide/pmac.c > @@ -225,7 +225,7 @@ struct mdma_timings_t { > int cycleTime; > }; > > -struct mdma_timings_t mdma_timings_33[] = > +static struct mdma_timings_t mdma_timings_33[] = > { > { 240, 240, 480 }, > { 180, 180, 360 }, > @@ -238,7 +238,7 @@ struct mdma_timings_t mdma_timings_33[] = > { 0, 0, 0 } > }; > > -struct mdma_timings_t mdma_timings_33k[] = > +static struct mdma_timings_t mdma_timings_33k[] = > { > { 240, 240, 480 }, > { 180, 180, 360 }, > @@ -251,7 +251,7 @@ struct mdma_timings_t mdma_timings_33k[] = > { 0, 0, 0 } > }; > > -struct mdma_timings_t mdma_timings_66[] = > +static struct mdma_timings_t mdma_timings_66[] = > { > { 240, 240, 480 }, > { 180, 180, 360 }, > @@ -265,7 +265,7 @@ struct mdma_timings_t mdma_timings_66[] = > }; > > /* KeyLargo ATA-4 Ultra DMA timings (rounded) */ > -struct { > +static struct { > int addrSetup; /* ??? */ > int rdy2pause; > int wrDataSetup; > @@ -1415,7 +1415,7 @@ static struct pci_driver pmac_ide_pci_driver = { > }; > MODULE_DEVICE_TABLE(pci, pmac_ide_pci_match); > > -int __init pmac_ide_probe(void) > +static int __init pmac_ide_probe(void) > { > int error; > > -- > 2.25.0
From: Michael Ellerman <mpe@ellerman.id.au> Date: Thu, 17 Sep 2020 22:01:00 +1000 > Wang Wensheng <wangwensheng4@huawei.com> writes: >> Build the object file with `C=2` and get the following warnings: >> make allmodconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu- >> make C=2 drivers/ide/pmac.o ARCH=powerpc64 >> CROSS_COMPILE=powerpc64-linux-gnu- >> >> drivers/ide/pmac.c:228:23: warning: symbol 'mdma_timings_33' was not >> declared. Should it be static? >> drivers/ide/pmac.c:241:23: warning: symbol 'mdma_timings_33k' was not >> declared. Should it be static? >> drivers/ide/pmac.c:254:23: warning: symbol 'mdma_timings_66' was not >> declared. Should it be static? >> drivers/ide/pmac.c:272:3: warning: symbol 'kl66_udma_timings' was not >> declared. Should it be static? >> drivers/ide/pmac.c:1418:12: warning: symbol 'pmac_ide_probe' was not >> declared. Should it be static? >> >> Signed-off-by: Wang Wensheng <wangwensheng4@huawei.com> >> --- >> drivers/ide/pmac.c | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) > > TIL davem maintains IDE? > > But I suspect he isn't that interested in this powerpc only driver, so > I'll grab this. I did have it in my queue, but if you want to take it that's fine too :)
David Miller <davem@davemloft.net> writes: > From: Michael Ellerman <mpe@ellerman.id.au> > Date: Thu, 17 Sep 2020 22:01:00 +1000 > >> Wang Wensheng <wangwensheng4@huawei.com> writes: >>> Build the object file with `C=2` and get the following warnings: >>> make allmodconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu- >>> make C=2 drivers/ide/pmac.o ARCH=powerpc64 >>> CROSS_COMPILE=powerpc64-linux-gnu- >>> >>> drivers/ide/pmac.c:228:23: warning: symbol 'mdma_timings_33' was not >>> declared. Should it be static? >>> drivers/ide/pmac.c:241:23: warning: symbol 'mdma_timings_33k' was not >>> declared. Should it be static? >>> drivers/ide/pmac.c:254:23: warning: symbol 'mdma_timings_66' was not >>> declared. Should it be static? >>> drivers/ide/pmac.c:272:3: warning: symbol 'kl66_udma_timings' was not >>> declared. Should it be static? >>> drivers/ide/pmac.c:1418:12: warning: symbol 'pmac_ide_probe' was not >>> declared. Should it be static? >>> >>> Signed-off-by: Wang Wensheng <wangwensheng4@huawei.com> >>> --- >>> drivers/ide/pmac.c | 10 +++++----- >>> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> TIL davem maintains IDE? >> >> But I suspect he isn't that interested in this powerpc only driver, so >> I'll grab this. > > I did have it in my queue, but if you want to take it that's fine too :) That's OK, if you've got it already you take it. Thanks. cheers
diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c index ea0b064b5f56..6bb2fc6755c2 100644 --- a/drivers/ide/pmac.c +++ b/drivers/ide/pmac.c @@ -225,7 +225,7 @@ struct mdma_timings_t { int cycleTime; }; -struct mdma_timings_t mdma_timings_33[] = +static struct mdma_timings_t mdma_timings_33[] = { { 240, 240, 480 }, { 180, 180, 360 }, @@ -238,7 +238,7 @@ struct mdma_timings_t mdma_timings_33[] = { 0, 0, 0 } }; -struct mdma_timings_t mdma_timings_33k[] = +static struct mdma_timings_t mdma_timings_33k[] = { { 240, 240, 480 }, { 180, 180, 360 }, @@ -251,7 +251,7 @@ struct mdma_timings_t mdma_timings_33k[] = { 0, 0, 0 } }; -struct mdma_timings_t mdma_timings_66[] = +static struct mdma_timings_t mdma_timings_66[] = { { 240, 240, 480 }, { 180, 180, 360 }, @@ -265,7 +265,7 @@ struct mdma_timings_t mdma_timings_66[] = }; /* KeyLargo ATA-4 Ultra DMA timings (rounded) */ -struct { +static struct { int addrSetup; /* ??? */ int rdy2pause; int wrDataSetup; @@ -1415,7 +1415,7 @@ static struct pci_driver pmac_ide_pci_driver = { }; MODULE_DEVICE_TABLE(pci, pmac_ide_pci_match); -int __init pmac_ide_probe(void) +static int __init pmac_ide_probe(void) { int error;
Build the object file with `C=2` and get the following warnings: make allmodconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu- make C=2 drivers/ide/pmac.o ARCH=powerpc64 CROSS_COMPILE=powerpc64-linux-gnu- drivers/ide/pmac.c:228:23: warning: symbol 'mdma_timings_33' was not declared. Should it be static? drivers/ide/pmac.c:241:23: warning: symbol 'mdma_timings_33k' was not declared. Should it be static? drivers/ide/pmac.c:254:23: warning: symbol 'mdma_timings_66' was not declared. Should it be static? drivers/ide/pmac.c:272:3: warning: symbol 'kl66_udma_timings' was not declared. Should it be static? drivers/ide/pmac.c:1418:12: warning: symbol 'pmac_ide_probe' was not declared. Should it be static? Signed-off-by: Wang Wensheng <wangwensheng4@huawei.com> --- drivers/ide/pmac.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)