| Message ID | 20200915113815.3768217-1-iii@linux.ibm.com |
|---|---|
| State | Accepted |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | [bpf-next,v2] selftests/bpf: Fix endianness issue in sk_assign | expand |
On Tue, Sep 15, 2020 at 4:38 AM Ilya Leoshkevich <iii@linux.ibm.com> wrote: > > server_map's value size is 8, but the test tries to put an int there. > This sort of works on x86 (unless followed by non-0), but hard fails on > s390. > > Fix by using __s64 instead of int. > > Fixes: 2d7824ffd25c ("selftests: bpf: Add test for sk_assign") > Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com> > --- > > v1->v2: Use __s64. Acked-by: Andrii Nakryiko <andriin@fb.com> > > tools/testing/selftests/bpf/prog_tests/sk_assign.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/bpf/prog_tests/sk_assign.c b/tools/testing/selftests/bpf/prog_tests/sk_assign.c > index a49a26f95a8b..3a469099f30d 100644 > --- a/tools/testing/selftests/bpf/prog_tests/sk_assign.c > +++ b/tools/testing/selftests/bpf/prog_tests/sk_assign.c > @@ -265,7 +265,7 @@ void test_sk_assign(void) > TEST("ipv6 udp port redir", AF_INET6, SOCK_DGRAM, false), > TEST("ipv6 udp addr redir", AF_INET6, SOCK_DGRAM, true), > }; > - int server = -1; > + __s64 server = -1; > int server_map; > int self_net; > int i; > -- > 2.25.4 >
diff --git a/tools/testing/selftests/bpf/prog_tests/sk_assign.c b/tools/testing/selftests/bpf/prog_tests/sk_assign.c index a49a26f95a8b..3a469099f30d 100644 --- a/tools/testing/selftests/bpf/prog_tests/sk_assign.c +++ b/tools/testing/selftests/bpf/prog_tests/sk_assign.c @@ -265,7 +265,7 @@ void test_sk_assign(void) TEST("ipv6 udp port redir", AF_INET6, SOCK_DGRAM, false), TEST("ipv6 udp addr redir", AF_INET6, SOCK_DGRAM, true), }; - int server = -1; + __s64 server = -1; int server_map; int self_net; int i;
server_map's value size is 8, but the test tries to put an int there. This sort of works on x86 (unless followed by non-0), but hard fails on s390. Fix by using __s64 instead of int. Fixes: 2d7824ffd25c ("selftests: bpf: Add test for sk_assign") Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com> --- v1->v2: Use __s64. tools/testing/selftests/bpf/prog_tests/sk_assign.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)