diff mbox series

[1/2] package/python3: do not install MS Windows installers on the target

Message ID 20200912115622.134543-1-titouan.christophe@railnova.eu
State Accepted
Headers show
Series [1/2] package/python3: do not install MS Windows installers on the target | expand

Commit Message

Titouan Christophe Sept. 12, 2020, 11:56 a.m. UTC
Buildroot generates Linux systems, so there is no need to have
MS Windows executables in there.

This reduces the target filesystem size by about 2MB:
$ du -hcs usr/lib/python3.8/distutils/command/wininst-*.exe
60K usr/lib/python3.8/distutils/command/wininst-6.0.exe
64K usr/lib/python3.8/distutils/command/wininst-7.1.exe
60K usr/lib/python3.8/distutils/command/wininst-8.0.exe
192K    usr/lib/python3.8/distutils/command/wininst-9.0.exe
220K    usr/lib/python3.8/distutils/command/wininst-9.0-amd64.exe
188K    usr/lib/python3.8/distutils/command/wininst-10.0.exe
220K    usr/lib/python3.8/distutils/command/wininst-10.0-amd64.exe
448K    usr/lib/python3.8/distutils/command/wininst-14.0.exe
576K    usr/lib/python3.8/distutils/command/wininst-14.0-amd64.exe
2,0M    total

Signed-off-by: Titouan Christophe <titouan.christophe@railnova.eu>
---
 package/python3/python3.mk | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Petazzoni Sept. 13, 2020, 2:21 p.m. UTC | #1
On Sat, 12 Sep 2020 13:56:21 +0200
Titouan Christophe <titouan.christophe@railnova.eu> wrote:

> Buildroot generates Linux systems, so there is no need to have
> MS Windows executables in there.
> 
> This reduces the target filesystem size by about 2MB:
> $ du -hcs usr/lib/python3.8/distutils/command/wininst-*.exe
> 60K usr/lib/python3.8/distutils/command/wininst-6.0.exe
> 64K usr/lib/python3.8/distutils/command/wininst-7.1.exe
> 60K usr/lib/python3.8/distutils/command/wininst-8.0.exe
> 192K    usr/lib/python3.8/distutils/command/wininst-9.0.exe
> 220K    usr/lib/python3.8/distutils/command/wininst-9.0-amd64.exe
> 188K    usr/lib/python3.8/distutils/command/wininst-10.0.exe
> 220K    usr/lib/python3.8/distutils/command/wininst-10.0-amd64.exe
> 448K    usr/lib/python3.8/distutils/command/wininst-14.0.exe
> 576K    usr/lib/python3.8/distutils/command/wininst-14.0-amd64.exe
> 2,0M    total
> 
> Signed-off-by: Titouan Christophe <titouan.christophe@railnova.eu>
> ---
>  package/python3/python3.mk | 1 +
>  1 file changed, 1 insertion(+)

Both applied. Thanks!

Thomas
Peter Korsgaard Sept. 15, 2020, 4:03 p.m. UTC | #2
>>>>> "Titouan" == Titouan Christophe <titouan.christophe@railnova.eu> writes:

 > Buildroot generates Linux systems, so there is no need to have
 > MS Windows executables in there.

 > This reduces the target filesystem size by about 2MB:
 > $ du -hcs usr/lib/python3.8/distutils/command/wininst-*.exe
 > 60K usr/lib/python3.8/distutils/command/wininst-6.0.exe
 > 64K usr/lib/python3.8/distutils/command/wininst-7.1.exe
 > 60K usr/lib/python3.8/distutils/command/wininst-8.0.exe
 > 192K    usr/lib/python3.8/distutils/command/wininst-9.0.exe
 > 220K    usr/lib/python3.8/distutils/command/wininst-9.0-amd64.exe
 > 188K    usr/lib/python3.8/distutils/command/wininst-10.0.exe
 > 220K    usr/lib/python3.8/distutils/command/wininst-10.0-amd64.exe
 > 448K    usr/lib/python3.8/distutils/command/wininst-14.0.exe
 > 576K    usr/lib/python3.8/distutils/command/wininst-14.0-amd64.exe
 > 2,0M    total

 > Signed-off-by: Titouan Christophe <titouan.christophe@railnova.eu>

Funky!

It seems like we need to do something similar for python{,3}-setuptools:

# find /usr/ -name \*.exe | grep -v wininst | xargs ls -lahS
-rw-rw-r--    1 root     root       73.5K Sep  8 14:28 /usr/lib/python3.8/site-packages/setuptools/gui-64.exe
-rw-rw-r--    1 root     root       73.0K Sep  8 14:28 /usr/lib/python3.8/site-packages/setuptools/cli-64.exe
-rw-rw-r--    1 root     root       64.0K Sep  8 14:28 /usr/lib/python3.8/site-packages/setuptools/cli-32.exe
-rw-rw-r--    1 root     root       64.0K Sep  8 14:28 /usr/lib/python3.8/site-packages/setuptools/cli.exe
-rw-rw-r--    1 root     root       64.0K Sep  8 14:28 /usr/lib/python3.8/site-packages/setuptools/gui-32.exe
-rw-rw-r--    1 root     root       64.0K Sep  8 14:28 /usr/lib/python3.8/site-packages/setuptools/gui.exe
Peter Korsgaard Sept. 15, 2020, 6:10 p.m. UTC | #3
>>>>> "Titouan" == Titouan Christophe <titouan.christophe@railnova.eu> writes:

 > Buildroot generates Linux systems, so there is no need to have
 > MS Windows executables in there.

 > This reduces the target filesystem size by about 2MB:
 > $ du -hcs usr/lib/python3.8/distutils/command/wininst-*.exe
 > 60K usr/lib/python3.8/distutils/command/wininst-6.0.exe
 > 64K usr/lib/python3.8/distutils/command/wininst-7.1.exe
 > 60K usr/lib/python3.8/distutils/command/wininst-8.0.exe
 > 192K    usr/lib/python3.8/distutils/command/wininst-9.0.exe
 > 220K    usr/lib/python3.8/distutils/command/wininst-9.0-amd64.exe
 > 188K    usr/lib/python3.8/distutils/command/wininst-10.0.exe
 > 220K    usr/lib/python3.8/distutils/command/wininst-10.0-amd64.exe
 > 448K    usr/lib/python3.8/distutils/command/wininst-14.0.exe
 > 576K    usr/lib/python3.8/distutils/command/wininst-14.0-amd64.exe
 > 2,0M    total

 > Signed-off-by: Titouan Christophe <titouan.christophe@railnova.eu>

Committed to 2020.02.x, 2020.05.x and 2020.08.x, thanks.
diff mbox series

Patch

diff --git a/package/python3/python3.mk b/package/python3/python3.mk
index 31e7ca3d3a..3c2f71e448 100644
--- a/package/python3/python3.mk
+++ b/package/python3/python3.mk
@@ -212,6 +212,7 @@  define PYTHON3_REMOVE_USELESS_FILES
 	rm -f $(TARGET_DIR)/usr/bin/python$(PYTHON3_VERSION_MAJOR)m-config
 	rm -f $(TARGET_DIR)/usr/bin/python3-config
 	rm -f $(TARGET_DIR)/usr/bin/smtpd.py.3
+	rm -f $(TARGET_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)/distutils/command/wininst*.exe
 	for i in `find $(TARGET_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)/config-$(PYTHON3_VERSION_MAJOR)m-*/ \
 		-type f -not -name Makefile` ; do \
 		rm -f $$i ; \