mbox series

[0/1] Adding 100base FX support

Message ID 20200914170638.22451-1-dmurphy@ti.com
Headers show
Series Adding 100base FX support | expand

Message

Dan Murphy Sept. 14, 2020, 5:06 p.m. UTC 
Hello

I am adding the 100base Fx support for the ethtool.  There are a few PHYs that
support the Fiber connection and the ethtool should be able to properly display
that the PHY supports the 100base-FX Full and Half Duplex modes.

I am adding this support in the ethtool first and then submit the fiber bits
into the kernel.

If the kernel needs to be updated first then I can prepare those patches and
reference them.

Dan

Dan Murphy (1):
  ethtool: Add 100BaseFX half and full duplex link modes

 ethtool.c            | 6 ++++++
 netlink/settings.c   | 2 ++
 uapi/linux/ethtool.h | 2 ++
 3 files changed, 10 insertions(+)

Comments

Michal Kubecek Sept. 14, 2020, 11:17 p.m. UTC | #1 
On Mon, Sep 14, 2020 at 12:06:37PM -0500, Dan Murphy wrote:
> Hello
> 
> I am adding the 100base Fx support for the ethtool.  There are a few PHYs that
> support the Fiber connection and the ethtool should be able to properly display
> that the PHY supports the 100base-FX Full and Half Duplex modes.
> 
> I am adding this support in the ethtool first and then submit the fiber bits
> into the kernel.
> 
> If the kernel needs to be updated first then I can prepare those patches and
> reference them.

Please add the support to kernel first. Otherwise the kernel-userspace
API may change (e.g. if someone adds another mode before yours so that
the constants would be different from your current submission). You
don't have to wait until the change reaches mainline but it should be
accepted at least to the net-next kernel tree.

Some technical notes:

  - please use "[PATCH ethtool]" subject prefix rather than "ethtool: "
    for ethtool utility patches to distinguish them from patches
    targeting kernel ethtool code
  - please update the header file copies in uapi/ directory in
    a separate patch and update all of them to a specific kernel commit
    as requested in
    https://mirrors.edge.kernel.org/pub/software/network/ethtool/devel.html

Michal

> 
> Dan
> 
> Dan Murphy (1):
>   ethtool: Add 100BaseFX half and full duplex link modes
> 
>  ethtool.c            | 6 ++++++
>  netlink/settings.c   | 2 ++
>  uapi/linux/ethtool.h | 2 ++
>  3 files changed, 10 insertions(+)
> 
> -- 
> 2.28.0
>