mbox series

[v2,0/4] net: lantiq: Fix bugs in NAPI handling

Message ID 20200912193629.1586-1-hauke@hauke-m.de
Headers show
Series net: lantiq: Fix bugs in NAPI handling | expand

Message

Hauke Mehrtens Sept. 12, 2020, 7:36 p.m. UTC 
This fixes multiple bugs in the NAPI handling.

Changes since:
v1:
 - removed stable tag from "net: lantiq: use netif_tx_napi_add() for TX NAPI"
 - Check the NAPI budged in "net: lantiq: Use napi_complete_done()"
 - Add extra fix "net: lantiq: Disable IRQs only if NAPI gets scheduled"

Hauke Mehrtens (4):
  net: lantiq: Wake TX queue again
  net: lantiq: use netif_tx_napi_add() for TX NAPI
  net: lantiq: Use napi_complete_done()
  net: lantiq: Disable IRQs only if NAPI gets scheduled

 drivers/net/ethernet/lantiq_xrx200.c | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

Comments

Martin Blumenstingl Sept. 12, 2020, 8:22 p.m. UTC | #1 
Hi Hauke,

On Sat, Sep 12, 2020 at 9:36 PM Hauke Mehrtens <hauke@hauke-m.de> wrote:
>
> This fixes multiple bugs in the NAPI handling.
many thanks!
These fix the TX hang that I could reproduce by simply starting iperf3
on a lantiq board.

Is the plan to have these patches applied to net or net-next?
Having them in the net tree would be great so these can be backported
to 5.4 (which is what OpenWrt uses)

> Hauke Mehrtens (4):
>   net: lantiq: Wake TX queue again
>   net: lantiq: use netif_tx_napi_add() for TX NAPI
>   net: lantiq: Use napi_complete_done()
>   net: lantiq: Disable IRQs only if NAPI gets scheduled
for all four:
Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>


Thank you!
Martin
David Miller Sept. 14, 2020, 9:54 p.m. UTC | #2 
From: Hauke Mehrtens <hauke@hauke-m.de>
Date: Sat, 12 Sep 2020 21:36:25 +0200

> This fixes multiple bugs in the NAPI handling.
> 
> Changes since:
> v1:
>  - removed stable tag from "net: lantiq: use netif_tx_napi_add() for TX NAPI"
>  - Check the NAPI budged in "net: lantiq: Use napi_complete_done()"
>  - Add extra fix "net: lantiq: Disable IRQs only if NAPI gets scheduled"

Series applied and queued up for -stable.

Please answer Jakub's question about patch #4.

Thanks.