Message ID | 20200907101208.1223-4-pbarker@konsulko.com |
---|---|
State | Changes Requested |
Delegated to: | David Miller |
Headers | show |
Series | ksz9477 dsa switch driver improvements | expand |
On 9/7/2020 3:12 AM, Paul Barker wrote: > We can't assume that the link partner supports the in-band status > reporting which is enabled by default on the KSZ9893 when using RGMII > for the upstream port. > > Signed-off-by: Paul Barker <pbarker@konsulko.com> > Reviewed-by: Andrew Lunn <andrew@lunn.ch> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c index 9513af057793..f379ea8242e0 100644 --- a/drivers/net/dsa/microchip/ksz9477.c +++ b/drivers/net/dsa/microchip/ksz9477.c @@ -1235,6 +1235,9 @@ static void ksz9477_port_setup(struct ksz_device *dev, int port, bool cpu_port) if (dev->interface == PHY_INTERFACE_MODE_RGMII_ID || dev->interface == PHY_INTERFACE_MODE_RGMII_TXID) data8 |= PORT_RGMII_ID_EG_ENABLE; + /* On KSZ9893, disable RGMII in-band status support */ + if (dev->features & IS_9893) + data8 &= ~PORT_MII_MAC_MODE; p->phydev.speed = SPEED_1000; break; }