mbox series

[net-next,0/6] Convert mvpp2 to split PCS support

Message ID 20200901134746.GM1551@shell.armlinux.org.uk
Headers show
Series Convert mvpp2 to split PCS support | expand

Message

Russell King (Oracle) Sept. 1, 2020, 1:47 p.m. UTC 
Hi,

This series converts the mvpp2 driver to use the split PCS support
that has been merged into phylink last time around. I've been running
this for some time here and, apart from the recent bug fix sent to
net-next, have not seen any issues on DT based systems. I have not
tested ACPI setups, although I've tried to preserve the workaround.

Patch 1 formalises the ACPI workaround.
Patch 2 moves some of mac_config() to the mac_prepare() and
  mac_finish() callbacks so we can keep the ordering when we split
  the PCS bits out.
Patch 3 ensures that the port is forced down while changing the
  interface mode - when in in-band mode, doing this in mac_prepare()
  and mac_finish().
Patch 4 moves the reset handling to mac_prepare() and mac_finish()
Patch 5 does a straight conversion to use PCS operations.
Patch 6 splits the PCS operations into a GMAC PCS operations and
  XLG PCS operations, selecting the appropriate set during
  mac_prepare().  This eliminates a bunch of conditionals from the
  code.

 drivers/net/ethernet/marvell/mvpp2/mvpp2.h      |   1 +
 drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 466 ++++++++++++++----------
 2 files changed, 284 insertions(+), 183 deletions(-)

Comments

David Miller Sept. 3, 2020, 9:53 p.m. UTC | #1 
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Date: Tue, 1 Sep 2020 14:47:46 +0100

> This series converts the mvpp2 driver to use the split PCS support
> that has been merged into phylink last time around. I've been running
> this for some time here and, apart from the recent bug fix sent to
> net-next, have not seen any issues on DT based systems. I have not
> tested ACPI setups, although I've tried to preserve the workaround.
 ...

Series applied, thank you.