diff mbox

[net-next,1/5] qlcnic: Fix enviroment variable for udev event generation during FW dump

Message ID 1311982230-10543-1-git-send-email-anirban.chakraborty@qlogic.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Anirban Chakraborty July 29, 2011, 11:30 p.m. UTC
Driver was not generating the environment variable for the FW dump event correctly.
Fix it by formatting it properly.

Signed-off-by: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
---
 drivers/net/qlcnic/qlcnic_hw.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

David Miller Aug. 1, 2011, 8:57 a.m. UTC | #1
From: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
Date: Fri, 29 Jul 2011 16:30:30 -0700

> Please apply the series to net-next. Thanks.

Queued up for net-next
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Anirban Chakraborty Aug. 1, 2011, 3:24 p.m. UTC | #2
On Aug 1, 2011, at 1:57 AM, David Miller wrote:

> From: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
> Date: Fri, 29 Jul 2011 16:30:30 -0700
> 
>> Please apply the series to net-next. Thanks.
> 
> Queued up for net-next

Would it be too much of a trouble to push these to net-2.6, as these are minor bug fixes anyway?

Thanks a lot.

-Anirban


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller Aug. 2, 2011, 12:38 a.m. UTC | #3
From: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
Date: Mon, 1 Aug 2011 08:24:04 -0700

> 
> On Aug 1, 2011, at 1:57 AM, David Miller wrote:
> 
>> From: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
>> Date: Fri, 29 Jul 2011 16:30:30 -0700
>> 
>>> Please apply the series to net-next. Thanks.
>> 
>> Queued up for net-next
> 
> Would it be too much of a trouble to push these to net-2.6, as these are minor bug fixes anyway?

No.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Anirban Chakraborty Aug. 3, 2011, 8:20 p.m. UTC | #4
On Aug 1, 2011, at 5:38 PM, David Miller wrote:

> From: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
> Date: Mon, 1 Aug 2011 08:24:04 -0700
> 
>> 
>> On Aug 1, 2011, at 1:57 AM, David Miller wrote:
>> 
>>> From: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
>>> Date: Fri, 29 Jul 2011 16:30:30 -0700
>>> 
>>>> Please apply the series to net-next. Thanks.
>>> 
>>> Queued up for net-next
>> 
>> Would it be too much of a trouble to push these to net-2.6, as these are minor bug fixes anyway?
> 
> No.

Do you want me to resend the patch series for net-2.6? It was my mistake to specify net-next instead of net-2.6

Thanks.
-Anirban



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller Aug. 3, 2011, 11:30 p.m. UTC | #5
From: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
Date: Wed, 3 Aug 2011 13:20:00 -0700

> Do you want me to resend the patch series for net-2.6? It was my
> mistake to specify net-next instead of net-2.6

The debug support patches are not appropriate for plain 'net',
only the pure most critical bug fixes are.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/qlcnic/qlcnic_hw.c b/drivers/net/qlcnic/qlcnic_hw.c
index 4055c21..74e9d7b 100644
--- a/drivers/net/qlcnic/qlcnic_hw.c
+++ b/drivers/net/qlcnic/qlcnic_hw.c
@@ -1773,8 +1773,8 @@  int qlcnic_dump_fw(struct qlcnic_adapter *adapter)
 		goto error;
 	} else {
 		fw_dump->clr = 1;
-		snprintf(mesg, sizeof(mesg), "FW dump for device: %d\n",
-			adapter->pdev->devfn);
+		snprintf(mesg, sizeof(mesg), "FW_DUMP=%s",
+			adapter->netdev->name);
 		dev_info(&adapter->pdev->dev, "Dump data, %d bytes captured\n",
 			fw_dump->size);
 		/* Send a udev event to notify availability of FW dump */