diff mbox series

pktgen: fix error message with wrong function name

Message ID 20200901130449.15422-1-dev@ooseel.net
State Accepted
Delegated to: David Miller
Headers show
Series pktgen: fix error message with wrong function name | expand

Commit Message

Leesoo Ahn Sept. 1, 2020, 1:04 p.m. UTC
Error on calling kthread_create_on_node prints wrong function name,
kernel_thread.

Signed-off-by: Leesoo Ahn <dev@ooseel.net>
---
 net/core/pktgen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Gustavo A. R. Silva Sept. 1, 2020, 5:25 p.m. UTC | #1
On Tue, Sep 01, 2020 at 10:04:47PM +0900, Leesoo Ahn wrote:
> Error on calling kthread_create_on_node prints wrong function name,
> kernel_thread.
> 
> Signed-off-by: Leesoo Ahn <dev@ooseel.net>

You might need to add the following tag:

Fixes: 94dcf29a11b3 ("kthread: use kthread_create_on_node()")

Acked-by: Gustavo A. R. Silva <gustavoars@kernel.org>

Thanks
--
Gustavo

> ---
>  net/core/pktgen.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/core/pktgen.c b/net/core/pktgen.c
> index 95f4c6b8f51a..44fdbb9c6e53 100644
> --- a/net/core/pktgen.c
> +++ b/net/core/pktgen.c
> @@ -3699,7 +3699,7 @@ static int __net_init pktgen_create_thread(int cpu, struct pktgen_net *pn)
>  				   cpu_to_node(cpu),
>  				   "kpktgend_%d", cpu);
>  	if (IS_ERR(p)) {
> -		pr_err("kernel_thread() failed for cpu %d\n", t->cpu);
> +		pr_err("kthread_create_on_node() failed for cpu %d\n", t->cpu);
>  		list_del(&t->th_list);
>  		kfree(t);
>  		return PTR_ERR(p);
> -- 
> 2.25.4
>
David Miller Sept. 1, 2020, 6:45 p.m. UTC | #2
From: Leesoo Ahn <dev@ooseel.net>
Date: Tue,  1 Sep 2020 22:04:47 +0900

> Error on calling kthread_create_on_node prints wrong function name,
> kernel_thread.
> 
> Signed-off-by: Leesoo Ahn <dev@ooseel.net>

Applied with Fixes: tag added.
diff mbox series

Patch

diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 95f4c6b8f51a..44fdbb9c6e53 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -3699,7 +3699,7 @@  static int __net_init pktgen_create_thread(int cpu, struct pktgen_net *pn)
 				   cpu_to_node(cpu),
 				   "kpktgend_%d", cpu);
 	if (IS_ERR(p)) {
-		pr_err("kernel_thread() failed for cpu %d\n", t->cpu);
+		pr_err("kthread_create_on_node() failed for cpu %d\n", t->cpu);
 		list_del(&t->th_list);
 		kfree(t);
 		return PTR_ERR(p);