mbox series

[net-next,0/5] ionic: struct cleanups

Message ID 20200831233558.71417-1-snelson@pensando.io
Headers show
Series ionic: struct cleanups | expand

Message

Shannon Nelson Aug. 31, 2020, 11:35 p.m. UTC
This patchset has a few changes for better cacheline use,
to cleanup a page handling API, and to streamline the
Adminq/Notifyq queue handling.

Shannon Nelson (5):
  ionic: clean up page handling code
  ionic: smaller coalesce default
  ionic: struct reorder for faster access
  ionic: clean up desc_info and cq_info structs
  ionic: clean adminq service routine

 drivers/net/ethernet/pensando/ionic/ionic.h   |  3 -
 .../net/ethernet/pensando/ionic/ionic_dev.c   | 33 +-------
 .../net/ethernet/pensando/ionic/ionic_dev.h   | 26 +++---
 .../net/ethernet/pensando/ionic/ionic_lif.c   | 44 +++++-----
 .../net/ethernet/pensando/ionic/ionic_lif.h   | 14 ++--
 .../net/ethernet/pensando/ionic/ionic_main.c  | 26 ------
 .../net/ethernet/pensando/ionic/ionic_txrx.c  | 81 +++++++++++--------
 7 files changed, 92 insertions(+), 135 deletions(-)

Comments

Florian Fainelli Sept. 1, 2020, 12:47 a.m. UTC | #1
On 8/31/2020 4:35 PM, Shannon Nelson wrote:
> This patchset has a few changes for better cacheline use,
> to cleanup a page handling API, and to streamline the
> Adminq/Notifyq queue handling.

Some other non technical changes, the changes that Neel in the 
Signed-off-by should also have a From that matches his Signed-off-by, or 
you should use Co-developped-by, or some variant of it.

> 
> Shannon Nelson (5):
>    ionic: clean up page handling code
>    ionic: smaller coalesce default
>    ionic: struct reorder for faster access
>    ionic: clean up desc_info and cq_info structs
>    ionic: clean adminq service routine
> 
>   drivers/net/ethernet/pensando/ionic/ionic.h   |  3 -
>   .../net/ethernet/pensando/ionic/ionic_dev.c   | 33 +-------
>   .../net/ethernet/pensando/ionic/ionic_dev.h   | 26 +++---
>   .../net/ethernet/pensando/ionic/ionic_lif.c   | 44 +++++-----
>   .../net/ethernet/pensando/ionic/ionic_lif.h   | 14 ++--
>   .../net/ethernet/pensando/ionic/ionic_main.c  | 26 ------
>   .../net/ethernet/pensando/ionic/ionic_txrx.c  | 81 +++++++++++--------
>   7 files changed, 92 insertions(+), 135 deletions(-)
>
Shannon Nelson Sept. 1, 2020, 4:21 a.m. UTC | #2
On 8/31/20 5:47 PM, Florian Fainelli wrote:
>
> On 8/31/2020 4:35 PM, Shannon Nelson wrote:
>> This patchset has a few changes for better cacheline use,
>> to cleanup a page handling API, and to streamline the
>> Adminq/Notifyq queue handling.
>
> Some other non technical changes, the changes that Neel in the 
> Signed-off-by should also have a From that matches his Signed-off-by, 
> or you should use Co-developped-by, or some variant of it.

Thanks.  For now, I'll go back to using co-developed.
sln