mbox series

[0/2,v3,net-next] 8390: core cleanups

Message ID 20200829111701.GA9219@mx-linux-amd
Headers show
Series 8390: core cleanups | expand

Message

Armin Wolf Aug. 29, 2020, 11:17 a.m. UTC 
The purpose of this patchset is to do some
cleanups in lib8390.c and 8390.c.

While most changes are coding-style related,
pr_cont() usage in lib8390.c was replaced by
a more SMP-safe construct.

Other functional changes include the removal of
version-printing in lib8390.c so modules using lib8390.c
do not need a global version-string in order to compile
successfully.

Patches do compile and run flawless on 5.9.0-rc1 with
a RTL8029AS nic using ne2k-pci.

v3 changes:
- swap commits to not break buildability (sorry)
- move MODULE_LICENCE at the bottom and remove MODULE_VERSION in 8390.c

v2 changes:
- change "librarys" to "libraries" in 8390.c commit
- improve 8390.c commit
- prevent uneven whitespaces in error message (lib8390.c)
- do not destroy kernel doc comments in lib8390.c
- fix some typos in lib8390.c

Armin Wolf (2):
  lib8390: Fix coding-style issues and remove verion printing
  8390: Miscellaneous cleanups

 drivers/net/ethernet/8390/8390.c    |  21 +-
 drivers/net/ethernet/8390/lib8390.c | 590 ++++++++++++++--------------
 2 files changed, 308 insertions(+), 303 deletions(-)

--
2.20.1

Comments

David Miller Aug. 31, 2020, 7:36 p.m. UTC | #1 
From: Armin Wolf <W_Armin@gmx.de>
Date: Sat, 29 Aug 2020 13:17:32 +0200

> The purpose of this patchset is to do some
> cleanups in lib8390.c and 8390.c.
> 
> While most changes are coding-style related,
> pr_cont() usage in lib8390.c was replaced by
> a more SMP-safe construct.
> 
> Other functional changes include the removal of
> version-printing in lib8390.c so modules using lib8390.c
> do not need a global version-string in order to compile
> successfully.
> 
> Patches do compile and run flawless on 5.9.0-rc1 with
> a RTL8029AS nic using ne2k-pci.
 ...

Series applied to net-next.
David Miller Aug. 31, 2020, 7:37 p.m. UTC | #2 
From: David Miller <davem@davemloft.net>
Date: Mon, 31 Aug 2020 12:36:21 -0700 (PDT)

> From: Armin Wolf <W_Armin@gmx.de>
> Date: Sat, 29 Aug 2020 13:17:32 +0200
> 
>> The purpose of this patchset is to do some
>> cleanups in lib8390.c and 8390.c.
>> 
>> While most changes are coding-style related,
>> pr_cont() usage in lib8390.c was replaced by
>> a more SMP-safe construct.
>> 
>> Other functional changes include the removal of
>> version-printing in lib8390.c so modules using lib8390.c
>> do not need a global version-string in order to compile
>> successfully.
>> 
>> Patches do compile and run flawless on 5.9.0-rc1 with
>> a RTL8029AS nic using ne2k-pci.
>  ...
> 
> Series applied to net-next.

Actually reverted, this adds a new build warning:

drivers/net/ethernet/8390/ax88796.c:58:22: warning: ‘version’ defined but not used [-Wunused-variable]
   58 | static unsigned char version[] = "ax88796.c: Copyright 2005,2007 Simtec Electronics\n";
      |                      ^~~~~~~
  C-c C-cmake[2]: *** Deleting file 'net/sunrpc/auth.o'