mbox series

[net-next,v3,0/2] Enable Fiber on DP83822 PHY

Message ID 20200827134509.23854-1-dmurphy@ti.com
Headers show
Series Enable Fiber on DP83822 PHY | expand

Message

Dan Murphy Aug. 27, 2020, 1:45 p.m. UTC 
Hello

The DP83822 Ethernet PHY has the ability to connect via a Fiber port.  The
derivative PHYs DP83825 and DP83826 do not have this ability. In fiber mode
the DP83822 disables auto negotiation and has a fixed 100Mbps speed with
support for full or half duplex modes.

A devicetree binding was added to set the signal polarity for the fiber
connection.  This property is only applicable if the FX_EN strap is set in
hardware other wise the signal loss detection is disabled on the PHY.

If the FX_EN is not strapped the device can be configured to run in fiber mode
via the device tree. All be it the PHY will not perform signal loss detection.

v2 review from a long time ago can be found here - https://lore.kernel.org/patchwork/patch/1270958/

Dan

Dan Murphy (2):
  dt-bindings: net: dp83822: Add TI dp83822 phy
  net: phy: DP83822: Add ability to advertise Fiber connection

 .../devicetree/bindings/net/ti,dp83822.yaml   |  80 +++++++
 drivers/net/phy/dp83822.c                     | 225 +++++++++++++++++-
 2 files changed, 298 insertions(+), 7 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/ti,dp83822.yaml

Comments

Andrew Lunn Aug. 27, 2020, 8:17 p.m. UTC | #1 
On Thu, Aug 27, 2020 at 08:45:09AM -0500, Dan Murphy wrote:
> The DP83822 can be configured to use a Fiber connection.  The strap
> register is read to determine if the device has been configured to use
> a fiber connection.  With the fiber connection the PHY can be configured
> to detect whether the fiber connection is active by either a high signal
> or a low signal.
> 
> Fiber mode is only applicable to the DP83822 so rework the PHY match
> table so that non-fiber PHYs can still use the same driver but not call
> or use any of the fiber features.
> 
> Signed-off-by: Dan Murphy <dmurphy@ti.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
David Miller Aug. 28, 2020, 2:07 p.m. UTC | #2 
From: Dan Murphy <dmurphy@ti.com>
Date: Thu, 27 Aug 2020 08:45:07 -0500

> The DP83822 Ethernet PHY has the ability to connect via a Fiber port.  The
> derivative PHYs DP83825 and DP83826 do not have this ability. In fiber mode
> the DP83822 disables auto negotiation and has a fixed 100Mbps speed with
> support for full or half duplex modes.
> 
> A devicetree binding was added to set the signal polarity for the fiber
> connection.  This property is only applicable if the FX_EN strap is set in
> hardware other wise the signal loss detection is disabled on the PHY.
> 
> If the FX_EN is not strapped the device can be configured to run in fiber mode
> via the device tree. All be it the PHY will not perform signal loss detection.
> 
> v2 review from a long time ago can be found here - https://lore.kernel.org/patchwork/patch/1270958/

Series applied, thank you.