diff mbox series

[net-next,v5,2/2] seg6: Add documentation for seg6_inherit_inner_ipv4_dscp sysctl

Message ID 20200825121844.1576-1-ahabdels@gmail.com
State Changes Requested
Delegated to: David Miller
Headers show
Series [net-next,v5,1/2] seg6: inherit DSCP of inner IPv4 packets | expand

Commit Message

Ahmed Abdelsalam Aug. 25, 2020, 12:18 p.m. UTC
This patch adds a documentation for seg6_inherit_inner_ipv4_dscp
sysctl into Documentation/networking/ip-sysctl.rst

Signed-off-by: Ahmed Abdelsalam <ahabdels@gmail.com>
---
 Documentation/networking/ip-sysctl.rst | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Jakub Kicinski Aug. 25, 2020, 3:51 p.m. UTC | #1
On Tue, 25 Aug 2020 12:18:44 +0000 Ahmed Abdelsalam wrote:
> +	Enable the SRv6 encapsulation to inherit the DSCP value of the inner IPv4 packet.                                                                                                         
> +
> +	Default: FALSE (Do not inherit DSCP)
> +
>  ``conf/default/*``:
>  	Change the interface-specific default settings.
>  

Checkpatch complains about whitespace:

ERROR: trailing whitespace
#24: FILE: Documentation/networking/ip-sysctl.rst:1802:
+seg6_inherit_inner_ipv4_dscp - BOOLEAN                                                                                                                                                                                                                                                                                                        $
Ahmed Abdelsalam Aug. 25, 2020, 4:01 p.m. UTC | #2
On 25/08/2020 17:51, Jakub Kicinski wrote:
> On Tue, 25 Aug 2020 12:18:44 +0000 Ahmed Abdelsalam wrote:
>> +	Enable the SRv6 encapsulation to inherit the DSCP value of the inner IPv4 packet.
>> +
>> +	Default: FALSE (Do not inherit DSCP)
>> +
>>   ``conf/default/*``:
>>   	Change the interface-specific default settings.
>>   
> 
> Checkpatch complains about whitespace:
> 
> ERROR: trailing whitespace
> #24: FILE: Documentation/networking/ip-sysctl.rst:1802:
> +seg6_inherit_inner_ipv4_dscp - BOOLEAN                                                                                                                                                                                                                                                                                                        $
> 
sorry forgot to run checkpatch on this one before sending.

patch fixed and resent.
David Miller Aug. 25, 2020, 4:23 p.m. UTC | #3
From: Ahmed Abdelsalam <ahabdels@gmail.com>
Date: Tue, 25 Aug 2020 18:01:01 +0200

> patch fixed and resent.

You must resubmit the entire patch series when you update any
patch in the series.

You should also provide a proper header "[PATCH 0/N]" posting
for your series which explains what the series does, how does
it do it, and why does it do it that way.

Thank you.
diff mbox series

Patch

diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst
index 837d51f9e1fa..9dacdebeafc5 100644
--- a/Documentation/networking/ip-sysctl.rst
+++ b/Documentation/networking/ip-sysctl.rst
@@ -1799,6 +1799,11 @@  seg6_flowlabel - INTEGER
 
 	Default is 0.
 
+seg6_inherit_inner_ipv4_dscp - BOOLEAN                                                                                                                                                                                                                                                                                                        
+	Enable the SRv6 encapsulation to inherit the DSCP value of the inner IPv4 packet.                                                                                                         
+
+	Default: FALSE (Do not inherit DSCP)
+
 ``conf/default/*``:
 	Change the interface-specific default settings.