| Message ID | 20200823080628.407637-1-idosch@idosch.org |
|---|---|
| Headers | show |
| Series | mlxsw: Misc updates | expand |
On Sun, 23 Aug 2020 11:06:21 +0300 Ido Schimmel wrote: > From: Ido Schimmel <idosch@nvidia.com> > > This patch set includes various updates for mlxsw. > > Patches #1-#4 adjust the default burst size of packet trap policers to > conform to Spectrum-{2,3} requirements. The corresponding selftest is > also adjusted so that it could reliably pass on these platforms. > > Patch #5 adjusts a selftest so that it could pass with both old and new > versions of mausezahn. > > Patch #6 significantly reduces the runtime of tc-police scale test by > changing the preference and masks of the used tc filters. > > Patch #7 prevents the driver from trying to set invalid ethtool link > modes. LGTM, so FWIW: Reviewed-by: Jakub Kicinski <kuba@kernel.org> 5 and 7 could have gone to net IMHO. Especially 7 - do I misinterpret that it exposes speeds which are not in fact supported? The commit message is not very clear on impact, and how the quoted error is triggered.
From: Ido Schimmel <idosch@idosch.org> Date: Sun, 23 Aug 2020 11:06:21 +0300 > From: Ido Schimmel <idosch@nvidia.com> > > This patch set includes various updates for mlxsw. > > Patches #1-#4 adjust the default burst size of packet trap policers to > conform to Spectrum-{2,3} requirements. The corresponding selftest is > also adjusted so that it could reliably pass on these platforms. > > Patch #5 adjusts a selftest so that it could pass with both old and new > versions of mausezahn. > > Patch #6 significantly reduces the runtime of tc-police scale test by > changing the preference and masks of the used tc filters. > > Patch #7 prevents the driver from trying to set invalid ethtool link > modes. Applied, thanks Ido.
From: Ido Schimmel <idosch@nvidia.com> This patch set includes various updates for mlxsw. Patches #1-#4 adjust the default burst size of packet trap policers to conform to Spectrum-{2,3} requirements. The corresponding selftest is also adjusted so that it could reliably pass on these platforms. Patch #5 adjusts a selftest so that it could pass with both old and new versions of mausezahn. Patch #6 significantly reduces the runtime of tc-police scale test by changing the preference and masks of the used tc filters. Patch #7 prevents the driver from trying to set invalid ethtool link modes. Danielle Ratson (2): selftests: forwarding: Fix mausezahn delay parameter in mirror_test() mlxsw: spectrum_ethtool: Remove internal speeds from PTYS register Ido Schimmel (5): mlxsw: spectrum_trap: Adjust default policer burst size for Spectrum-{2, 3} selftests: mlxsw: Decrease required rate accuracy selftests: mlxsw: Increase burst size for rate test selftests: mlxsw: Increase burst size for burst test selftests: mlxsw: Reduce runtime of tc-police scale test drivers/net/ethernet/mellanox/mlxsw/reg.h | 6 --- .../mellanox/mlxsw/spectrum_ethtool.c | 38 ------------------- .../ethernet/mellanox/mlxsw/spectrum_trap.c | 22 +++++------ .../net/ethernet/mellanox/mlxsw/switchx2.c | 25 +----------- .../drivers/net/mlxsw/devlink_trap_policer.sh | 33 +++------------- .../drivers/net/mlxsw/tc_police_scale.sh | 12 +++++- .../selftests/net/forwarding/mirror_lib.sh | 2 +- 7 files changed, 28 insertions(+), 110 deletions(-)