| Message ID | 20200821212659.14551-1-xie.he.0141@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net,v2] drivers/net/wan/lapbether: Added needed_tailroom | expand |
From: Xie He <xie.he.0141@gmail.com> Date: Fri, 21 Aug 2020 14:26:59 -0700 > The underlying Ethernet device may request necessary tailroom to be > allocated by setting needed_tailroom. This driver should also set > needed_tailroom to request the tailroom needed by the underlying > Ethernet device to be allocated. > > Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com> > Cc: Martin Schiller <ms@dev.tdt.de> > Signed-off-by: Xie He <xie.he.0141@gmail.com> Applied, thank you.
On Mon, Aug 24, 2020 at 4:09 PM David Miller <davem@davemloft.net> wrote: > > Applied, thank you. Thank you!
diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c index 1ea15f2123ed..cc297ea9c6ec 100644 --- a/drivers/net/wan/lapbether.c +++ b/drivers/net/wan/lapbether.c @@ -340,6 +340,7 @@ static int lapbeth_new_device(struct net_device *dev) */ ndev->needed_headroom = -1 + 3 + 2 + dev->hard_header_len + dev->needed_headroom; + ndev->needed_tailroom = dev->needed_tailroom; lapbeth = netdev_priv(ndev); lapbeth->axdev = ndev;
The underlying Ethernet device may request necessary tailroom to be allocated by setting needed_tailroom. This driver should also set needed_tailroom to request the tailroom needed by the underlying Ethernet device to be allocated. Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com> Cc: Martin Schiller <ms@dev.tdt.de> Signed-off-by: Xie He <xie.he.0141@gmail.com> --- Change from v1: None I'm re-sending this patch unchanged because the previous reviewer has stopped responding for 11 days and he didn't indicate what change I should do to this patch. It's hard to find reviewers for this code. I tried to send emails, but people don't respond. If you can review it, I'd really appreciate it. I'm not in a hurry so please take your time. Thanks! --- drivers/net/wan/lapbether.c | 1 + 1 file changed, 1 insertion(+)