| Message ID | 20200823085650.912-1-dinghao.liu@zju.edu.cn |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: arc_emac: Fix memleak in arc_mdio_probe | expand |
On Sun, Aug 23, 2020 at 04:56:47PM +0800, Dinghao Liu wrote: > When devm_gpiod_get_optional() fails, bus should be > freed just like when of_mdiobus_register() fails. > > Fixes: 1bddd96cba03d ("net: arc_emac: support the phy reset for emac driver") > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
From: Dinghao Liu <dinghao.liu@zju.edu.cn> Date: Sun, 23 Aug 2020 16:56:47 +0800 > When devm_gpiod_get_optional() fails, bus should be > freed just like when of_mdiobus_register() fails. > > Fixes: 1bddd96cba03d ("net: arc_emac: support the phy reset for emac driver") > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Applied, thank you.
diff --git a/drivers/net/ethernet/arc/emac_mdio.c b/drivers/net/ethernet/arc/emac_mdio.c index 0187dbf3b87d..54cdafdd067d 100644 --- a/drivers/net/ethernet/arc/emac_mdio.c +++ b/drivers/net/ethernet/arc/emac_mdio.c @@ -153,6 +153,7 @@ int arc_mdio_probe(struct arc_emac_priv *priv) if (IS_ERR(data->reset_gpio)) { error = PTR_ERR(data->reset_gpio); dev_err(priv->dev, "Failed to request gpio: %d\n", error); + mdiobus_free(bus); return error; }
When devm_gpiod_get_optional() fails, bus should be freed just like when of_mdiobus_register() fails. Fixes: 1bddd96cba03d ("net: arc_emac: support the phy reset for emac driver") Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> --- drivers/net/ethernet/arc/emac_mdio.c | 1 + 1 file changed, 1 insertion(+)