diff mbox series

[v3,1/2] dt-bindings: nvmem: Add syscon to Vybrid OCOTP driver

Message ID 20200821212102.137991-1-cphealy@gmail.com
State Superseded, archived
Headers show
Series [v3,1/2] dt-bindings: nvmem: Add syscon to Vybrid OCOTP driver | expand

Checks

Context Check Description
robh/checkpatch warning total: 0 errors, 1 warnings, 8 lines checked

Commit Message

Chris Healy Aug. 21, 2020, 9:21 p.m. UTC
From: Chris Healy <cphealy@gmail.com>

Add syscon compatibility with Vybrid OCOTP driver binding. This is
required to access the UID.

Fixes: fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP")
Cc: stable@vger.kernel.org
Signed-off-by: Chris Healy <cphealy@gmail.com>
---
 Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Shawn Guo Aug. 23, 2020, 3:12 a.m. UTC | #1
On Fri, Aug 21, 2020 at 02:21:01PM -0700, Chris Healy wrote:
> From: Chris Healy <cphealy@gmail.com>
> 
> Add syscon compatibility with Vybrid OCOTP driver binding. This is
> required to access the UID.
> 
> Fixes: fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP")

The bindings doc was not added by this commit though.

> Cc: stable@vger.kernel.org
> Signed-off-by: Chris Healy <cphealy@gmail.com>
> ---
>  Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt b/Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt
> index 56ed481c3e26..5db39f399568 100644
> --- a/Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt
> +++ b/Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt
> @@ -11,7 +11,7 @@ Required Properties:
>  Example for Vybrid VF5xx/VF6xx:
>  
>  	ocotp: ocotp@400a5000 {
> -		compatible = "fsl,vf610-ocotp";
> +		compatible = "fsl,vf610-ocotp", "syscon";

It's not only about fixing example.  More important one is "compatible"
property of the bindings.

Shawn

>  		#address-cells = <1>;
>  		#size-cells = <1>;
>  		reg = <0x400a5000 0xCF0>;
> -- 
> 2.26.2
>
Shawn Guo Aug. 23, 2020, 3:13 a.m. UTC | #2
On Fri, Aug 21, 2020 at 02:21:02PM -0700, Chris Healy wrote:
> From: Chris Healy <cphealy@gmail.com>
> 
> Add syscon compatibility with Vybrid OCOTP node. This is required to
> access the UID.
> 
> Fixes: fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP")
> Cc: stable@vger.kernel.org
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> Reviewed-by: Stefan Agner <stefan@agner.ch>
> Signed-off-by: Chris Healy <cphealy@gmail.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt b/Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt
index 56ed481c3e26..5db39f399568 100644
--- a/Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt
+++ b/Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt
@@ -11,7 +11,7 @@  Required Properties:
 Example for Vybrid VF5xx/VF6xx:
 
 	ocotp: ocotp@400a5000 {
-		compatible = "fsl,vf610-ocotp";
+		compatible = "fsl,vf610-ocotp", "syscon";
 		#address-cells = <1>;
 		#size-cells = <1>;
 		reg = <0x400a5000 0xCF0>;