Message ID | 20200822180611.2576807-1-andrew@lunn.ch |
---|---|
Headers | show |
Series | Move MDIO drivers into there own directory | expand |
From: Andrew Lunn <andrew@lunn.ch> Date: Sat, 22 Aug 2020 20:06:06 +0200 > The phy subdirectory is getting cluttered. It has both PHY drivers and > MDIO drivers, plus a stray switch driver. Soon more PCS drivers are > likely to appear. > > Move MDIO and PCS drivers into new directories. This requires fixing > up the xgene driver which uses a relative include path. > > v2: > Move the subdirs to drivers/net, rather than drivers/net/phy. > > v3: > Add subdirectories under include/linux for mdio and pcs Series applied with "there" --> "their" fixed up as needed :-) Thanks Andrew!
Hi David I just got a 0-day warning. I will send a fixup soon. Andrew
From: Andrew Lunn <andrew@lunn.ch> Date: Sat, 22 Aug 2020 21:51:44 +0200 > I just got a 0-day warning. I will send a fixup soon. I also get this when I simply type make after your changes: WARNING: unmet direct dependencies detected for PCS_XPCS Depends on [n]: NETDEVICES [=y] && PCS_DEVICE [=n] Selected by [m]: - STMMAC_ETH [=m] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_STMICRO [=y] && HAS_IOMEM [=y] && HAS_DMA [=y] And then it prompts me for: PCS device drivers (PCS_DEVICE) [N/m/y/?] (NEW) This is on a tree that had an allmodconfig config before your changes. I really don't think users should get prompted for things like this just because the source files were rearranged into different directories. Why don't you submit a full v4 once you've resolved all of these items? Thanks!
> Why don't you submit a full v4 once you've resolved all of these items?
O.K, will do.
Andrew