| Message ID | 20200819160710.1345956-1-vkabatov@redhat.com |
|---|---|
| State | Accepted |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | [v2] selftests/bpf: Remove test_align leftovers | expand |
On Wed, 19 Aug 2020 18:07:10 +0200 Veronika Kabatova <vkabatov@redhat.com> wrote: > Calling generic selftests "make install" fails as rsync expects all > files from TEST_GEN_PROGS to be present. The binary is not generated > anymore (commit 3b09d27cc93d) so we can safely remove it from there > and also from gitignore. > > Fixes: 3b09d27cc93d ("selftests/bpf: Move test_align under test_progs") > Signed-off-by: Veronika Kabatova <vkabatov@redhat.com> > --- > tools/testing/selftests/bpf/.gitignore | 1 - > tools/testing/selftests/bpf/Makefile | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
On Wed, Aug 19, 2020 at 9:17 AM Jesper Dangaard Brouer <brouer@redhat.com> wrote: > > On Wed, 19 Aug 2020 18:07:10 +0200 > Veronika Kabatova <vkabatov@redhat.com> wrote: > > > Calling generic selftests "make install" fails as rsync expects all > > files from TEST_GEN_PROGS to be present. The binary is not generated > > anymore (commit 3b09d27cc93d) so we can safely remove it from there > > and also from gitignore. > > > > Fixes: 3b09d27cc93d ("selftests/bpf: Move test_align under test_progs") > > Signed-off-by: Veronika Kabatova <vkabatov@redhat.com> > > --- > > tools/testing/selftests/bpf/.gitignore | 1 - > > tools/testing/selftests/bpf/Makefile | 2 +- > > 2 files changed, 1 insertion(+), 2 deletions(-) > > Acked-by: Jesper Dangaard Brouer <brouer@redhat.com> Applied to bpf tree. Thanks
diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitignore index 1bb204cee853..9a0946ddb705 100644 --- a/tools/testing/selftests/bpf/.gitignore +++ b/tools/testing/selftests/bpf/.gitignore @@ -6,7 +6,6 @@ test_lpm_map test_tag FEATURE-DUMP.libbpf fixdep -test_align test_dev_cgroup /test_progs* test_tcpbpf_user diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile index a83b5827532f..fc946b7ac288 100644 --- a/tools/testing/selftests/bpf/Makefile +++ b/tools/testing/selftests/bpf/Makefile @@ -32,7 +32,7 @@ LDLIBS += -lcap -lelf -lz -lrt -lpthread # Order correspond to 'make run_tests' order TEST_GEN_PROGS = test_verifier test_tag test_maps test_lru_map test_lpm_map test_progs \ - test_align test_verifier_log test_dev_cgroup test_tcpbpf_user \ + test_verifier_log test_dev_cgroup test_tcpbpf_user \ test_sock test_btf test_sockmap get_cgroup_id_user test_socket_cookie \ test_cgroup_storage \ test_netcnt test_tcpnotify_user test_sock_fields test_sysctl \
Calling generic selftests "make install" fails as rsync expects all files from TEST_GEN_PROGS to be present. The binary is not generated anymore (commit 3b09d27cc93d) so we can safely remove it from there and also from gitignore. Fixes: 3b09d27cc93d ("selftests/bpf: Move test_align under test_progs") Signed-off-by: Veronika Kabatova <vkabatov@redhat.com> --- tools/testing/selftests/bpf/.gitignore | 1 - tools/testing/selftests/bpf/Makefile | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-)